<p>Neels Hofmeyr <strong>uploaded patch set #5</strong> to this change.</p><p><a href="https://gerrit.osmocom.org/12402">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">enrich context for vlr_subscr_name and ran_conn fi name<br><br>Include all available information in vlr_subscr_name(); instead of either IMSI<br>or MSISDN or TMSI, print all of them when present. Instead of a short log,<br>rather have more valuable context.<br><br>A context info would now look like:<br><br>  Process_Access_Request_VLR(GERAN-A-3_IMSI-901700000014706_MSISDN-2023_TMSI-0x08BDE4EC_PAGING_RESP)<br><br>It does get quite long, but ensures easy correlation of any BSSAP / IuCS<br>messages with log output, especially if multiple subscribers are busy at the<br>same time.<br><br>Print TMSI and TMSInew in uppercase hexadecimal, which is the typical<br>representation in the telecom world.<br><br>When showing the RAN conn id<br>  GERAN_A-00000017<br>becomes<br>  GERAN-A-23<br>- We usually write the conn_id in decimal.<br>- Leading zeros are clutter and might suggest hexadecimal format.<br>- 'GERAN-A' and 'UTRAN-Iu' are the strings defined by osmo_rat_type_name().<br><br>Change-Id: I66a68ce2eb8957a35855a3743d91a86299900834<br>---<br>M include/osmocom/msc/ran_conn.h<br>M src/libmsc/gsm_04_08.c<br>M src/libmsc/ran_conn.c<br>M src/libvlr/vlr.c<br>M tests/msc_vlr/msc_vlr_test_authen_reuse.err<br>M tests/msc_vlr/msc_vlr_test_call.err<br>M tests/msc_vlr/msc_vlr_test_gsm_authen.err<br>M tests/msc_vlr/msc_vlr_test_gsm_ciph.err<br>M tests/msc_vlr/msc_vlr_test_hlr_reject.err<br>M tests/msc_vlr/msc_vlr_test_hlr_timeout.err<br>M tests/msc_vlr/msc_vlr_test_ms_timeout.err<br>M tests/msc_vlr/msc_vlr_test_no_authen.err<br>M tests/msc_vlr/msc_vlr_test_reject_concurrency.err<br>M tests/msc_vlr/msc_vlr_test_rest.err<br>M tests/msc_vlr/msc_vlr_test_ss.err<br>M tests/msc_vlr/msc_vlr_test_umts_authen.err<br>16 files changed, 11,379 insertions(+), 11,140 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/02/12402/5</pre><p>To view, visit <a href="https://gerrit.osmocom.org/12402">change 12402</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12402"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newpatchset </div>
<div style="display:none"> Gerrit-Change-Id: I66a68ce2eb8957a35855a3743d91a86299900834 </div>
<div style="display:none"> Gerrit-Change-Number: 12402 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>