<p>Vadim Yanitskiy <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/11157">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Max: Looks good to me, but someone else must approve
  Vadim Yanitskiy: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">trxcon/scheduler: fix RSSI -> RX level conversion<br><br>Due to a mistake, average RSSI value of received bursts was not<br>converted to GSM RX level (range 0..63), so trxcon has been<br>sending incorrect values to the higher layers.<br><br>Let's fix this, and also prevent possible division by zero.<br><br>Change-Id: Id4659de899411ec1ba1718fdcb40aec562dbfd65<br>---<br>M src/host/trxcon/sched_lchan_common.c<br>1 file changed, 11 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/host/trxcon/sched_lchan_common.c b/src/host/trxcon/sched_lchan_common.c</span><br><span>index 95e496b..540a57f 100644</span><br><span>--- a/src/host/trxcon/sched_lchan_common.c</span><br><span>+++ b/src/host/trxcon/sched_lchan_common.c</span><br><span>@@ -87,6 +87,7 @@</span><br><span> {</span><br><span>         const struct trx_lchan_desc *lchan_desc;</span><br><span>     struct l1ctl_info_dl dl_hdr;</span><br><span style="color: hsl(120, 100%, 40%);">+  int dbm_avg;</span><br><span> </span><br><span>     /* Set up pointers */</span><br><span>        lchan_desc = &trx_lchan_desc[lchan->type];</span><br><span>@@ -96,9 +97,18 @@</span><br><span>       dl_hdr.link_id = lchan_desc->link_id;</span><br><span>     dl_hdr.band_arfcn = htons(trx->band_arfcn);</span><br><span>       dl_hdr.frame_nr = htonl(lchan->rx_first_fn);</span><br><span style="color: hsl(0, 100%, 40%);">- dl_hdr.rx_level = -(lchan->meas.rssi_sum / lchan->meas.rssi_num);</span><br><span>      dl_hdr.num_biterr = bit_error_count;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+      /* Convert average RSSI to RX level */</span><br><span style="color: hsl(120, 100%, 40%);">+        if (lchan->meas.rssi_num) {</span><br><span style="color: hsl(120, 100%, 40%);">+                /* RX level: 0 .. 63 in typical GSM notation (dBm + 110) */</span><br><span style="color: hsl(120, 100%, 40%);">+           dbm_avg = lchan->meas.rssi_sum / lchan->meas.rssi_num;</span><br><span style="color: hsl(120, 100%, 40%);">+          dl_hdr.rx_level = dbm2rxlev(dbm_avg);</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+              /* No measurements, assuming the worst */</span><br><span style="color: hsl(120, 100%, 40%);">+             dl_hdr.rx_level = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+  }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>  /* FIXME: set proper values */</span><br><span>       dl_hdr.snr = 0;</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11157">change 11157</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11157"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmocom-bb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Id4659de899411ec1ba1718fdcb40aec562dbfd65 </div>
<div style="display:none"> Gerrit-Change-Number: 11157 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Max <msuraev@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>