<p>Vadim Yanitskiy <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/11718">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Harald Welte: Looks good to me, approved
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">MSC_Tests.ttcn: introduce TC_gsup_mo_sms for MO SMS over GSUP<br><br>The idea of this test case is to verify MO SMS transmission<br>over GSUP towards HLR. Basically, the algorythm is the following:<br><br> 1.0 establish a RAN connection,<br> 2.1 send CP-DATA/RP-DATA on BSSAP/DTAP,<br> 2.2 expect MO-ForwardSM-Req on GSUP,<br> 3.1 send MO-ForwardSM-Res on GSUP,<br> 3.2 expect CP-DATA/RP-ACK on BSSAP/DTAP.<br><br>Change-Id: Id14bbd8bd51558cdacefea0fe042769cd69ed5c8<br>Related: OS#3587<br>---<br>M msc/MSC_Tests.ttcn<br>M msc/expected-results.xml<br>2 files changed, 73 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn</span><br><span>index 0ac61bc..202bce7 100644</span><br><span>--- a/msc/MSC_Tests.ttcn</span><br><span>+++ b/msc/MSC_Tests.ttcn</span><br><span>@@ -44,6 +44,7 @@</span><br><span> </span><br><span> import from MobileL3_Types all;</span><br><span> import from MobileL3_CommonIE_Types all;</span><br><span style="color: hsl(120, 100%, 40%);">+import from MobileL3_SMS_Types all;</span><br><span> import from L3_Templates all;</span><br><span> import from L3_Common all;</span><br><span> </span><br><span>@@ -2028,6 +2029,75 @@</span><br><span> f_vty_config2(MSCVTY, { "smpp", "esme msc_tester"}, "no default-route");</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* Test MO-SMS from MS/BTS/BSC towards HLR (via GSUP) */</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_tc_gsup_mo_sms(charstring id, BSC_ConnHdlrPars pars)</span><br><span style="color: hsl(120, 100%, 40%);">+runs on BSC_ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+ var SmsParameters spars := valueof(t_SmsPars);</span><br><span style="color: hsl(120, 100%, 40%);">+ var GSUP_PDU gsup_msg_rx;</span><br><span style="color: hsl(120, 100%, 40%);">+ var octetstring sm_tpdu;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init_handler(pars);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* We need to inspect GSUP activity */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_create_gsup_expect(hex2str(g_pars.imsi));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Perform location update */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_perform_lu();</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Send CM Service Request for SMS */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_establish_fully(EST_TYPE_MO_SMS);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Prepare expected SM-RP-UI (SM TPDU) */</span><br><span style="color: hsl(120, 100%, 40%);">+ enc_TPDU_RP_DATA_MS_SGSN_fast(</span><br><span style="color: hsl(120, 100%, 40%);">+ valueof(ts_SMS_SUBMIT(spars.tp.msg_ref,</span><br><span style="color: hsl(120, 100%, 40%);">+ spars.tp.da, spars.tp.pid, spars.tp.dcs,</span><br><span style="color: hsl(120, 100%, 40%);">+ spars.tp.udl, spars.tp.ud)),</span><br><span style="color: hsl(120, 100%, 40%);">+ sm_tpdu);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ var template GSUP_PDU mo_forwardSM := tr_GSUP_MO_FORWARD_SM_REQ(</span><br><span style="color: hsl(120, 100%, 40%);">+ imsi := g_pars.imsi,</span><br><span style="color: hsl(120, 100%, 40%);">+ sm_rp_mr := spars.rp.msg_ref,</span><br><span style="color: hsl(120, 100%, 40%);">+ /* FIXME: extract SM-RP-DA from spars.rp.dest */</span><br><span style="color: hsl(120, 100%, 40%);">+ sm_rp_da := tr_GSUP_SM_RP_DA_SMSC_ADDR(?),</span><br><span style="color: hsl(120, 100%, 40%);">+ /* FIXME: MSISDN coding troubles */</span><br><span style="color: hsl(120, 100%, 40%);">+ sm_rp_oa := tr_GSUP_SM_RP_OA_MSISDN(?),</span><br><span style="color: hsl(120, 100%, 40%);">+ /* TODO: can we use decmatch here? */</span><br><span style="color: hsl(120, 100%, 40%);">+ sm_rp_ui := sm_tpdu</span><br><span style="color: hsl(120, 100%, 40%);">+ );</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Submit an SMS on DTAP and expect MO-forwardSM-Req on GSUP */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_mo_sms_submit(spars);</span><br><span style="color: hsl(120, 100%, 40%);">+ alt {</span><br><span style="color: hsl(120, 100%, 40%);">+ [] GSUP.receive(mo_forwardSM) -> value gsup_msg_rx {</span><br><span style="color: hsl(120, 100%, 40%);">+ log("RX MO-forwardSM-Req");</span><br><span style="color: hsl(120, 100%, 40%);">+ log(gsup_msg_rx);</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(pass);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ [] GSUP.receive {</span><br><span style="color: hsl(120, 100%, 40%);">+ log("RX unexpected GSUP message");</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail);</span><br><span style="color: hsl(120, 100%, 40%);">+ mtc.stop;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Trigger RP-ACK by sending MO-forwardSM-Res */</span><br><span style="color: hsl(120, 100%, 40%);">+ GSUP.send(valueof(ts_GSUP_MO_FORWARD_SM_RES(</span><br><span style="color: hsl(120, 100%, 40%);">+ imsi := g_pars.imsi,</span><br><span style="color: hsl(120, 100%, 40%);">+ sm_rp_mr := spars.rp.msg_ref)));</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Expect RP-ACK on DTAP */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_mo_sms_wait_rp_ack(spars);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_expect_clear();</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_gsup_mo_sms() runs on MTC_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ var BSC_ConnHdlr vc_conn;</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init();</span><br><span style="color: hsl(120, 100%, 40%);">+ f_vty_config(MSCVTY, "msc", "sms-over-gsup");</span><br><span style="color: hsl(120, 100%, 40%);">+ vc_conn := f_start_handler(refers(f_tc_gsup_mo_sms), 88);</span><br><span style="color: hsl(120, 100%, 40%);">+ vc_conn.done;</span><br><span style="color: hsl(120, 100%, 40%);">+ f_vty_config(MSCVTY, "msc", "no sms-over-gsup");</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* convert GSM L3 TON to SMPP_TON enum */</span><br><span> function f_sm_ton_from_gsm(BIT3 ton) return SMPP_TON {</span><br><span> select (ton) {</span><br><span>@@ -2913,6 +2983,8 @@</span><br><span> execute( TC_smpp_mo_sms() );</span><br><span> execute( TC_smpp_mt_sms() );</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ execute( TC_gsup_mo_sms() );</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> execute( TC_lu_and_mo_ussd_single_request() );</span><br><span> execute( TC_lu_and_mt_ussd_notification() );</span><br><span> execute( TC_lu_and_mo_ussd_during_mt_call() );</span><br><span>diff --git a/msc/expected-results.xml b/msc/expected-results.xml</span><br><span>index 83c8010..49ca1e3 100644</span><br><span>--- a/msc/expected-results.xml</span><br><span>+++ b/msc/expected-results.xml</span><br><span>@@ -63,6 +63,7 @@</span><br><span> <testcase classname='MSC_Tests' name='TC_lu_and_mt_sms' time='MASKED'/></span><br><span> <testcase classname='MSC_Tests' name='TC_smpp_mo_sms' time='MASKED'/></span><br><span> <testcase classname='MSC_Tests' name='TC_smpp_mt_sms' time='MASKED'/></span><br><span style="color: hsl(120, 100%, 40%);">+ <testcase classname='MSC_Tests' name='TC_gsup_mo_sms' time='MASKED'/></span><br><span> <testcase classname='MSC_Tests' name='TC_lu_and_mo_ussd_single_request' time='MASKED'/></span><br><span> <testcase classname='MSC_Tests' name='TC_lu_and_mt_ussd_notification' time='MASKED'/></span><br><span> <testcase classname='MSC_Tests' name='TC_lu_and_mo_ussd_during_mt_call' time='MASKED'/></span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11718">change 11718</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11718"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Id14bbd8bd51558cdacefea0fe042769cd69ed5c8 </div>
<div style="display:none"> Gerrit-Change-Number: 11718 </div>
<div style="display:none"> Gerrit-PatchSet: 7 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>