<p>Max <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/12447">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Constify transaction helpers parameters<br><br>Change-Id: If002a1ff6ba4218cc16592946798340fcb1852ae<br>---<br>M include/osmocom/msc/transaction.h<br>M src/libmsc/transaction.c<br>2 files changed, 10 insertions(+), 10 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/msc/transaction.h b/include/osmocom/msc/transaction.h</span><br><span>index 0760c07..e82f0a5 100644</span><br><span>--- a/include/osmocom/msc/transaction.h</span><br><span>+++ b/include/osmocom/msc/transaction.h</span><br><span>@@ -98,11 +98,11 @@</span><br><span> </span><br><span> </span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-struct gsm_trans *trans_find_by_id(struct ran_conn *conn,</span><br><span style="color: hsl(120, 100%, 40%);">+struct gsm_trans *trans_find_by_id(const struct ran_conn *conn,</span><br><span>                                 uint8_t proto, uint8_t trans_id);</span><br><span style="color: hsl(0, 100%, 40%);">-struct gsm_trans *trans_find_by_callref(struct gsm_network *net,</span><br><span style="color: hsl(120, 100%, 40%);">+struct gsm_trans *trans_find_by_callref(const struct gsm_network *net,</span><br><span>                                         uint32_t callref);</span><br><span style="color: hsl(0, 100%, 40%);">-struct gsm_trans *trans_find_by_sm_rp_mr(struct ran_conn *conn,</span><br><span style="color: hsl(120, 100%, 40%);">+struct gsm_trans *trans_find_by_sm_rp_mr(const struct ran_conn *conn,</span><br><span>                                      uint8_t sm_rp_mr);</span><br><span> </span><br><span> struct gsm_trans *trans_alloc(struct gsm_network *net,</span><br><span>@@ -111,9 +111,9 @@</span><br><span>                            uint32_t callref);</span><br><span> void trans_free(struct gsm_trans *trans);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-int trans_assign_trans_id(struct gsm_network *net, struct vlr_subscr *vsub,</span><br><span style="color: hsl(120, 100%, 40%);">+int trans_assign_trans_id(const struct gsm_network *net, const struct vlr_subscr *vsub,</span><br><span>                          uint8_t protocol, uint8_t ti_flag);</span><br><span> struct gsm_trans *trans_has_conn(const struct ran_conn *conn);</span><br><span style="color: hsl(0, 100%, 40%);">-void trans_conn_closed(struct ran_conn *conn);</span><br><span style="color: hsl(120, 100%, 40%);">+void trans_conn_closed(const struct ran_conn *conn);</span><br><span> </span><br><span> #endif</span><br><span>diff --git a/src/libmsc/transaction.c b/src/libmsc/transaction.c</span><br><span>index a0f7b31..f62d6b4 100644</span><br><span>--- a/src/libmsc/transaction.c</span><br><span>+++ b/src/libmsc/transaction.c</span><br><span>@@ -38,7 +38,7 @@</span><br><span>  * \param[in] trans_id Transaction ID of transaction</span><br><span>  * \returns Matching transaction, if any</span><br><span>  */</span><br><span style="color: hsl(0, 100%, 40%);">-struct gsm_trans *trans_find_by_id(struct ran_conn *conn,</span><br><span style="color: hsl(120, 100%, 40%);">+struct gsm_trans *trans_find_by_id(const struct ran_conn *conn,</span><br><span>                                 uint8_t proto, uint8_t trans_id)</span><br><span> {</span><br><span>     struct gsm_trans *trans;</span><br><span>@@ -59,7 +59,7 @@</span><br><span>  * \param[in] callref Call Reference of transaction</span><br><span>  * \returns Matching transaction, if any</span><br><span>  */</span><br><span style="color: hsl(0, 100%, 40%);">-struct gsm_trans *trans_find_by_callref(struct gsm_network *net,</span><br><span style="color: hsl(120, 100%, 40%);">+struct gsm_trans *trans_find_by_callref(const struct gsm_network *net,</span><br><span>                                       uint32_t callref)</span><br><span> {</span><br><span>       struct gsm_trans *trans;</span><br><span>@@ -76,7 +76,7 @@</span><br><span>  * \param[in] sm_rp_mr RP Message Reference (see GSM TS 04.11, section 8.2.3)</span><br><span>  * \returns Matching transaction, NULL otherwise</span><br><span>  */</span><br><span style="color: hsl(0, 100%, 40%);">-struct gsm_trans *trans_find_by_sm_rp_mr(struct ran_conn *conn,</span><br><span style="color: hsl(120, 100%, 40%);">+struct gsm_trans *trans_find_by_sm_rp_mr(const struct ran_conn *conn,</span><br><span>                                        uint8_t sm_rp_mr)</span><br><span> {</span><br><span>      struct gsm_network *net = conn->network;</span><br><span>@@ -182,7 +182,7 @@</span><br><span>  * \param[in] protocol Protocol for whihc to find ID</span><br><span>  * \param[in] ti_flag FIXME</span><br><span>  */</span><br><span style="color: hsl(0, 100%, 40%);">-int trans_assign_trans_id(struct gsm_network *net, struct vlr_subscr *vsub,</span><br><span style="color: hsl(120, 100%, 40%);">+int trans_assign_trans_id(const struct gsm_network *net, const struct vlr_subscr *vsub,</span><br><span>                    uint8_t protocol, uint8_t ti_flag)</span><br><span> {</span><br><span>    struct gsm_trans *trans;</span><br><span>@@ -234,7 +234,7 @@</span><br><span>  * facilities, which will then send the necessary release indications.</span><br><span>  * \param[in] conn Connection that is going to be closed.</span><br><span>  */</span><br><span style="color: hsl(0, 100%, 40%);">-void trans_conn_closed(struct ran_conn *conn)</span><br><span style="color: hsl(120, 100%, 40%);">+void trans_conn_closed(const struct ran_conn *conn)</span><br><span> {</span><br><span>  struct gsm_trans *trans;</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/12447">change 12447</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12447"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: If002a1ff6ba4218cc16592946798340fcb1852ae </div>
<div style="display:none"> Gerrit-Change-Number: 12447 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Max <msuraev@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Max <msuraev@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Stefan Sperling <stsp@stsp.name> </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>