<p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p><a href="https://gerrit.osmocom.org/5629">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/5629/2/include/osmocom/gprs/gprs_bssgp.h">File include/osmocom/gprs/gprs_bssgp.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/5629/2/include/osmocom/gprs/gprs_bssgp.h@69">Patch Set #2, Line 69:</a> <code style="font-family:monospace,monospace">  struct timeval time_last_pdu;   /*!< deprecated! will be replaced by t_last_pdu eventually */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Same as prev commit, eventually? it's actually being removed now.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/5629/2/src/gb/gprs_bssgp.c">File src/gb/gprs_bssgp.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/5629/2/src/gb/gprs_bssgp.c@619">Patch Set #2, Line 619:</a> <code style="font-family:monospace,monospace">      if (clock_gettime(CLOCK_MONOTONIC, &fc->t_last_pdu) != 0)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">osmo_clock_gettime.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/5629/2/tests/gb/bssgp_fc_test.c">File tests/gb/bssgp_fc_test.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/5629/2/tests/gb/bssgp_fc_test.c@104">Patch Set #2, Line 104:</a> <code style="font-family:monospace,monospace">         fc->t_last_pdu.tv_nsec += OSMO_USEC2NS(100000);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">better use timeradd from osmocom/core/timer_compat.h</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/5629">change 5629</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/5629"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: If190a634aa8334cae55df8c41877400d2f5603a2 </div>
<div style="display:none"> Gerrit-Change-Number: 5629 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Max <msuraev@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Max <msuraev@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Sun, 30 Dec 2018 23:40:31 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>