<p>Vadim Yanitskiy <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/12427">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">layer23/common/sim.c: don't ignore rc of sim_apdu_send()<br><br>Change-Id: I8cab7cc72f026947859cc607f65d925803424cf7<br>---<br>M src/host/layer23/src/common/sim.c<br>1 file changed, 5 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/host/layer23/src/common/sim.c b/src/host/layer23/src/common/sim.c</span><br><span>index 7f5240d..9d14cd3 100644</span><br><span>--- a/src/host/layer23/src/common/sim.c</span><br><span>+++ b/src/host/layer23/src/common/sim.c</span><br><span>@@ -186,6 +186,8 @@</span><br><span> /* send APDU to card reader */</span><br><span> static int sim_apdu_send(struct osmocom_ms *ms, uint8_t *data, uint16_t length)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+     int rc;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>    LOGP(DSIM, LOGL_INFO, "sending APDU (class 0x%02x, ins 0x%02x)\n",</span><br><span>                 data[0], data[1]);</span><br><span> </span><br><span>@@ -203,13 +205,13 @@</span><br><span>        * it makes more sense to do it here then in L1CTL */</span><br><span>        if (ms->subscr.sim_type == GSM_SIM_TYPE_SAP) {</span><br><span>            LOGP(DSIM, LOGL_INFO, "Using SAP backend\n");</span><br><span style="color: hsl(0, 100%, 40%);">-         osmosap_send_apdu(ms, data, length);</span><br><span style="color: hsl(120, 100%, 40%);">+          rc = osmosap_send_apdu(ms, data, length);</span><br><span>    } else {</span><br><span>             LOGP(DSIM, LOGL_INFO, "Using built-in SIM reader\n");</span><br><span style="color: hsl(0, 100%, 40%);">-         l1ctl_tx_sim_req(ms, data, length);</span><br><span style="color: hsl(120, 100%, 40%);">+           rc = l1ctl_tx_sim_req(ms, data, length);</span><br><span>     }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   return 0;</span><br><span style="color: hsl(120, 100%, 40%);">+     return rc;</span><br><span> }</span><br><span> </span><br><span> /* dequeue messages (RSL-SAP) */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/12427">change 12427</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12427"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmocom-bb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I8cab7cc72f026947859cc607f65d925803424cf7 </div>
<div style="display:none"> Gerrit-Change-Number: 12427 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>