<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/12391">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Harald Welte: Looks good to me, approved
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">BTS_Tests: Verify RSL MS POWER CONTROL and SACCH MS POWER LEVEL<br><br>Usually the MS power is controlled by the BTS and there is no continous<br>supervison by the BSC needed. However, a scheme where the BSC takes care<br>of the power control loop exists. The power is then set via RSL using an<br>RSL MS POWER CONTROL message.<br><br>This tests establishes a dchan and then sends MS POWER CONTROL messages<br>with differen power levels and then checks the presence of the power<br>level set in the MS POWER LEVEL field of the SACCH L1 header.<br><br>Change-Id: I82b04a3bf94d355175f7f6ff3fdc43672e8080a2<br>Related: OS#1622<br>---<br>M bts/BTS_Tests.ttcn<br>M bts/expected-results.xml<br>M library/RSL_Types.ttcn<br>3 files changed, 84 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn</span><br><span>index 753d89b..0de787a 100644</span><br><span>--- a/bts/BTS_Tests.ttcn</span><br><span>+++ b/bts/BTS_Tests.ttcn</span><br><span>@@ -1502,6 +1502,76 @@</span><br><span> Misc_Helpers.f_shutdown(__BFILE__, __LINE__);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* establish DChan, and send MS POWER CONTROL messages via RSL, verify that</span><br><span style="color: hsl(120, 100%, 40%);">+ * the BTS is forwarding those values to the MS via the SACCH L1 header. */</span><br><span style="color: hsl(120, 100%, 40%);">+function f_tc_rsl_ms_pwr_ctrl(charstring id) runs on ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+ var L1ctlDlMessage l1_dl;</span><br><span style="color: hsl(120, 100%, 40%);">+ var RSL_IE_MS_Power ms_power;</span><br><span style="color: hsl(120, 100%, 40%);">+ var RSL_Message rsl;</span><br><span style="color: hsl(120, 100%, 40%);">+ var uint5_t power_level := 0;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_l1_tune(L1CTL);</span><br><span style="color: hsl(120, 100%, 40%);">+ RSL.clear;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_est_dchan();</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ ms_power.reserved := 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ ms_power.fpc_epc := false;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Send the first power control command. This will disable any BTS/TRX</span><br><span style="color: hsl(120, 100%, 40%);">+ * internal power control and switch the MS (which is not in scope of</span><br><span style="color: hsl(120, 100%, 40%);">+ * this test) to a constant power level. We start with a power level</span><br><span style="color: hsl(120, 100%, 40%);">+ * of 0 */</span><br><span style="color: hsl(120, 100%, 40%);">+ ms_power.power_level := power_level;</span><br><span style="color: hsl(120, 100%, 40%);">+ rsl := valueof(ts_RSL_MS_PWR_CTRL(g_chan_nr, ms_power));</span><br><span style="color: hsl(120, 100%, 40%);">+ RSL.send(rsl);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ alt {</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Pick all SACCH blocks for checking */</span><br><span style="color: hsl(120, 100%, 40%);">+ [] L1CTL.receive(tr_L1CTL_DATA_IND(g_chan_nr, tr_RslLinkID_SACCH(?))) -> value l1_dl {</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* The first byte of the L1 header contains the power level.</span><br><span style="color: hsl(120, 100%, 40%);">+ * The reserved bits and the fpc bit is set to 0, so we may</span><br><span style="color: hsl(120, 100%, 40%);">+ * compare directly. */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (not (l1_dl.payload.data_ind.payload[0] == int2oct(power_level, 1))) {</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail, "Power level in L1 header does not match the signaled (RSL) power level.");</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Signal a new power level via RSL for the next turn. */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (power_level < 31) {</span><br><span style="color: hsl(120, 100%, 40%);">+ power_level := power_level + 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ ms_power.power_level := power_level;</span><br><span style="color: hsl(120, 100%, 40%);">+ rsl := valueof(ts_RSL_MS_PWR_CTRL(g_chan_nr, ms_power));</span><br><span style="color: hsl(120, 100%, 40%);">+ RSL.send(rsl);</span><br><span style="color: hsl(120, 100%, 40%);">+ repeat;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Ignore all other blocks */</span><br><span style="color: hsl(120, 100%, 40%);">+ [] L1CTL.receive { repeat; }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_rsl_chan_deact();</span><br><span style="color: hsl(120, 100%, 40%);">+ f_L1CTL_DM_REL_REQ(L1CTL, g_chan_nr);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(pass);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_rsl_ms_pwr_ctrl() runs on test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ var ConnHdlr vc_conn;</span><br><span style="color: hsl(120, 100%, 40%);">+ var ConnHdlrPars pars;</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init(testcasename());</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ for (var integer tn := 1; tn <= 4; tn := tn+1) {</span><br><span style="color: hsl(120, 100%, 40%);">+ pars := valueof(t_Pars(t_RslChanNr_Bm(tn), ts_RSL_ChanMode_SIGN));</span><br><span style="color: hsl(120, 100%, 40%);">+ vc_conn := f_start_handler(refers(f_tc_rsl_ms_pwr_ctrl), pars);</span><br><span style="color: hsl(120, 100%, 40%);">+ vc_conn.done;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ Misc_Helpers.f_shutdown(__BFILE__, __LINE__);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span> </span><br><span> /* Test if a channel without valid uplink bursts generates RSL CONN FAIL IND (TS 48.058 4.10) */</span><br><span> private function f_TC_conn_fail_crit(charstring id) runs on ConnHdlr {</span><br><span>@@ -4128,7 +4198,6 @@</span><br><span> * check DEACTIVATE SACCH</span><br><span> ** unsupported algorithm</span><br><span> * handover detection</span><br><span style="color: hsl(0, 100%, 40%);">-* MS Power Control</span><br><span> * BS Power Control</span><br><span> * Physical Context</span><br><span> * CCCH Load Indication for RACH</span><br><span>@@ -4164,6 +4233,7 @@</span><br><span> execute( TC_meas_res_sign_sdcch4() );</span><br><span> execute( TC_meas_res_sign_sdcch8() );</span><br><span> execute( TC_meas_res_sign_tchh_toa256() );</span><br><span style="color: hsl(120, 100%, 40%);">+ execute( TC_rsl_ms_pwr_ctrl() );</span><br><span> execute( TC_conn_fail_crit() );</span><br><span> execute( TC_paging_imsi_80percent() );</span><br><span> execute( TC_paging_tmsi_80percent() );</span><br><span>diff --git a/bts/expected-results.xml b/bts/expected-results.xml</span><br><span>index 73de1fb..bad4d6f 100644</span><br><span>--- a/bts/expected-results.xml</span><br><span>+++ b/bts/expected-results.xml</span><br><span>@@ -17,6 +17,7 @@</span><br><span> <testcase classname='BTS_Tests' name='TC_meas_res_sign_sdcch4' time='MASKED'/></span><br><span> <testcase classname='BTS_Tests' name='TC_meas_res_sign_sdcch8' time='MASKED'/></span><br><span> <testcase classname='BTS_Tests' name='TC_meas_res_sign_tchh_toa256' time='MASKED'/></span><br><span style="color: hsl(120, 100%, 40%);">+ <testcase classname='BTS_Tests' name='TC_rsl_ms_pwr_ctrl' time='MASKED'/></span><br><span> <testcase classname='BTS_Tests' name='TC_conn_fail_crit' time='MASKED'/></span><br><span> <testcase classname='BTS_Tests' name='TC_paging_imsi_80percent' time='MASKED'/></span><br><span> <testcase classname='BTS_Tests' name='TC_paging_tmsi_80percent' time='MASKED'/></span><br><span>diff --git a/library/RSL_Types.ttcn b/library/RSL_Types.ttcn</span><br><span>index cd4ba58..3b1a311 100644</span><br><span>--- a/library/RSL_Types.ttcn</span><br><span>+++ b/library/RSL_Types.ttcn</span><br><span>@@ -1318,6 +1318,18 @@</span><br><span> }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ /* 8.4.15: BTS <- BSC */</span><br><span style="color: hsl(120, 100%, 40%);">+ template (value) RSL_Message ts_RSL_MS_PWR_CTRL(template (value) RslChannelNr chan_nr,</span><br><span style="color: hsl(120, 100%, 40%);">+ template (value) RSL_IE_MS_Power ms_power) := {</span><br><span style="color: hsl(120, 100%, 40%);">+ msg_disc := ts_RSL_MsgDisc(RSL_MDISC_DCHAN, false),</span><br><span style="color: hsl(120, 100%, 40%);">+ msg_type := RSL_MT_MS_POWER_CONTROL,</span><br><span style="color: hsl(120, 100%, 40%);">+ ies := {</span><br><span style="color: hsl(120, 100%, 40%);">+ t_RSL_IE(RSL_IE_CHAN_NR, RSL_IE_Body:{chan_nr := chan_nr}),</span><br><span style="color: hsl(120, 100%, 40%);">+ t_RSL_IE(RSL_IE_MS_POWER, RSL_IE_Body:{ms_power := ms_power})</span><br><span style="color: hsl(120, 100%, 40%);">+ /* One optional IE: MS POWER PARAMETERS */</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* 8.4.19 BTS -> BSC */</span><br><span> template (value) RSL_Message ts_RSL_RF_CHAN_REL_ACK(template (value) RslChannelNr chan_nr) :=</span><br><span> ts_RSL_MsgDiscType(ts_RSL_MsgDisc(RSL_MDISC_DCHAN, false),</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/12391">change 12391</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12391"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I82b04a3bf94d355175f7f6ff3fdc43672e8080a2 </div>
<div style="display:none"> Gerrit-Change-Number: 12391 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>