<p>Max <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/12271">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Max: Looks good to me, approved
  Pau Espin Pedrol: Looks good to me, but someone else must approve
  Stefan Sperling: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">tests/gsm0808: use new msgb comparison API<br><br>Since I3bc95f2f5ab6e3f4b502647fb3e0aaaf1f7c4cf5, we have some<br>helpers to compare certain msgb layer to a given buffer. Let's<br>change 'VERIFY' macro to use msgb_eq_l3_data_print().<br><br>Change-Id: Ib6be778236eff8f2153f3113f9379ecfbec9052b<br>---<br>M tests/gsm0808/gsm0808_test.c<br>1 file changed, 4 insertions(+), 12 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/tests/gsm0808/gsm0808_test.c b/tests/gsm0808/gsm0808_test.c</span><br><span>index 46169ea..ebdfc29 100644</span><br><span>--- a/tests/gsm0808/gsm0808_test.c</span><br><span>+++ b/tests/gsm0808/gsm0808_test.c</span><br><span>@@ -39,18 +39,10 @@</span><br><span>            OSMO_ASSERT(rc_enc == msg->len); \</span><br><span>        } while(0)</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-#define VERIFY(msg, data, len)                                            \</span><br><span style="color: hsl(0, 100%, 40%);">-       if (msgb_l3len(msg) != len) {                                   \</span><br><span style="color: hsl(0, 100%, 40%);">-               printf("%s:%d Length don't match: %d vs. %d. %s\n",       \</span><br><span style="color: hsl(0, 100%, 40%);">-                       __func__, __LINE__, msgb_l3len(msg), (int) len, \</span><br><span style="color: hsl(0, 100%, 40%);">-                       osmo_hexdump(msg->l3h, msgb_l3len(msg)));    \</span><br><span style="color: hsl(0, 100%, 40%);">-               abort();                                                \</span><br><span style="color: hsl(0, 100%, 40%);">-       } else if (memcmp(msg->l3h, data, len) != 0) {                       \</span><br><span style="color: hsl(0, 100%, 40%);">-               printf("%s:%d didn't match: got: %s\n",                   \</span><br><span style="color: hsl(0, 100%, 40%);">-                       __func__, __LINE__,                             \</span><br><span style="color: hsl(0, 100%, 40%);">-                       osmo_hexdump(msg->l3h, msgb_l3len(msg)));    \</span><br><span style="color: hsl(0, 100%, 40%);">-               abort();                                                \</span><br><span style="color: hsl(0, 100%, 40%);">-       }</span><br><span style="color: hsl(120, 100%, 40%);">+#define VERIFY(msg, data, data_len) do { \</span><br><span style="color: hsl(120, 100%, 40%);">+         if (!msgb_eq_l3_data_print(msg, data, data_len)) \</span><br><span style="color: hsl(120, 100%, 40%);">+                    abort(); \</span><br><span style="color: hsl(120, 100%, 40%);">+    } while(0)</span><br><span> </span><br><span> /* Setup a fake codec list for testing */</span><br><span> static void setup_codec_list(struct gsm0808_speech_codec_list *scl)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/12271">change 12271</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12271"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Ib6be778236eff8f2153f3113f9379ecfbec9052b </div>
<div style="display:none"> Gerrit-Change-Number: 12271 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: Max <msuraev@sysmocom.de> </div>
<div style="display:none"> Gerrit-Assignee: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Max <msuraev@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Stefan Sperling <stsp@stsp.name> </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-CC: fixeria <axilirator@gmail.com> </div>