<p style="white-space: pre-wrap; word-wrap: break-word;">Please also update osmo-gsm-manuals.</p><p><a href="https://gerrit.osmocom.org/12409">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/12409/2/include/osmocom/gsm/gsup.h">File include/osmocom/gsm/gsup.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/12409/2/include/osmocom/gsm/gsup.h@277">Patch Set #2, Line 277:</a> <code style="font-family:monospace,monospace">osmo_gsup_imei_result</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">You are basically introducing three types:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">  OSMO_GSUP_MSGT_CHECK_IMEI_REQUEST,<br>  OSMO_GSUP_MSGT_CHECK_IMEI_ERROR (NACK),<br>  OSMO_GSUP_MSGT_CHECK_IMEI_RESULT (ACK),</pre><p style="white-space: pre-wrap; word-wrap: break-word;">so I don't think we need this IE.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Probably, I am not getting the meaning of ACK/NACK?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/12409">change 12409</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12409"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I085819df0ea7f3bfeb0cabebb5fd1942a23c6155 </div>
<div style="display:none"> Gerrit-Change-Number: 12409 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 21 Dec 2018 11:52:32 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>