<p>Neels Hofmeyr has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/12406">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">comments: describe some lchan details<br><br>(requested by pespin)<br><br>Change-Id: I04ec4ce1fd2b7b110bb496186aae39ecfbbc3628<br>---<br>M include/osmocom/bsc/gsm_data.h<br>M src/osmo-bsc/lchan_fsm.c<br>2 files changed, 4 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/06/12406/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h</span><br><span>index 2090142..9f7ce8d 100644</span><br><span>--- a/include/osmocom/bsc/gsm_data.h</span><br><span>+++ b/include/osmocom/bsc/gsm_data.h</span><br><span>@@ -509,10 +509,13 @@</span><br><span>  /* This always is for a specific lchan, so its lchan->type indicates full or half rate.</span><br><span>    * When a dyn TS was selected, the lchan->type has been set to the desired rate. */</span><br><span>       enum gsm48_chan_mode chan_mode;</span><br><span style="color: hsl(120, 100%, 40%);">+       /* AMR config */</span><br><span>     uint16_t s15_s0;</span><br><span>     bool requires_voice_stream;</span><br><span>  bool wait_before_switching_rtp; /*< true = requires LCHAN_EV_READY_TO_SWITCH_RTP */</span><br><span>       uint16_t msc_assigned_cic;</span><br><span style="color: hsl(120, 100%, 40%);">+    /* During intra-BSC handover, we keep the MGW endpoint intact and just re-route to the new lchan. This</span><br><span style="color: hsl(120, 100%, 40%);">+         * activate_info is for the new lchan, the re_use_mgw_endpoint_from_lchan points at the old lchan. */</span><br><span>        struct gsm_lchan *re_use_mgw_endpoint_from_lchan;</span><br><span> };</span><br><span> </span><br><span>diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c</span><br><span>index fc1bcbf..f344cf9 100644</span><br><span>--- a/src/osmo-bsc/lchan_fsm.c</span><br><span>+++ b/src/osmo-bsc/lchan_fsm.c</span><br><span>@@ -533,7 +533,7 @@</span><br><span>               lchan->rqd_ta = old_lchan->rqd_ta;</span><br><span>     } else {</span><br><span>             lchan->ms_power = ms_pwr_ctl_lvl(bts->band, bts->ms_max_power);</span><br><span style="color: hsl(0, 100%, 40%);">-                /* From lchan_reset():</span><br><span style="color: hsl(120, 100%, 40%);">+                /* Upon last entering the UNUSED state, from lchan_reset():</span><br><span>           * - bs_power is still zero, 0dB reduction, output power = Pn.</span><br><span>                * - TA is still zero, to be determined by RACH. */</span><br><span>  }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/12406">change 12406</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12406"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I04ec4ce1fd2b7b110bb496186aae39ecfbbc3628 </div>
<div style="display:none"> Gerrit-Change-Number: 12406 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>