<p>Max has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/12369">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">LCLS: don't send invalid status in HO messages<br><br>Change-Id: Ib2958a8613627c4e54c004ffa3578c300ed0360b<br>---<br>M include/osmocom/gsm/gsm0808.h<br>M src/gsm/gsm0808.c<br>2 files changed, 2 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/69/12369/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/gsm/gsm0808.h b/include/osmocom/gsm/gsm0808.h</span><br><span>index 79d89e5..ccecda4 100644</span><br><span>--- a/include/osmocom/gsm/gsm0808.h</span><br><span>+++ b/include/osmocom/gsm/gsm0808.h</span><br><span>@@ -157,7 +157,6 @@</span><br><span>  bool chosen_channel_present;</span><br><span>         uint8_t chosen_channel;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-     bool lcls_bss_status_present;</span><br><span>        enum gsm0808_lcls_status lcls_bss_status;</span><br><span> </span><br><span>        /* more items are defined in the spec and may be added later */</span><br><span>@@ -194,7 +193,6 @@</span><br><span>        bool speech_codec_chosen_present;</span><br><span>    struct gsm0808_speech_codec speech_codec_chosen;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-    bool lcls_bss_status_present;</span><br><span>        enum gsm0808_lcls_status lcls_bss_status;</span><br><span> </span><br><span>        /* more items are defined in the spec and may be added later */</span><br><span>diff --git a/src/gsm/gsm0808.c b/src/gsm/gsm0808.c</span><br><span>index 69da57d..192c0be 100644</span><br><span>--- a/src/gsm/gsm0808.c</span><br><span>+++ b/src/gsm/gsm0808.c</span><br><span>@@ -898,7 +898,7 @@</span><br><span>               msgb_tv_put(msg, GSM0808_IE_CHOSEN_ENCR_ALG, params->chosen_encr_alg);</span><br><span> </span><br><span>        /* LCLS-BSS-Status 3.2.2.119 */</span><br><span style="color: hsl(0, 100%, 40%);">- if (params->lcls_bss_status_present)</span><br><span style="color: hsl(120, 100%, 40%);">+       if (params->lcls_bss_status != GSM0808_LCLS_STS_NA)</span><br><span>               msgb_tv_put(msg, GSM0808_IE_LCLS_BSS_STATUS, params->lcls_bss_status);</span><br><span> </span><br><span>        /* prepend header with final length */</span><br><span>@@ -974,7 +974,7 @@</span><br><span>                 gsm0808_enc_speech_codec(msg, &params->speech_codec_chosen);</span><br><span> </span><br><span>      /* LCLS-BSS-Status 3.2.2.119 */</span><br><span style="color: hsl(0, 100%, 40%);">- if (params->lcls_bss_status_present)</span><br><span style="color: hsl(120, 100%, 40%);">+       if (params->lcls_bss_status != GSM0808_LCLS_STS_NA)</span><br><span>               msgb_tv_put(msg, GSM0808_IE_LCLS_BSS_STATUS, params->lcls_bss_status);</span><br><span> </span><br><span>        /* prepend header with final length */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/12369">change 12369</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12369"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ib2958a8613627c4e54c004ffa3578c300ed0360b </div>
<div style="display:none"> Gerrit-Change-Number: 12369 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Max <msuraev@sysmocom.de> </div>