<p style="white-space: pre-wrap; word-wrap: break-word;">I see no good reason for this change. You are breaking the ABI and basically not using the extra field "type" of the new struct.</p><p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p><a href="https://gerrit.osmocom.org/12352">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/12352/2/include/osmocom/sgsn/gtphub.h">File include/osmocom/sgsn/gtphub.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/12352/2/include/osmocom/sgsn/gtphub.h@377">Patch Set #2, Line 377:</a> <code style="font-family:monospace,monospace">     struct osmo_gsn_address addr;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">You are breaking ABI here, length of struct is different.</p><p style="white-space: pre-wrap; word-wrap: break-word;">include/osmocom/gsm/gsm23003.h<br>59:struct osmo_gsn_address {<br>60-     enum osmo_gsn_addr_type type;<br>61-     uint8_t length;<br>62-     uint8_t addr[16];<br>63-};</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/12352">change 12352</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12352"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I6ed32a91483dc608c47df77869033a6e891e9e6a </div>
<div style="display:none"> Gerrit-Change-Number: 12352 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Max <msuraev@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 18 Dec 2018 17:58:06 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>