<p>Neels Hofmeyr <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/12265">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Pau Espin Pedrol: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">check_rtp: on IP:port errors, log the IP and port<br><br>Half of those are obviously zero, but I'd rather print the raw data instead of<br>adding string constants, even if the condition must always lead to 0.0.0.0:0.<br><br>Rationale: I had osmo-mgw listen on 0.0.0.0 and got the error message<br>  DRTP ERROR endpoint:0x1 destination IP-address is invalid<br>which didn't convey that 0.0.0.0 is regarded as invalid.<br><br>Change-Id: I9e98d464a27038904797c5c10735a98ef5b7b9c3<br>---<br>M src/libosmo-mgcp/mgcp_network.c<br>1 file changed, 6 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libosmo-mgcp/mgcp_network.c b/src/libosmo-mgcp/mgcp_network.c</span><br><span>index de34cc6..7af8e71 100644</span><br><span>--- a/src/libosmo-mgcp/mgcp_network.c</span><br><span>+++ b/src/libosmo-mgcp/mgcp_network.c</span><br><span>@@ -945,22 +945,22 @@</span><br><span>         * and IP-address for outgoing data. */</span><br><span>      if (strcmp(inet_ntoa(conn->end.addr), "0.0.0.0") == 0 && conn->end.rtp_port == 0) {</span><br><span>          LOGP(DRTP, LOGL_DEBUG,</span><br><span style="color: hsl(0, 100%, 40%);">-               "endpoint:0x%x destination IP-address and rtp port is (not yet) known\n",</span><br><span style="color: hsl(0, 100%, 40%);">-                     ENDPOINT_NUMBER(endp));</span><br><span style="color: hsl(120, 100%, 40%);">+               "endpoint:0x%x destination IP-address and rtp port is (not yet) known (%s:%u)\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                   ENDPOINT_NUMBER(endp), inet_ntoa(conn->end.addr), conn->end.rtp_port);</span><br><span>            return -1;</span><br><span>   }</span><br><span> </span><br><span>        if (strcmp(inet_ntoa(conn->end.addr), "0.0.0.0") == 0) {</span><br><span>                LOGP(DRTP, LOGL_ERROR,</span><br><span style="color: hsl(0, 100%, 40%);">-               "endpoint:0x%x destination IP-address is invalid\n",</span><br><span style="color: hsl(0, 100%, 40%);">-                  ENDPOINT_NUMBER(endp));</span><br><span style="color: hsl(120, 100%, 40%);">+               "endpoint:0x%x destination IP-address is invalid (%s:%u)\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                ENDPOINT_NUMBER(endp), inet_ntoa(conn->end.addr), conn->end.rtp_port);</span><br><span>            return -1;</span><br><span>   }</span><br><span> </span><br><span>        if (conn->end.rtp_port == 0) {</span><br><span>            LOGP(DRTP, LOGL_ERROR,</span><br><span style="color: hsl(0, 100%, 40%);">-               "endpoint:0x%x destination rtp port is invalid\n",</span><br><span style="color: hsl(0, 100%, 40%);">-                    ENDPOINT_NUMBER(endp));</span><br><span style="color: hsl(120, 100%, 40%);">+               "endpoint:0x%x destination rtp port is invalid (%s:%u)\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                  ENDPOINT_NUMBER(endp), inet_ntoa(conn->end.addr), conn->end.rtp_port);</span><br><span>            return -1;</span><br><span>   }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/12265">change 12265</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12265"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-mgw </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I9e98d464a27038904797c5c10735a98ef5b7b9c3 </div>
<div style="display:none"> Gerrit-Change-Number: 12265 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>