<p>Vadim Yanitskiy has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/12323">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">trx_toolkit/burst_send.py: fix: use proper argparse group<br><br>Found using Flake8, F841 "local variable 'pf_group' is assigned<br>to but never used". The filtering related options should be<br>defined in 'pf_group' group, not in 'cnt_group'.<br><br>Change-Id: I15d17c134cbbbd54d761113a56c1f83910ab6407<br>---<br>M src/target/trx_toolkit/burst_send.py<br>1 file changed, 3 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/23/12323/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/target/trx_toolkit/burst_send.py b/src/target/trx_toolkit/burst_send.py</span><br><span>index 0cf63bb..7186863 100755</span><br><span>--- a/src/target/trx_toolkit/burst_send.py</span><br><span>+++ b/src/target/trx_toolkit/burst_send.py</span><br><span>@@ -134,13 +134,13 @@</span><br><span>                     help = "Stop after sending N messages")</span><br><span> </span><br><span>                pf_group = parser.add_argument_group("Filtering (optional)")</span><br><span style="color: hsl(0, 100%, 40%);">-          cnt_group.add_argument("--timeslot", metavar = "TN",</span><br><span style="color: hsl(120, 100%, 40%);">+              pf_group.add_argument("--timeslot", metavar = "TN",</span><br><span>                      dest = "pf_tn", type = int, choices = range(0, 8),</span><br><span>                         help = "TDMA timeslot number (equal TN)")</span><br><span style="color: hsl(0, 100%, 40%);">-             cnt_group.add_argument("--frame-num-lt", metavar = "FN",</span><br><span style="color: hsl(120, 100%, 40%);">+          pf_group.add_argument("--frame-num-lt", metavar = "FN",</span><br><span>                  dest = "pf_fn_lt", type = int,</span><br><span>                     help = "TDMA frame number (lower than FN)")</span><br><span style="color: hsl(0, 100%, 40%);">-           cnt_group.add_argument("--frame-num-gt", metavar = "FN",</span><br><span style="color: hsl(120, 100%, 40%);">+          pf_group.add_argument("--frame-num-gt", metavar = "FN",</span><br><span>                  dest = "pf_fn_gt", type = int,</span><br><span>                     help = "TDMA frame number (greater than FN)")</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/12323">change 12323</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12323"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmocom-bb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I15d17c134cbbbd54d761113a56c1f83910ab6407 </div>
<div style="display:none"> Gerrit-Change-Number: 12323 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>