<p>Vadim Yanitskiy has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/12324">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">trx_toolkit/burst_send.py: exit if DATA dump parsing failed<br><br>False is not iterable, so we should properly handle the case<br>when parsing of the whole DATA dump was failed (e.g. due to<br>incorrect offset specified).<br><br>Change-Id: I5443efb39bb9d3377290ce7ec5e34016cae0edb2<br>---<br>M src/target/trx_toolkit/burst_send.py<br>1 file changed, 2 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/24/12324/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/target/trx_toolkit/burst_send.py b/src/target/trx_toolkit/burst_send.py</span><br><span>index 7186863..6c19e6f 100755</span><br><span>--- a/src/target/trx_toolkit/burst_send.py</span><br><span>+++ b/src/target/trx_toolkit/burst_send.py</span><br><span>@@ -63,7 +63,8 @@</span><br><span>                 messages = self.ddf.parse_all(</span><br><span>                       skip = self.argv.cnt_skip, count = self.argv.cnt_count)</span><br><span>              if messages is False:</span><br><span style="color: hsl(0, 100%, 40%);">-                   pass # FIXME!!!</span><br><span style="color: hsl(120, 100%, 40%);">+                       log.error("Parsing failed, nothing to send")</span><br><span style="color: hsl(120, 100%, 40%);">+                        sys.exit(1)</span><br><span> </span><br><span>              for msg in messages:</span><br><span>                         # Pass filter</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/12324">change 12324</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12324"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmocom-bb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I5443efb39bb9d3377290ce7ec5e34016cae0edb2 </div>
<div style="display:none"> Gerrit-Change-Number: 12324 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>