<p>Patch set 4:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p><a href="https://gerrit.osmocom.org/12245">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/12245/4/tests/Transceiver52M/Makefile.am">File tests/Transceiver52M/Makefile.am:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/12245/4/tests/Transceiver52M/Makefile.am@25">Patch Set #4, Line 25:</a> <code style="font-family:monospace,monospace">   $(top_builddir)/Transceiver52M/device/lms/.libs/LMSDevice.o \</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Use $(builddir)/device/lms/libdevice.la here</p><p style="white-space: pre-wrap; word-wrap: break-word;">You should add $(LMS_CFLAGS) to LMSDeviceTest_CPPFLAGS, see Transceiver52/Makefile.am towards the end of file (DEVICE_LMS).</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/12245">change 12245</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12245"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-trx </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ib9aaa066a01bf9de3f78234d7ada884d6f28c852 </div>
<div style="display:none"> Gerrit-Change-Number: 12245 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 12 Dec 2018 17:07:21 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>