<p><a href="https://gerrit.osmocom.org/10185">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/10185/6/tests/gsm0408/gsm0408_test.c">File tests/gsm0408/gsm0408_test.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/10185/6/tests/gsm0408/gsm0408_test.c@33">Patch Set #6, Line 33:</a> <code style="font-family:monospace,monospace">#include <osmocom/core/logging.h></code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">not needed</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Right, dropped.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/10185/6/tests/gsm0408/gsm0408_test.c@116">Patch Set #6, Line 116:</a> <code style="font-family:monospace,monospace">                      printf(" is:     %s\n", osmo_hexdump(msg->data, msg->len));</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">maybe a bit eager find-replace? I think this stderr output should also go to stdout, yes, but techni […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Oh, I understood that you wanted all fprintf() in this file to be printf() for some reason. Reverted in next patch set.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/10185/6/tests/gsm0408/gsm0408_test.c@914">Patch Set #6, Line 914:</a> <code style="font-family:monospace,monospace">};</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">drop this too</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/10185">change 10185</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/10185"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ia220764fba451be5e975ae7c5eefb1a25ac2bf2c </div>
<div style="display:none"> Gerrit-Change-Number: 10185 </div>
<div style="display:none"> Gerrit-PatchSet: 6 </div>
<div style="display:none"> Gerrit-Owner: Stefan Sperling <stsp@stsp.name> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Max <msuraev@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Stefan Sperling <stsp@stsp.name> </div>
<div style="display:none"> Gerrit-CC: Holger Freyther <holger@freyther.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 11 Dec 2018 13:17:21 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>