<p>osmith has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/12244">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">tests: rename convolve_test -> ConvolveTest<br><br>Make the test's name consistent with all other tests in this<br>repository. This makes adding new tests to<br>tests/Transceiver52M/Makefile.am less awkward (follow-up commit),<br>because it is clear now which casing should be used.<br><br>Change-Id: I4ca533ca8c5e19b6dbe7b0aba672ee14cf5c3bd1<br>---<br>M .gitignore<br>R tests/Transceiver52M/ConvolveTest.c<br>R tests/Transceiver52M/ConvolveTest.ok<br>M tests/Transceiver52M/Makefile.am<br>M tests/testsuite.at<br>5 files changed, 12 insertions(+), 12 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/44/12244/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/.gitignore b/.gitignore</span><br><span>index ad4c4e3..92fc723 100644</span><br><span>--- a/.gitignore</span><br><span>+++ b/.gitignore</span><br><span>@@ -17,7 +17,7 @@</span><br><span> tests/CommonLibs/URLEncodeTest</span><br><span> tests/CommonLibs/VectorTest</span><br><span> tests/CommonLibs/PRBSTest</span><br><span style="color: hsl(0, 100%, 40%);">-tests/Transceiver52M/convolve_test</span><br><span style="color: hsl(120, 100%, 40%);">+tests/Transceiver52M/ConvolveTest</span><br><span> </span><br><span> # automake/autoconf</span><br><span> *.in</span><br><span>diff --git a/tests/Transceiver52M/convolve_test.c b/tests/Transceiver52M/ConvolveTest.c</span><br><span>similarity index 100%</span><br><span>rename from tests/Transceiver52M/convolve_test.c</span><br><span>rename to tests/Transceiver52M/ConvolveTest.c</span><br><span>diff --git a/tests/Transceiver52M/convolve_test.ok b/tests/Transceiver52M/ConvolveTest.ok</span><br><span>similarity index 100%</span><br><span>rename from tests/Transceiver52M/convolve_test.ok</span><br><span>rename to tests/Transceiver52M/ConvolveTest.ok</span><br><span>diff --git a/tests/Transceiver52M/Makefile.am b/tests/Transceiver52M/Makefile.am</span><br><span>index 06db5b0..a9d3992 100644</span><br><span>--- a/tests/Transceiver52M/Makefile.am</span><br><span>+++ b/tests/Transceiver52M/Makefile.am</span><br><span>@@ -2,17 +2,17 @@</span><br><span> </span><br><span> AM_CFLAGS = -Wall -I$(top_srcdir)/Transceiver52M -I$(top_srcdir)/Transceiver52M/arch/common $(STD_DEFINES_AND_INCLUDES) -g</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-EXTRA_DIST = convolve_test.ok</span><br><span style="color: hsl(120, 100%, 40%);">+EXTRA_DIST = ConvolveTest.ok</span><br><span> </span><br><span> noinst_PROGRAMS = \</span><br><span style="color: hsl(0, 100%, 40%);">-  convolve_test</span><br><span style="color: hsl(120, 100%, 40%);">+ ConvolveTest</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-convolve_test_SOURCES = convolve_test.c</span><br><span style="color: hsl(0, 100%, 40%);">-convolve_test_CFLAGS = $(AM_CFLAGS)</span><br><span style="color: hsl(0, 100%, 40%);">-convolve_test_LDADD = $(COMMON_LA) $(ARCH_LA)</span><br><span style="color: hsl(120, 100%, 40%);">+ConvolveTest_SOURCES = ConvolveTest.c</span><br><span style="color: hsl(120, 100%, 40%);">+ConvolveTest_CFLAGS = $(AM_CFLAGS)</span><br><span style="color: hsl(120, 100%, 40%);">+ConvolveTest_LDADD = $(COMMON_LA) $(ARCH_LA)</span><br><span> if HAVE_SSE3</span><br><span style="color: hsl(0, 100%, 40%);">-convolve_test_CFLAGS += $(SIMD_FLAGS)</span><br><span style="color: hsl(120, 100%, 40%);">+ConvolveTest_CFLAGS += $(SIMD_FLAGS)</span><br><span> endif</span><br><span> if HAVE_SSE4_1</span><br><span style="color: hsl(0, 100%, 40%);">-convolve_test_CFLAGS += $(SIMD_FLAGS)</span><br><span style="color: hsl(120, 100%, 40%);">+ConvolveTest_CFLAGS += $(SIMD_FLAGS)</span><br><span> endif</span><br><span>diff --git a/tests/testsuite.at b/tests/testsuite.at</span><br><span>index f84225e..1968481 100644</span><br><span>--- a/tests/testsuite.at</span><br><span>+++ b/tests/testsuite.at</span><br><span>@@ -44,10 +44,10 @@</span><br><span> AT_CHECK([$abs_top_builddir/tests/CommonLibs/VectorTest], [], [expout], [])</span><br><span> AT_CLEANUP</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-AT_SETUP([convolve_test])</span><br><span style="color: hsl(0, 100%, 40%);">-AT_KEYWORDS([convolve_test])</span><br><span style="color: hsl(120, 100%, 40%);">+AT_SETUP([ConvolveTest])</span><br><span style="color: hsl(120, 100%, 40%);">+AT_KEYWORDS([ConvolveTest])</span><br><span> # Different results for i686, x86_64 and ARM. see  OS#2826, OS#2828, and https://lists.osmocom.org/pipermail/openbsc/2018-January/011655.html</span><br><span> AT_SKIP_IF(true)</span><br><span style="color: hsl(0, 100%, 40%);">-cat $abs_srcdir/Transceiver52M/convolve_test.ok > expout</span><br><span style="color: hsl(0, 100%, 40%);">-AT_CHECK([$abs_top_builddir/tests/Transceiver52M/convolve_test], [], [expout], [])</span><br><span style="color: hsl(120, 100%, 40%);">+cat $abs_srcdir/Transceiver52M/ConvolveTest.ok > expout</span><br><span style="color: hsl(120, 100%, 40%);">+AT_CHECK([$abs_top_builddir/tests/Transceiver52M/ConvolveTest], [], [expout], [])</span><br><span> AT_CLEANUP</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/12244">change 12244</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12244"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-trx </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I4ca533ca8c5e19b6dbe7b0aba672ee14cf5c3bd1 </div>
<div style="display:none"> Gerrit-Change-Number: 12244 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: osmith <osmith@sysmocom.de> </div>