<p><a href="https://gerrit.osmocom.org/12226">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/12226/2/tests/sgsn/sgsn_test.c">File tests/sgsn/sgsn_test.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/12226/2/tests/sgsn/sgsn_test.c@1343">Patch Set #2, Line 1343:</a> <code style="font-family:monospace,monospace">       size_t old = sgsn_acl_count(cfg), new;</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">> while having another variable after calling the function separate by a comma […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I'd like you to clean the line, I think it's pretty obvious. Either:<br>"<br>size_t old_count, new_count;<br>int rc;</p><p style="white-space: pre-wrap; word-wrap: break-word;">old_count = sgsn_acl_count(cfg);<br>"</p><p style="white-space: pre-wrap; word-wrap: break-word;">or<br>"<br>int rc;<br>size_t old_count;<br>size_t new_count = sgsn_acl_count(cfg);<br>"</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/12226">change 12226</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12226"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ia782f12b49bed6428bc9b9f513237e4e6aefdec9 </div>
<div style="display:none"> Gerrit-Change-Number: 12226 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Max <msuraev@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Max <msuraev@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: Stefan Sperling <stsp@stsp.name> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 11 Dec 2018 11:51:57 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>