<p><a href="https://gerrit.osmocom.org/12224">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/12224/2/include/osmocom/sgsn/gprs_sgsn.h">File include/osmocom/sgsn/gprs_sgsn.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/12224/2/include/osmocom/sgsn/gprs_sgsn.h@417">Patch Set #2, Line 417:</a> <code style="font-family:monospace,monospace">   char imsi[GSM23003_IMSI_MAX_DIGITS + 2];</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Comes from openbsc d3fa84dbba3b67cdbe2d8c789b2833b5ddf42068</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">And in there we use +1, which makes more sense:</p><p style="white-space: pre-wrap; word-wrap: break-word;">openbsc/src/osmo-bsc_nat/bsc_ussd.c<br>405:    if (strlen(con->filter_state.imsi) > GSM23003_IMSI_MAX_DIGITS)</p><p style="white-space: pre-wrap; word-wrap: break-word;">openbsc/src/libmsc/ctrl_commands.c<br>67:     else if (strlen(imsi) > GSM23003_IMSI_MAX_DIGITS)</p><p style="white-space: pre-wrap; word-wrap: break-word;">openbsc/include/openbsc/bsc_subscriber.h<br>16:     char imsi[GSM23003_IMSI_MAX_DIGITS+1];</p><p style="white-space: pre-wrap; word-wrap: break-word;">openbsc/include/openbsc/gsm_subscriber.h<br>47:     char imsi[GSM23003_IMSI_MAX_DIGITS+1];</p><p style="white-space: pre-wrap; word-wrap: break-word;">openbsc/include/openbsc/ipaccess.h<br>15:     char    imsi[GSM23003_IMSI_MAX_DIGITS+1];</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/12224">change 12224</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12224"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I138aea409aab0c748c75546e628797fc7498bf40 </div>
<div style="display:none"> Gerrit-Change-Number: 12224 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Max <msuraev@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Max <msuraev@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 10 Dec 2018 17:43:33 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>