<p>Max has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/12225">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ACL: move allocation check forward in sgsn_acl_add()<br><br>There's no point in looking up existing ACL if we could not add new<br>entry anyway due to memory allocation issues. This optimization will<br>also simplify integrating IMSI sanitizer in follow-up patches.<br><br>Change-Id: I5906304fd3c96002ca1fdc649609e5a4d9ca299b<br>---<br>M src/gprs/sgsn_auth.c<br>1 file changed, 3 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/25/12225/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gprs/sgsn_auth.c b/src/gprs/sgsn_auth.c</span><br><span>index 0a39da4..5a62476 100644</span><br><span>--- a/src/gprs/sgsn_auth.c</span><br><span>+++ b/src/gprs/sgsn_auth.c</span><br><span>@@ -60,14 +60,13 @@</span><br><span> </span><br><span> int sgsn_acl_add(const char *imsi, struct sgsn_config *cfg)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-       struct imsi_acl_entry *acl;</span><br><span style="color: hsl(120, 100%, 40%);">+   struct imsi_acl_entry *acl = talloc_zero(NULL, struct imsi_acl_entry);</span><br><span style="color: hsl(120, 100%, 40%);">+        if (!acl)</span><br><span style="color: hsl(120, 100%, 40%);">+             return -ENOMEM;</span><br><span> </span><br><span>  if (sgsn_acl_lookup(imsi, cfg))</span><br><span>              return -EEXIST;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-     acl = talloc_zero(NULL, struct imsi_acl_entry);</span><br><span style="color: hsl(0, 100%, 40%);">- if (!acl)</span><br><span style="color: hsl(0, 100%, 40%);">-               return -ENOMEM;</span><br><span>      osmo_strlcpy(acl->imsi, imsi, sizeof(acl->imsi));</span><br><span> </span><br><span>  llist_add(&acl->list, &cfg->imsi_acl);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/12225">change 12225</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12225"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I5906304fd3c96002ca1fdc649609e5a4d9ca299b </div>
<div style="display:none"> Gerrit-Change-Number: 12225 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Max <msuraev@sysmocom.de> </div>