<p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p><a href="https://gerrit.osmocom.org/12125">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/12125/2/Transceiver52M/device/lms/LMSDevice.cpp">File Transceiver52M/device/lms/LMSDevice.cpp:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/12125/2/Transceiver52M/device/lms/LMSDevice.cpp@538">Patch Set #2, Line 538:</a> <code style="font-family:monospace,monospace">           update_stream_stats(i, underrun, overrun);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">the under/overrun stuff now moved to above rc != len check, are your sure that is correct?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/12125/2/Transceiver52M/device/lms/LMSDevice.cpp@544">Patch Set #2, Line 544:</a> <code style="font-family:monospace,monospace">               //if (timestamp != (TIMESTAMP)rx_metadata.timestamp)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/12125">change 12125</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12125"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-trx </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I7f450aa79f6285d14826c40ecfdd9490d00509ef </div>
<div style="display:none"> Gerrit-Change-Number: 12125 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 06 Dec 2018 18:49:41 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>