<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/12144">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gsm_29_118: add missing extern for struct value_string decl.<br><br>The value string arrays in the header file (gsm_29_118.h) are not<br>declared as extern. Lets add it now.<br><br>Change-Id: Ib6c4cbea649f790fa4db1ed2fe2b7e76a60291b4<br>Related: OS#3615<br>---<br>M include/osmocom/gsm/protocol/gsm_29_118.h<br>1 file changed, 8 insertions(+), 8 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/gsm/protocol/gsm_29_118.h b/include/osmocom/gsm/protocol/gsm_29_118.h</span><br><span>index bf210ad..97a9c43 100644</span><br><span>--- a/include/osmocom/gsm/protocol/gsm_29_118.h</span><br><span>+++ b/include/osmocom/gsm/protocol/gsm_29_118.h</span><br><span>@@ -35,7 +35,7 @@</span><br><span>   /* unassigned */</span><br><span>     SGSAP_MSGT_UE_UNREACHABLE               = 0x1f,</span><br><span> };</span><br><span style="color: hsl(0, 100%, 40%);">-const struct value_string sgsap_msg_type_names[];</span><br><span style="color: hsl(120, 100%, 40%);">+extern const struct value_string sgsap_msg_type_names[];</span><br><span> static inline const char *sgsap_msg_type_name(enum sgsap_msg_type msgt) {</span><br><span>        return get_value_string(sgsap_msg_type_names, msgt);</span><br><span> }</span><br><span>@@ -74,7 +74,7 @@</span><br><span>        SGSAP_IE_ADDL_PAGING_INDICATORS         = 0x26,</span><br><span>      SGSAP_IE_TMSI_BASED_NRI_CONT            = 0x27,</span><br><span> };</span><br><span style="color: hsl(0, 100%, 40%);">-const struct value_string sgsap_iei_names[];</span><br><span style="color: hsl(120, 100%, 40%);">+extern const struct value_string sgsap_iei_names[];</span><br><span> static inline const char *sgsap_iei_name(enum sgsap_iei iei) {</span><br><span>     return get_value_string(sgsap_iei_names, iei);</span><br><span> }</span><br><span>@@ -84,7 +84,7 @@</span><br><span>      SGSAP_EPS_LUT_IMSI_ATTACH               = 0x01,</span><br><span>      SGSAP_EPS_LUT_NORMAL                    = 0x02,</span><br><span> };</span><br><span style="color: hsl(0, 100%, 40%);">-const struct value_string sgsap_eps_lu_type_names[];</span><br><span style="color: hsl(120, 100%, 40%);">+extern const struct value_string sgsap_eps_lu_type_names[];</span><br><span> static inline const char *sgsap_eps_lu_type_name(enum sgsap_eps_lu_type lut) {</span><br><span>     return get_value_string(sgsap_eps_lu_type_names, lut);</span><br><span> }</span><br><span>@@ -95,7 +95,7 @@</span><br><span>      SGSAP_ID_EPS_T_UE_INITIATED             = 0x02,</span><br><span>      SGSAP_ID_EPS_T_EPS_NOT_ALLOWED          = 0x03,</span><br><span> };</span><br><span style="color: hsl(0, 100%, 40%);">-const struct value_string sgsap_ismi_det_eps_type_names[];</span><br><span style="color: hsl(120, 100%, 40%);">+extern const struct value_string sgsap_ismi_det_eps_type_names[];</span><br><span> static inline const char *sgsap_imsi_det_eps_type_name(enum sgsap_imsi_det_eps_type idt) {</span><br><span>     return get_value_string(sgsap_ismi_det_eps_type_names, idt);</span><br><span> }</span><br><span>@@ -106,7 +106,7 @@</span><br><span>      SGSAP_ID_NONEPS_T_COMBINED_UE_EPS_NONEPS        = 0x02,</span><br><span>      SGSAP_ID_NONEPS_T_IMPLICIT_UE_EPS_NONEPS        = 0x03,</span><br><span> };</span><br><span style="color: hsl(0, 100%, 40%);">-const struct value_string sgsap_ismi_det_noneps_type_names[];</span><br><span style="color: hsl(120, 100%, 40%);">+extern const struct value_string sgsap_ismi_det_noneps_type_names[];</span><br><span> static inline const char *sgsap_imsi_det_noneps_type_name(enum sgsap_imsi_det_noneps_type idt) {</span><br><span>         return get_value_string(sgsap_ismi_det_noneps_type_names, idt);</span><br><span> }</span><br><span>@@ -116,7 +116,7 @@</span><br><span>   SGSAP_SERV_IND_CS_CALL          = 0x01,</span><br><span>      SGSAP_SERV_IND_SMS              = 0x02,</span><br><span> };</span><br><span style="color: hsl(0, 100%, 40%);">-const struct value_string sgsap_service_ind_names[];</span><br><span style="color: hsl(120, 100%, 40%);">+extern const struct value_string sgsap_service_ind_names[];</span><br><span> static inline const char *sgsap_service_ind_name(enum sgsap_service_ind si) {</span><br><span>      return get_value_string(sgsap_service_ind_names, si);</span><br><span> }</span><br><span>@@ -138,7 +138,7 @@</span><br><span>     SGSAP_SGS_CAUSE_MT_CSFB_REJ_USER        = 0x0d,</span><br><span>      SGSAP_SGS_CAUSE_UE_TEMP_UNREACHABLE     = 0x0e,</span><br><span> };</span><br><span style="color: hsl(0, 100%, 40%);">-const struct value_string sgsap_sgs_cause_names[];</span><br><span style="color: hsl(120, 100%, 40%);">+extern const struct value_string sgsap_sgs_cause_names[];</span><br><span> static inline const char *sgsap_sgs_cause_name(enum sgsap_sgs_cause cause) {</span><br><span>   return get_value_string(sgsap_sgs_cause_names, cause);</span><br><span> }</span><br><span>@@ -148,7 +148,7 @@</span><br><span>    SGSAP_UE_EMM_MODE_IDLE                  = 0x00,</span><br><span>      SGSAP_UE_EMM_MODE_CONNECTED             = 0x01,</span><br><span> };</span><br><span style="color: hsl(0, 100%, 40%);">-const struct value_string sgsap_ue_emm_mode_names[];</span><br><span style="color: hsl(120, 100%, 40%);">+extern const struct value_string sgsap_ue_emm_mode_names[];</span><br><span> static inline const char *sgsap_ue_emm_mode_name(enum sgsap_ue_emm_mode mode) {</span><br><span>    return get_value_string(sgsap_ue_emm_mode_names, mode);</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/12144">change 12144</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12144"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Ib6c4cbea649f790fa4db1ed2fe2b7e76a60291b4 </div>
<div style="display:none"> Gerrit-Change-Number: 12144 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>