<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/12099">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Harald Welte: Looks good to me, approved
  Stefan Sperling: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">lms: Improve Set{Rx,Tx}{Gain,Freq} logging<br><br>Change-Id: I6713a27c5f74beb7fcfdd712fcf695afccbc3d76<br>---<br>M Transceiver52M/device/lms/LMSDevice.cpp<br>1 file changed, 10 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/Transceiver52M/device/lms/LMSDevice.cpp b/Transceiver52M/device/lms/LMSDevice.cpp</span><br><span>index 8f3d8e1..9804bbd 100644</span><br><span>--- a/Transceiver52M/device/lms/LMSDevice.cpp</span><br><span>+++ b/Transceiver52M/device/lms/LMSDevice.cpp</span><br><span>@@ -327,10 +327,10 @@</span><br><span>       if (dB < minTxGain())</span><br><span>             dB = minTxGain();</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   LOGC(DDEV, NOTICE) << "Setting TX gain to " << dB << " dB.";</span><br><span style="color: hsl(120, 100%, 40%);">+    LOGC(DDEV, NOTICE) << "chan " << chan <<": Setting TX gain to " << dB << " dB";</span><br><span> </span><br><span>      if (LMS_SetGaindB(m_lms_dev, LMS_CH_TX, chan, dB) < 0)</span><br><span style="color: hsl(0, 100%, 40%);">-               LOGC(DDEV, ERR) << "Error setting TX gain";</span><br><span style="color: hsl(120, 100%, 40%);">+           LOGC(DDEV, ERR) << "chan " << chan <<": Error setting TX gain to " << dB << " dB";</span><br><span> </span><br><span>   return dB;</span><br><span> }</span><br><span>@@ -342,10 +342,10 @@</span><br><span>      if (dB < minRxGain())</span><br><span>             dB = minRxGain();</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   LOGC(DDEV, NOTICE) << "Setting RX gain to " << dB << " dB.";</span><br><span style="color: hsl(120, 100%, 40%);">+    LOGC(DDEV, NOTICE) << "chan "<< chan << ": Setting RX gain to " << dB << " dB";</span><br><span> </span><br><span>      if (LMS_SetGaindB(m_lms_dev, LMS_CH_RX, chan, dB) < 0)</span><br><span style="color: hsl(0, 100%, 40%);">-               LOGC(DDEV, ERR) << "Error setting RX gain";</span><br><span style="color: hsl(120, 100%, 40%);">+           LOGC(DDEV, ERR) << "chan "<< chan << ": Error setting RX gain to " << dB << " dB";</span><br><span> </span><br><span>   return dB;</span><br><span> }</span><br><span>@@ -601,8 +601,10 @@</span><br><span> </span><br><span> bool LMSDevice::setTxFreq(double wFreq, size_t chan)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+       LOGC(DDEV, NOTICE) << "chan "<< chan << ": Setting Tx Freq to " << wFreq << " Hz";</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>     if (LMS_SetLOFrequency(m_lms_dev, LMS_CH_TX, chan, wFreq) < 0) {</span><br><span style="color: hsl(0, 100%, 40%);">-             LOGC(DDEV, ALERT) << "set Tx: " << wFreq << " failed!";</span><br><span style="color: hsl(120, 100%, 40%);">+         LOGC(DDEV, ERROR) << "chan "<< chan << ": Error setting Tx Freq to " << wFreq << " Hz";</span><br><span>          return false;</span><br><span>        }</span><br><span> </span><br><span>@@ -611,8 +613,10 @@</span><br><span> </span><br><span> bool LMSDevice::setRxFreq(double wFreq, size_t chan)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGC(DDEV, NOTICE) << "chan "<< chan << ": Setting Rx Freq to " << wFreq << " Hz";</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>     if (LMS_SetLOFrequency(m_lms_dev, LMS_CH_RX, chan, wFreq) < 0) {</span><br><span style="color: hsl(0, 100%, 40%);">-             LOGC(DDEV, ALERT) << "set Rx: " << wFreq << " failed!";</span><br><span style="color: hsl(120, 100%, 40%);">+         LOGC(DDEV, ERROR) << "chan "<< chan << ": Error setting Rx Freq to " << wFreq << " Hz";</span><br><span>          return false;</span><br><span>        }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/12099">change 12099</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12099"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-trx </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I6713a27c5f74beb7fcfdd712fcf695afccbc3d76 </div>
<div style="display:none"> Gerrit-Change-Number: 12099 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Stefan Sperling <stsp@stsp.name> </div>