<p><a href="https://gerrit.osmocom.org/12045">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/12045/2/jobs/master-builds.yml">File jobs/master-builds.yml:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/12045/2/jobs/master-builds.yml@206">Patch Set #2, Line 206:</a> <code style="font-family:monospace,monospace"> cmd: GTP="$GTP" ./contrib/jenkins.sh --publish</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Quick recap of what we discussed in private chat about this, as I was about to leave on Friday:</p><ul><li>you said, --publish is fine</li><li>I'll change the environment variable to WITH_MANUALS, so it is uppercase as all environment variables should be.</li></ul><p style="white-space: pre-wrap; word-wrap: break-word;"><br>> AFAIU the var is not redundant because it is not exported, so you'd need to either export GTP="$GTP" before calling jenkins.sh or, do it as it is done now.</p><p style="white-space: pre-wrap; word-wrap: break-word;">I'm sure that it is redundant. See the osmo-trx section from master-builds.yml for example. Currently in master, we have this code:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> - osmo-trx:<br> a1_name: INSTR<br> # ARM variants temporarily disabled due to issue OS#3061<br> # a1: !!python/tuple [--with-sse, --with-neon, --with-neon-vfpv4]<br> a1: !!python/tuple [--with-sse]<br> concurrent: true<br> cmd: ./contrib/jenkins.sh --publish</pre><p style="white-space: pre-wrap; word-wrap: break-word;"><br>So there's no INSTR="$INSTR" statement in front of jenkins.sh. The jenkins.sh script of osmo-trx.git has the following line:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> ./configure --enable-sanitize --enable-werror --with-uhd --with-usrp1 --with-lms $INSTR</pre><p style="white-space: pre-wrap; word-wrap: break-word;">And executed by jenkins, it it shows that INSTR holds --with-sse:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> + ./configure --enable-sanitize --enable-werror --with-uhd --with-usrp1 --with-lms --with-sse</pre><p style="white-space: pre-wrap; word-wrap: break-word;">https://jenkins.osmocom.org/jenkins/view/master/job/master-osmo-trx/710/INSTR=--with-sse,a2=default,a3=default,label=osmocom-master-debian9/console</p><p style="white-space: pre-wrap; word-wrap: break-word;"><br>> If that's not the case, then let's remove the GTP="$GTP" fomr verywhere</p><p style="white-space: pre-wrap; word-wrap: break-word;">I'll post a patch for that.</p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">but I'd at least investigate git log why do wo do that.</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">The GTP="$GTP" line was introduced to master-builds.yml in the initial commit here:<br>https://gerrit.osmocom.org/#/c/osmo-ci/+/4827/</p><p style="white-space: pre-wrap; word-wrap: break-word;">Seems to be copy-pasted from gerrit-verifications.yml at the time, where the line was introduced here:</p><p style="white-space: pre-wrap; word-wrap: break-word;">https://gerrit.osmocom.org/#/c/osmo-ci/+/4826/1/jobs/gerrit-verifications.yml</p><p style="white-space: pre-wrap; word-wrap: break-word;">No additional message explaining the purpose of GTP="$GTP" is in the commit message or review. Looks like it was just a misunderstanding.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/12045">change 12045</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12045"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ci </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ie0643b17a6be6e86e281b50d78dd7a6858cf99ee </div>
<div style="display:none"> Gerrit-Change-Number: 12045 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 03 Dec 2018 10:11:34 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>