<p>Pau Espin Pedrol has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/12077">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">radioInterface: Fix memleak during close()<br><br>destructors of pointers created through "new" must be destroyed manually<br>through "delete".<br><br>Change-Id: I10d37579f16bec89cc762f200a8951218305c708<br>---<br>M Transceiver52M/radioInterface.cpp<br>1 file changed, 8 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/77/12077/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/Transceiver52M/radioInterface.cpp b/Transceiver52M/radioInterface.cpp</span><br><span>index 6245cfc..f488b0d 100644</span><br><span>--- a/Transceiver52M/radioInterface.cpp</span><br><span>+++ b/Transceiver52M/radioInterface.cpp</span><br><span>@@ -75,6 +75,14 @@</span><br><span> </span><br><span> void RadioInterface::close()</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+  for (std::vector<RadioBuffer*>::iterator it = sendBuffer.begin(); it != sendBuffer.end(); ++it)</span><br><span style="color: hsl(120, 100%, 40%);">+          delete *it;</span><br><span style="color: hsl(120, 100%, 40%);">+  for (std::vector<RadioBuffer*>::iterator it = recvBuffer.begin(); it != recvBuffer.end(); ++it)</span><br><span style="color: hsl(120, 100%, 40%);">+          delete *it;</span><br><span style="color: hsl(120, 100%, 40%);">+  for (std::vector<short*>::iterator it = convertSendBuffer.begin(); it != convertSendBuffer.end(); ++it)</span><br><span style="color: hsl(120, 100%, 40%);">+          delete[] *it;</span><br><span style="color: hsl(120, 100%, 40%);">+  for (std::vector<short*>::iterator it = convertRecvBuffer.begin(); it != convertRecvBuffer.end(); ++it)</span><br><span style="color: hsl(120, 100%, 40%);">+          delete[] *it;</span><br><span>   sendBuffer.resize(0);</span><br><span>   recvBuffer.resize(0);</span><br><span>   convertSendBuffer.resize(0);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/12077">change 12077</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12077"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-trx </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I10d37579f16bec89cc762f200a8951218305c708 </div>
<div style="display:none"> Gerrit-Change-Number: 12077 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Pau Espin Pedrol <pespin@sysmocom.de> </div>