<p>Max <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/11926">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Neels Hofmeyr: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ctrl: use #define for TRAP id<br><br>We always use id = 0 when sending TRAP messages. Let's make this more<br>obvious by introducing appropriate define.<br><br>Change-Id: I33d7d4c6a1885a75a85d6f2f017430e0860b4126<br>---<br>M include/osmocom/ctrl/control_cmd.h<br>M src/ctrl/control_if.c<br>2 files changed, 2 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/ctrl/control_cmd.h b/include/osmocom/ctrl/control_cmd.h</span><br><span>index 93055c7..276a7de 100644</span><br><span>--- a/include/osmocom/ctrl/control_cmd.h</span><br><span>+++ b/include/osmocom/ctrl/control_cmd.h</span><br><span>@@ -12,6 +12,7 @@</span><br><span> #define CTRL_CMD_ERROR         -1</span><br><span> #define CTRL_CMD_HANDLED  0</span><br><span> #define CTRL_CMD_REPLY             1</span><br><span style="color: hsl(120, 100%, 40%);">+#define CTRL_CMD_TRAP_ID     "0"</span><br><span> </span><br><span> struct ctrl_handle;</span><br><span> </span><br><span>diff --git a/src/ctrl/control_if.c b/src/ctrl/control_if.c</span><br><span>index 1121d07..0209f3b 100644</span><br><span>--- a/src/ctrl/control_if.c</span><br><span>+++ b/src/ctrl/control_if.c</span><br><span>@@ -156,7 +156,7 @@</span><br><span>  if (!cmd)</span><br><span>            return -ENOMEM;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-     cmd->id = "0"; /* It's a TRAP! */</span><br><span style="color: hsl(120, 100%, 40%);">+    cmd->id = CTRL_CMD_TRAP_ID; /* It's a TRAP! */</span><br><span>        cmd->variable = (char *) name;</span><br><span>    cmd->reply = value;</span><br><span>       r = ctrl_cmd_send_to_all(ctrl, cmd);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11926">change 11926</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11926"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I33d7d4c6a1885a75a85d6f2f017430e0860b4126 </div>
<div style="display:none"> Gerrit-Change-Number: 11926 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Max <msuraev@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Max <msuraev@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: Pau Espin Pedrol <pespin@sysmocom.de> </div>