<p>Neels Hofmeyr has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/12033">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">combine several small .h in msc_common.h<br><br>For hysterical raisins, there are some header files that contain few<br>declarations, and where the name doesn't reflect the content. Combine them to<br>new msc_common.h:<br><br>- common.h<br>- common_cs.h<br>- debug.h<br>- osmo_msc.h<br>=> msc_common.h<br><br>Change-Id: I9e3a587342f8d398fb27354a2f2475f8797cdb28<br>---<br>M include/osmocom/msc/Makefile.am<br>D include/osmocom/msc/common.h<br>D include/osmocom/msc/common_cs.h<br>D include/osmocom/msc/debug.h<br>M include/osmocom/msc/gsm_data.h<br>M include/osmocom/msc/gsm_data_shared.h<br>A include/osmocom/msc/msc_common.h<br>D include/osmocom/msc/osmo_msc.h<br>M src/libmsc/a_iface.c<br>M src/libmsc/a_iface_bssap.c<br>M src/libmsc/a_reset.c<br>M src/libmsc/ctrl_commands.c<br>M src/libmsc/db.c<br>M src/libmsc/gsm_04_08.c<br>M src/libmsc/gsm_04_08_cc.c<br>M src/libmsc/gsm_04_11.c<br>M src/libmsc/gsm_04_14.c<br>M src/libmsc/gsm_09_11.c<br>M src/libmsc/gsm_subscriber.c<br>M src/libmsc/iucs.c<br>M src/libmsc/iucs_ranap.c<br>M src/libmsc/mncc.c<br>M src/libmsc/mncc_builtin.c<br>M src/libmsc/mncc_sock.c<br>M src/libmsc/msc_ifaces.c<br>M src/libmsc/msc_mgcp.c<br>M src/libmsc/msc_vty.c<br>M src/libmsc/osmo_msc.c<br>M src/libmsc/ran_conn.c<br>M src/libmsc/rrlp.c<br>M src/libmsc/silent_call.c<br>M src/libmsc/smpp_openbsc.c<br>M src/libmsc/smpp_smsc.c<br>M src/libmsc/sms_queue.c<br>M src/libmsc/transaction.c<br>M src/libvlr/vlr.c<br>M src/libvlr/vlr_access_req_fsm.c<br>M src/libvlr/vlr_auth_fsm.c<br>M src/libvlr/vlr_lu_fsm.c<br>M src/osmo-msc/msc_main.c<br>M src/utils/smpp_mirror.c<br>M tests/msc_vlr/msc_vlr_tests.c<br>M tests/msc_vlr/msc_vlr_tests.h<br>M tests/smpp/smpp_test.c<br>M tests/sms_queue/sms_queue_test.c<br>45 files changed, 52 insertions(+), 113 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/33/12033/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/msc/Makefile.am b/include/osmocom/msc/Makefile.am</span><br><span>index 9fa58c7..ca83b2d 100644</span><br><span>--- a/include/osmocom/msc/Makefile.am</span><br><span>+++ b/include/osmocom/msc/Makefile.am</span><br><span>@@ -1,10 +1,7 @@</span><br><span> noinst_HEADERS = \</span><br><span>      a_iface.h \</span><br><span>  a_iface_bssap.h \</span><br><span style="color: hsl(0, 100%, 40%);">-       common.h \</span><br><span style="color: hsl(0, 100%, 40%);">-      common_cs.h \</span><br><span>        db.h \</span><br><span style="color: hsl(0, 100%, 40%);">-  debug.h \</span><br><span>    gsm_04_08.h \</span><br><span>        gsm_04_11.h \</span><br><span>        gsm_04_14.h \</span><br><span>@@ -18,10 +15,10 @@</span><br><span>  iu_dummy.h \</span><br><span>         mncc.h \</span><br><span>     mncc_int.h \</span><br><span style="color: hsl(120, 100%, 40%);">+  msc_common.h \</span><br><span>       msc_ifaces.h \</span><br><span>       msc_mgcp.h \</span><br><span>         a_reset.h \</span><br><span style="color: hsl(0, 100%, 40%);">-     osmo_msc.h \</span><br><span>         ran_conn.h \</span><br><span>         rrlp.h \</span><br><span>     signal.h \</span><br><span>diff --git a/include/osmocom/msc/common.h b/include/osmocom/msc/common.h</span><br><span>deleted file mode 100644</span><br><span>index d91b3d3..0000000</span><br><span>--- a/include/osmocom/msc/common.h</span><br><span>+++ /dev/null</span><br><span>@@ -1,6 +0,0 @@</span><br><span style="color: hsl(0, 100%, 40%);">-#pragma once</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-enum nsap_addr_enc {</span><br><span style="color: hsl(0, 100%, 40%);">-        NSAP_ADDR_ENC_X213,</span><br><span style="color: hsl(0, 100%, 40%);">-     NSAP_ADDR_ENC_V4RAW,</span><br><span style="color: hsl(0, 100%, 40%);">-};</span><br><span>diff --git a/include/osmocom/msc/common_cs.h b/include/osmocom/msc/common_cs.h</span><br><span>deleted file mode 100644</span><br><span>index 14fe618..0000000</span><br><span>--- a/include/osmocom/msc/common_cs.h</span><br><span>+++ /dev/null</span><br><span>@@ -1,8 +0,0 @@</span><br><span style="color: hsl(0, 100%, 40%);">-#pragma once</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-struct msgb;</span><br><span style="color: hsl(0, 100%, 40%);">-struct gsm_network;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-typedef int (*mncc_recv_cb_t)(struct gsm_network *, struct msgb *);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-struct gsm_network *gsm_network_init(void *ctx, mncc_recv_cb_t mncc_recv);</span><br><span>diff --git a/include/osmocom/msc/debug.h b/include/osmocom/msc/debug.h</span><br><span>deleted file mode 100644</span><br><span>index 717cf74..0000000</span><br><span>--- a/include/osmocom/msc/debug.h</span><br><span>+++ /dev/null</span><br><span>@@ -1,25 +0,0 @@</span><br><span style="color: hsl(0, 100%, 40%);">-#pragma once</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/core/logging.h></span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-/* Debug Areas of the code */</span><br><span style="color: hsl(0, 100%, 40%);">-enum {</span><br><span style="color: hsl(0, 100%, 40%);">- DRLL,</span><br><span style="color: hsl(0, 100%, 40%);">-   DCC,</span><br><span style="color: hsl(0, 100%, 40%);">-    DMM,</span><br><span style="color: hsl(0, 100%, 40%);">-    DRR,</span><br><span style="color: hsl(0, 100%, 40%);">-    DMNCC,</span><br><span style="color: hsl(0, 100%, 40%);">-  DPAG,</span><br><span style="color: hsl(0, 100%, 40%);">-   DMSC,</span><br><span style="color: hsl(0, 100%, 40%);">-   DMGCP,</span><br><span style="color: hsl(0, 100%, 40%);">-  DHO,</span><br><span style="color: hsl(0, 100%, 40%);">-    DDB,</span><br><span style="color: hsl(0, 100%, 40%);">-    DREF,</span><br><span style="color: hsl(0, 100%, 40%);">-   DCTRL,</span><br><span style="color: hsl(0, 100%, 40%);">-  DSMPP,</span><br><span style="color: hsl(0, 100%, 40%);">-  DRANAP,</span><br><span style="color: hsl(0, 100%, 40%);">- DVLR,</span><br><span style="color: hsl(0, 100%, 40%);">-   DIUCS,</span><br><span style="color: hsl(0, 100%, 40%);">-  DBSSAP,</span><br><span style="color: hsl(0, 100%, 40%);">- Debug_LastEntry,</span><br><span style="color: hsl(0, 100%, 40%);">-};</span><br><span>diff --git a/include/osmocom/msc/gsm_data.h b/include/osmocom/msc/gsm_data.h</span><br><span>index 35ec752..3ffa100 100644</span><br><span>--- a/include/osmocom/msc/gsm_data.h</span><br><span>+++ b/include/osmocom/msc/gsm_data.h</span><br><span>@@ -13,10 +13,10 @@</span><br><span> #include <osmocom/gsm/gsm48.h></span><br><span> #include <osmocom/crypt/auth.h></span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/common.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/common_cs.h></span><br><span> #include <osmocom/mgcp_client/mgcp_client.h></span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/msc/msc_common.h></span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> #include "gsm_data_shared.h"</span><br><span> </span><br><span> /* TS 48.008 DLCI containing DCCH/ACCH + SAPI */</span><br><span>diff --git a/include/osmocom/msc/gsm_data_shared.h b/include/osmocom/msc/gsm_data_shared.h</span><br><span>index f71e92b..732607b 100644</span><br><span>--- a/include/osmocom/msc/gsm_data_shared.h</span><br><span>+++ b/include/osmocom/msc/gsm_data_shared.h</span><br><span>@@ -12,8 +12,6 @@</span><br><span> #include <osmocom/gsm/tlv.h></span><br><span> #include <osmocom/gsm/protocol/gsm_04_08.h></span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/common_cs.h></span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> struct osmo_bsc_data;</span><br><span> </span><br><span> struct osmo_bsc_sccp_con;</span><br><span>diff --git a/include/osmocom/msc/msc_common.h b/include/osmocom/msc/msc_common.h</span><br><span>new file mode 100644</span><br><span>index 0000000..d0c2c0b</span><br><span>--- /dev/null</span><br><span>+++ b/include/osmocom/msc/msc_common.h</span><br><span>@@ -0,0 +1,43 @@</span><br><span style="color: hsl(120, 100%, 40%);">+#pragma once</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+struct msgb;</span><br><span style="color: hsl(120, 100%, 40%);">+struct gsm_network;</span><br><span style="color: hsl(120, 100%, 40%);">+struct vlr_subscr;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#define MSC_HLR_REMOTE_IP_DEFAULT "127.0.0.1"</span><br><span style="color: hsl(120, 100%, 40%);">+#define MSC_HLR_REMOTE_PORT_DEFAULT OSMO_GSUP_PORT</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+enum msc_debug_categories {</span><br><span style="color: hsl(120, 100%, 40%);">+    DRLL,</span><br><span style="color: hsl(120, 100%, 40%);">+ DCC,</span><br><span style="color: hsl(120, 100%, 40%);">+  DMM,</span><br><span style="color: hsl(120, 100%, 40%);">+  DRR,</span><br><span style="color: hsl(120, 100%, 40%);">+  DMNCC,</span><br><span style="color: hsl(120, 100%, 40%);">+        DPAG,</span><br><span style="color: hsl(120, 100%, 40%);">+ DMSC,</span><br><span style="color: hsl(120, 100%, 40%);">+ DMGCP,</span><br><span style="color: hsl(120, 100%, 40%);">+        DHO,</span><br><span style="color: hsl(120, 100%, 40%);">+  DDB,</span><br><span style="color: hsl(120, 100%, 40%);">+  DREF,</span><br><span style="color: hsl(120, 100%, 40%);">+ DCTRL,</span><br><span style="color: hsl(120, 100%, 40%);">+        DSMPP,</span><br><span style="color: hsl(120, 100%, 40%);">+        DRANAP,</span><br><span style="color: hsl(120, 100%, 40%);">+       DVLR,</span><br><span style="color: hsl(120, 100%, 40%);">+ DIUCS,</span><br><span style="color: hsl(120, 100%, 40%);">+        DBSSAP,</span><br><span style="color: hsl(120, 100%, 40%);">+       Debug_LastEntry</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+enum nsap_addr_enc {</span><br><span style="color: hsl(120, 100%, 40%);">+   NSAP_ADDR_ENC_X213,</span><br><span style="color: hsl(120, 100%, 40%);">+   NSAP_ADDR_ENC_V4RAW,</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+typedef int (*mncc_recv_cb_t)(struct gsm_network *, struct msgb *);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+struct gsm_network *gsm_network_init(void *ctx, mncc_recv_cb_t mncc_recv);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+int msc_vlr_alloc(struct gsm_network *net);</span><br><span style="color: hsl(120, 100%, 40%);">+int msc_vlr_start(struct gsm_network *net);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+void msc_stop_paging(struct vlr_subscr *vsub);</span><br><span>diff --git a/include/osmocom/msc/osmo_msc.h b/include/osmocom/msc/osmo_msc.h</span><br><span>deleted file mode 100644</span><br><span>index 1512017..0000000</span><br><span>--- a/include/osmocom/msc/osmo_msc.h</span><br><span>+++ /dev/null</span><br><span>@@ -1,14 +0,0 @@</span><br><span style="color: hsl(0, 100%, 40%);">-#pragma once</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-/* Routines for the MSC handling */</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-struct gsm_network;</span><br><span style="color: hsl(0, 100%, 40%);">-struct vlr_subscr;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-#define MSC_HLR_REMOTE_IP_DEFAULT "127.0.0.1"</span><br><span style="color: hsl(0, 100%, 40%);">-#define MSC_HLR_REMOTE_PORT_DEFAULT OSMO_GSUP_PORT</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-int msc_vlr_alloc(struct gsm_network *net);</span><br><span style="color: hsl(0, 100%, 40%);">-int msc_vlr_start(struct gsm_network *net);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-void msc_stop_paging(struct vlr_subscr *vsub);</span><br><span>diff --git a/src/libmsc/a_iface.c b/src/libmsc/a_iface.c</span><br><span>index 82519d6..14744fc 100644</span><br><span>--- a/src/libmsc/a_iface.c</span><br><span>+++ b/src/libmsc/a_iface.c</span><br><span>@@ -30,7 +30,6 @@</span><br><span> #include <osmocom/gsm/protocol/gsm_08_08.h></span><br><span> #include <osmocom/gsm/protocol/gsm_04_08.h></span><br><span> #include <osmocom/gsm/gsm0808_utils.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/debug.h></span><br><span> #include <osmocom/msc/msc_ifaces.h></span><br><span> #include <osmocom/msc/a_iface.h></span><br><span> #include <osmocom/msc/a_iface_bssap.h></span><br><span>@@ -39,7 +38,6 @@</span><br><span> #include <osmocom/core/byteswap.h></span><br><span> #include <osmocom/sccp/sccp_types.h></span><br><span> #include <osmocom/msc/a_reset.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/osmo_msc.h></span><br><span> #include <osmocom/msc/vlr.h></span><br><span> </span><br><span> #include <errno.h></span><br><span>diff --git a/src/libmsc/a_iface_bssap.c b/src/libmsc/a_iface_bssap.c</span><br><span>index 4d03d23..c31be29 100644</span><br><span>--- a/src/libmsc/a_iface_bssap.c</span><br><span>+++ b/src/libmsc/a_iface_bssap.c</span><br><span>@@ -27,11 +27,9 @@</span><br><span> #include <osmocom/gsm/gsm0808.h></span><br><span> #include <osmocom/gsm/gsm48.h></span><br><span> #include <osmocom/gsm/gsm0808_utils.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/debug.h></span><br><span> #include <osmocom/msc/gsm_data.h></span><br><span> #include <osmocom/msc/a_iface_bssap.h></span><br><span> #include <osmocom/msc/a_iface.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/osmo_msc.h></span><br><span> #include <osmocom/core/byteswap.h></span><br><span> #include <osmocom/msc/a_reset.h></span><br><span> #include <osmocom/msc/transaction.h></span><br><span>diff --git a/src/libmsc/a_reset.c b/src/libmsc/a_reset.c</span><br><span>index 1e35a10..6c2b5cb 100644</span><br><span>--- a/src/libmsc/a_reset.c</span><br><span>+++ b/src/libmsc/a_reset.c</span><br><span>@@ -25,8 +25,8 @@</span><br><span> #include <unistd.h></span><br><span> #include <errno.h></span><br><span> #include <string.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/debug.h></span><br><span> #include <osmocom/msc/a_reset.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/msc/msc_common.h></span><br><span> </span><br><span> #define RESET_RESEND_INTERVAL 2             /* sec */</span><br><span> #define RESET_RESEND_TIMER_NO 16   /* See also 3GPP TS 48.008 Chapter 3.1.4.1.3.2 */</span><br><span>diff --git a/src/libmsc/ctrl_commands.c b/src/libmsc/ctrl_commands.c</span><br><span>index e37cc94..1d877cb 100644</span><br><span>--- a/src/libmsc/ctrl_commands.c</span><br><span>+++ b/src/libmsc/ctrl_commands.c</span><br><span>@@ -24,7 +24,6 @@</span><br><span> #include <osmocom/msc/gsm_data.h></span><br><span> #include <osmocom/msc/gsm_subscriber.h></span><br><span> #include <osmocom/msc/db.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/debug.h></span><br><span> #include <osmocom/msc/vlr.h></span><br><span> </span><br><span> #include <stdbool.h></span><br><span>diff --git a/src/libmsc/db.c b/src/libmsc/db.c</span><br><span>index b5e7ad8..c11c6d2 100644</span><br><span>--- a/src/libmsc/db.c</span><br><span>+++ b/src/libmsc/db.c</span><br><span>@@ -34,7 +34,6 @@</span><br><span> #include <osmocom/msc/gsm_subscriber.h></span><br><span> #include <osmocom/msc/gsm_04_11.h></span><br><span> #include <osmocom/msc/db.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/debug.h></span><br><span> #include <osmocom/msc/vlr.h></span><br><span> </span><br><span> #include <osmocom/gsm/protocol/gsm_23_003.h></span><br><span>diff --git a/src/libmsc/gsm_04_08.c b/src/libmsc/gsm_04_08.c</span><br><span>index c20dba2..83f8d99 100644</span><br><span>--- a/src/libmsc/gsm_04_08.c</span><br><span>+++ b/src/libmsc/gsm_04_08.c</span><br><span>@@ -35,7 +35,6 @@</span><br><span> #include "bscconfig.h"</span><br><span> </span><br><span> #include <osmocom/msc/db.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/debug.h></span><br><span> #include <osmocom/msc/gsm_data.h></span><br><span> #include <osmocom/msc/gsm_subscriber.h></span><br><span> #include <osmocom/msc/gsm_04_11.h></span><br><span>@@ -46,7 +45,6 @@</span><br><span> #include <osmocom/msc/signal.h></span><br><span> #include <osmocom/msc/transaction.h></span><br><span> #include <osmocom/msc/silent_call.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/osmo_msc.h></span><br><span> #include <osmocom/msc/mncc_int.h></span><br><span> #include <osmocom/abis/e1_input.h></span><br><span> #include <osmocom/core/bitvec.h></span><br><span>diff --git a/src/libmsc/gsm_04_08_cc.c b/src/libmsc/gsm_04_08_cc.c</span><br><span>index 8ac87c1..1d9ec57 100644</span><br><span>--- a/src/libmsc/gsm_04_08_cc.c</span><br><span>+++ b/src/libmsc/gsm_04_08_cc.c</span><br><span>@@ -33,7 +33,6 @@</span><br><span> #include "bscconfig.h"</span><br><span> </span><br><span> #include <osmocom/msc/db.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/debug.h></span><br><span> #include <osmocom/msc/gsm_data.h></span><br><span> #include <osmocom/msc/gsm_subscriber.h></span><br><span> #include <osmocom/msc/gsm_04_11.h></span><br><span>@@ -44,7 +43,6 @@</span><br><span> #include <osmocom/msc/signal.h></span><br><span> #include <osmocom/msc/transaction.h></span><br><span> #include <osmocom/msc/silent_call.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/osmo_msc.h></span><br><span> #include <osmocom/msc/mncc_int.h></span><br><span> #include <osmocom/abis/e1_input.h></span><br><span> #include <osmocom/core/bitvec.h></span><br><span>diff --git a/src/libmsc/gsm_04_11.c b/src/libmsc/gsm_04_11.c</span><br><span>index 03027ae..191b6bb 100644</span><br><span>--- a/src/libmsc/gsm_04_11.c</span><br><span>+++ b/src/libmsc/gsm_04_11.c</span><br><span>@@ -43,7 +43,6 @@</span><br><span> #include <osmocom/gsm/gsm0411_utils.h></span><br><span> #include <osmocom/gsm/protocol/gsm_04_11.h></span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/debug.h></span><br><span> #include <osmocom/msc/gsm_data.h></span><br><span> #include <osmocom/msc/db.h></span><br><span> #include <osmocom/msc/gsm_subscriber.h></span><br><span>@@ -52,7 +51,6 @@</span><br><span> #include <osmocom/msc/db.h></span><br><span> #include <osmocom/msc/transaction.h></span><br><span> #include <osmocom/msc/msc_ifaces.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/osmo_msc.h></span><br><span> #include <osmocom/msc/vlr.h></span><br><span> </span><br><span> #ifdef BUILD_SMPP</span><br><span>diff --git a/src/libmsc/gsm_04_14.c b/src/libmsc/gsm_04_14.c</span><br><span>index 8fe03a8..f7e225d 100644</span><br><span>--- a/src/libmsc/gsm_04_14.c</span><br><span>+++ b/src/libmsc/gsm_04_14.c</span><br><span>@@ -26,7 +26,6 @@</span><br><span> </span><br><span> #include "bscconfig.h"</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/debug.h></span><br><span> #include <osmocom/msc/gsm_data.h></span><br><span> #include <osmocom/msc/gsm_subscriber.h></span><br><span> #include <osmocom/msc/gsm_04_08.h></span><br><span>diff --git a/src/libmsc/gsm_09_11.c b/src/libmsc/gsm_09_11.c</span><br><span>index c0a0bdd..b5f586a 100644</span><br><span>--- a/src/libmsc/gsm_09_11.c</span><br><span>+++ b/src/libmsc/gsm_09_11.c</span><br><span>@@ -41,8 +41,6 @@</span><br><span> </span><br><span> #include <osmocom/msc/gsm_04_80.h></span><br><span> #include <osmocom/msc/gsm_subscriber.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/debug.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/osmo_msc.h></span><br><span> #include <osmocom/msc/vlr.h></span><br><span> #include <osmocom/msc/gsm_04_08.h></span><br><span> #include <osmocom/msc/transaction.h></span><br><span>diff --git a/src/libmsc/gsm_subscriber.c b/src/libmsc/gsm_subscriber.c</span><br><span>index a5bf745..a4ebf5f 100644</span><br><span>--- a/src/libmsc/gsm_subscriber.c</span><br><span>+++ b/src/libmsc/gsm_subscriber.c</span><br><span>@@ -42,11 +42,9 @@</span><br><span> </span><br><span> #include <osmocom/msc/gsm_subscriber.h></span><br><span> #include <osmocom/msc/gsm_04_08.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/debug.h></span><br><span> #include <osmocom/msc/signal.h></span><br><span> #include <osmocom/msc/db.h></span><br><span> #include <osmocom/msc/vlr.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/osmo_msc.h></span><br><span> #include <osmocom/msc/msc_ifaces.h></span><br><span> #include <osmocom/msc/a_iface.h></span><br><span> </span><br><span>diff --git a/src/libmsc/iucs.c b/src/libmsc/iucs.c</span><br><span>index 1e4ab19..062317b 100644</span><br><span>--- a/src/libmsc/iucs.c</span><br><span>+++ b/src/libmsc/iucs.c</span><br><span>@@ -26,12 +26,10 @@</span><br><span> </span><br><span> #include <osmocom/core/logging.h></span><br><span> #include <osmocom/ranap/iu_client.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/debug.h></span><br><span> </span><br><span> #include <osmocom/msc/gsm_data.h></span><br><span> #include <osmocom/msc/gsm_subscriber.h></span><br><span> #include <osmocom/msc/transaction.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/osmo_msc.h></span><br><span> #include <osmocom/msc/vlr.h></span><br><span> #include <osmocom/core/byteswap.h></span><br><span> </span><br><span>diff --git a/src/libmsc/iucs_ranap.c b/src/libmsc/iucs_ranap.c</span><br><span>index a657857..da64333 100644</span><br><span>--- a/src/libmsc/iucs_ranap.c</span><br><span>+++ b/src/libmsc/iucs_ranap.c</span><br><span>@@ -31,13 +31,11 @@</span><br><span> #include <osmocom/ranap/RANAP_IuTransportAssociation.h></span><br><span> #include <osmocom/ranap/iu_helpers.h></span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/debug.h></span><br><span> #include <osmocom/msc/gsm_data.h></span><br><span> #include <osmocom/msc/gsm_subscriber.h></span><br><span> #include <osmocom/msc/iucs.h></span><br><span> #include <osmocom/msc/vlr.h></span><br><span> #include <osmocom/msc/iucs_ranap.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/osmo_msc.h></span><br><span> #include <osmocom/msc/msc_mgcp.h></span><br><span> </span><br><span> #include <asn1c/asn1helpers.h></span><br><span>diff --git a/src/libmsc/mncc.c b/src/libmsc/mncc.c</span><br><span>index d2cd170..f4c8c7e 100644</span><br><span>--- a/src/libmsc/mncc.c</span><br><span>+++ b/src/libmsc/mncc.c</span><br><span>@@ -30,7 +30,6 @@</span><br><span> #include <osmocom/core/utils.h></span><br><span> </span><br><span> #include <osmocom/msc/gsm_04_08.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/debug.h></span><br><span> #include <osmocom/msc/mncc.h></span><br><span> #include <osmocom/msc/gsm_data.h></span><br><span> #include <osmocom/msc/transaction.h></span><br><span>diff --git a/src/libmsc/mncc_builtin.c b/src/libmsc/mncc_builtin.c</span><br><span>index 135a5e4..bc37b4a 100644</span><br><span>--- a/src/libmsc/mncc_builtin.c</span><br><span>+++ b/src/libmsc/mncc_builtin.c</span><br><span>@@ -28,7 +28,6 @@</span><br><span> #include <errno.h></span><br><span> </span><br><span> #include <osmocom/msc/gsm_04_08.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/debug.h></span><br><span> #include <osmocom/msc/mncc.h></span><br><span> #include <osmocom/msc/mncc_int.h></span><br><span> #include <osmocom/core/talloc.h></span><br><span>diff --git a/src/libmsc/mncc_sock.c b/src/libmsc/mncc_sock.c</span><br><span>index 57b4bd8..47a7a6c 100644</span><br><span>--- a/src/libmsc/mncc_sock.c</span><br><span>+++ b/src/libmsc/mncc_sock.c</span><br><span>@@ -35,7 +35,6 @@</span><br><span> #include <osmocom/core/socket.h></span><br><span> #include <osmocom/gsm/protocol/gsm_04_08.h></span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/debug.h></span><br><span> #include <osmocom/msc/mncc.h></span><br><span> #include <osmocom/msc/gsm_data.h></span><br><span> #include <osmocom/msc/gsm_04_08.h></span><br><span>diff --git a/src/libmsc/msc_ifaces.c b/src/libmsc/msc_ifaces.c</span><br><span>index 8ae34fc..4559e96 100644</span><br><span>--- a/src/libmsc/msc_ifaces.c</span><br><span>+++ b/src/libmsc/msc_ifaces.c</span><br><span>@@ -20,7 +20,6 @@</span><br><span> </span><br><span> #include <osmocom/core/logging.h></span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/debug.h></span><br><span> #include <osmocom/msc/gsm_data.h></span><br><span> #include <osmocom/msc/msc_ifaces.h></span><br><span> #include <osmocom/msc/gsm_subscriber.h></span><br><span>diff --git a/src/libmsc/msc_mgcp.c b/src/libmsc/msc_mgcp.c</span><br><span>index 1ddec08..c2b7441 100644</span><br><span>--- a/src/libmsc/msc_mgcp.c</span><br><span>+++ b/src/libmsc/msc_mgcp.c</span><br><span>@@ -27,7 +27,6 @@</span><br><span> #include <osmocom/core/fsm.h></span><br><span> #include <osmocom/core/byteswap.h></span><br><span> #include <osmocom/msc/msc_mgcp.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/debug.h></span><br><span> #include <osmocom/msc/transaction.h></span><br><span> #include <osmocom/msc/a_iface.h></span><br><span> #include <osmocom/msc/msc_ifaces.h></span><br><span>diff --git a/src/libmsc/msc_vty.c b/src/libmsc/msc_vty.c</span><br><span>index 598916a..03dbbc9 100644</span><br><span>--- a/src/libmsc/msc_vty.c</span><br><span>+++ b/src/libmsc/msc_vty.c</span><br><span>@@ -43,7 +43,6 @@</span><br><span> #endif</span><br><span> </span><br><span> #include <osmocom/msc/vty.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/osmo_msc.h></span><br><span> #include <osmocom/msc/gsm_data.h></span><br><span> #include <osmocom/msc/gsm_subscriber.h></span><br><span> #include <osmocom/msc/vlr.h></span><br><span>diff --git a/src/libmsc/osmo_msc.c b/src/libmsc/osmo_msc.c</span><br><span>index fc85dd1..9d93d50 100644</span><br><span>--- a/src/libmsc/osmo_msc.c</span><br><span>+++ b/src/libmsc/osmo_msc.c</span><br><span>@@ -21,12 +21,9 @@</span><br><span>  *</span><br><span>  */</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/osmo_msc.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/debug.h></span><br><span> #include <osmocom/msc/transaction.h></span><br><span> #include <osmocom/msc/db.h></span><br><span> #include <osmocom/msc/vlr.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/osmo_msc.h></span><br><span> #include <osmocom/msc/a_iface.h></span><br><span> #include <osmocom/msc/gsm_04_08.h></span><br><span> #include <osmocom/msc/gsm_04_11.h></span><br><span>diff --git a/src/libmsc/ran_conn.c b/src/libmsc/ran_conn.c</span><br><span>index 9b63f16..5cb62ef 100644</span><br><span>--- a/src/libmsc/ran_conn.c</span><br><span>+++ b/src/libmsc/ran_conn.c</span><br><span>@@ -27,7 +27,6 @@</span><br><span> </span><br><span> #include <osmocom/msc/ran_conn.h></span><br><span> #include <osmocom/msc/vlr.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/debug.h></span><br><span> #include <osmocom/msc/transaction.h></span><br><span> #include <osmocom/msc/signal.h></span><br><span> #include <osmocom/msc/a_iface.h></span><br><span>diff --git a/src/libmsc/rrlp.c b/src/libmsc/rrlp.c</span><br><span>index 6ff30b7..32844f5 100644</span><br><span>--- a/src/libmsc/rrlp.c</span><br><span>+++ b/src/libmsc/rrlp.c</span><br><span>@@ -25,7 +25,6 @@</span><br><span> </span><br><span> #include <osmocom/msc/gsm_04_08.h></span><br><span> #include <osmocom/msc/signal.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/debug.h></span><br><span> #include <osmocom/msc/gsm_subscriber.h></span><br><span> #include <osmocom/msc/ran_conn.h></span><br><span> </span><br><span>diff --git a/src/libmsc/silent_call.c b/src/libmsc/silent_call.c</span><br><span>index c6c31a0..da9df6c 100644</span><br><span>--- a/src/libmsc/silent_call.c</span><br><span>+++ b/src/libmsc/silent_call.c</span><br><span>@@ -26,10 +26,8 @@</span><br><span> </span><br><span> #include <osmocom/core/msgb.h></span><br><span> #include <osmocom/msc/signal.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/debug.h></span><br><span> #include <osmocom/msc/gsm_data.h></span><br><span> #include <osmocom/msc/gsm_subscriber.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/osmo_msc.h></span><br><span> #include <osmocom/msc/vlr.h></span><br><span> </span><br><span> /* paging of the requested subscriber has completed */</span><br><span>diff --git a/src/libmsc/smpp_openbsc.c b/src/libmsc/smpp_openbsc.c</span><br><span>index 10f3cfa..0f0871d 100644</span><br><span>--- a/src/libmsc/smpp_openbsc.c</span><br><span>+++ b/src/libmsc/smpp_openbsc.c</span><br><span>@@ -37,7 +37,6 @@</span><br><span> #include <osmocom/gsm/protocol/smpp34_osmocom.h></span><br><span> </span><br><span> #include <osmocom/msc/gsm_subscriber.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/debug.h></span><br><span> #include <osmocom/msc/db.h></span><br><span> #include <osmocom/msc/gsm_04_11.h></span><br><span> #include <osmocom/msc/gsm_data.h></span><br><span>diff --git a/src/libmsc/smpp_smsc.c b/src/libmsc/smpp_smsc.c</span><br><span>index ea5303c..87295cd 100644</span><br><span>--- a/src/libmsc/smpp_smsc.c</span><br><span>+++ b/src/libmsc/smpp_smsc.c</span><br><span>@@ -41,7 +41,6 @@</span><br><span> </span><br><span> #include "smpp_smsc.h"</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/debug.h></span><br><span> #include <osmocom/msc/gsm_data.h></span><br><span> </span><br><span> /*! \brief Ugly wrapper. libsmpp34 should do this itself! */</span><br><span>diff --git a/src/libmsc/sms_queue.c b/src/libmsc/sms_queue.c</span><br><span>index 9907f4f..fd38d50 100644</span><br><span>--- a/src/libmsc/sms_queue.c</span><br><span>+++ b/src/libmsc/sms_queue.c</span><br><span>@@ -32,7 +32,6 @@</span><br><span> </span><br><span> #include <osmocom/msc/sms_queue.h></span><br><span> #include <osmocom/msc/db.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/debug.h></span><br><span> #include <osmocom/msc/gsm_data.h></span><br><span> #include <osmocom/msc/gsm_04_11.h></span><br><span> #include <osmocom/msc/gsm_subscriber.h></span><br><span>diff --git a/src/libmsc/transaction.c b/src/libmsc/transaction.c</span><br><span>index cf12066..dfb1acf 100644</span><br><span>--- a/src/libmsc/transaction.c</span><br><span>+++ b/src/libmsc/transaction.c</span><br><span>@@ -21,11 +21,9 @@</span><br><span> #include <osmocom/msc/transaction.h></span><br><span> #include <osmocom/msc/gsm_data.h></span><br><span> #include <osmocom/msc/mncc.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/debug.h></span><br><span> #include <osmocom/core/talloc.h></span><br><span> #include <osmocom/msc/gsm_04_08.h></span><br><span> #include <osmocom/msc/mncc.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/osmo_msc.h></span><br><span> #include <osmocom/msc/vlr.h></span><br><span> </span><br><span> void *tall_trans_ctx;</span><br><span>diff --git a/src/libvlr/vlr.c b/src/libvlr/vlr.c</span><br><span>index 189cb66..c777d8a 100644</span><br><span>--- a/src/libvlr/vlr.c</span><br><span>+++ b/src/libvlr/vlr.c</span><br><span>@@ -30,7 +30,6 @@</span><br><span> #include <osmocom/msc/gsm_subscriber.h></span><br><span> #include <osmocom/gsupclient/gsup_client.h></span><br><span> #include <osmocom/msc/vlr.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/debug.h></span><br><span> </span><br><span> #include <netinet/in.h></span><br><span> #include <arpa/inet.h></span><br><span>diff --git a/src/libvlr/vlr_access_req_fsm.c b/src/libvlr/vlr_access_req_fsm.c</span><br><span>index 3a0760d..0642d1d 100644</span><br><span>--- a/src/libvlr/vlr_access_req_fsm.c</span><br><span>+++ b/src/libvlr/vlr_access_req_fsm.c</span><br><span>@@ -23,7 +23,6 @@</span><br><span> #include <osmocom/gsm/gsup.h></span><br><span> #include <osmocom/gsm/gsm48.h></span><br><span> #include <osmocom/msc/vlr.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/debug.h></span><br><span> </span><br><span> #include "vlr_core.h"</span><br><span> #include "vlr_auth_fsm.h"</span><br><span>diff --git a/src/libvlr/vlr_auth_fsm.c b/src/libvlr/vlr_auth_fsm.c</span><br><span>index d5a8555..6384d39 100644</span><br><span>--- a/src/libvlr/vlr_auth_fsm.c</span><br><span>+++ b/src/libvlr/vlr_auth_fsm.c</span><br><span>@@ -24,7 +24,6 @@</span><br><span> #include <osmocom/core/utils.h></span><br><span> #include <osmocom/gsm/gsup.h></span><br><span> #include <osmocom/msc/vlr.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/debug.h></span><br><span> </span><br><span> #include "vlr_core.h"</span><br><span> #include "vlr_auth_fsm.h"</span><br><span>diff --git a/src/libvlr/vlr_lu_fsm.c b/src/libvlr/vlr_lu_fsm.c</span><br><span>index 02e49e0..637eb97 100644</span><br><span>--- a/src/libvlr/vlr_lu_fsm.c</span><br><span>+++ b/src/libvlr/vlr_lu_fsm.c</span><br><span>@@ -22,7 +22,6 @@</span><br><span> #include <osmocom/core/fsm.h></span><br><span> #include <osmocom/gsm/gsm48.h></span><br><span> #include <osmocom/msc/vlr.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/debug.h></span><br><span> </span><br><span> #include "vlr_core.h"</span><br><span> #include "vlr_auth_fsm.h"</span><br><span>diff --git a/src/osmo-msc/msc_main.c b/src/osmo-msc/msc_main.c</span><br><span>index a139046..f300b3d 100644</span><br><span>--- a/src/osmo-msc/msc_main.c</span><br><span>+++ b/src/osmo-msc/msc_main.c</span><br><span>@@ -41,12 +41,10 @@</span><br><span> #include <osmocom/core/application.h></span><br><span> #include <osmocom/core/select.h></span><br><span> #include <osmocom/core/stats.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/debug.h></span><br><span> #include <osmocom/abis/abis.h></span><br><span> #include <osmocom/abis/e1_input.h></span><br><span> #include <osmocom/core/talloc.h></span><br><span> #include <osmocom/msc/signal.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/osmo_msc.h></span><br><span> #include <osmocom/msc/sms_queue.h></span><br><span> #include <osmocom/vty/telnet_interface.h></span><br><span> #include <osmocom/vty/ports.h></span><br><span>diff --git a/src/utils/smpp_mirror.c b/src/utils/smpp_mirror.c</span><br><span>index 3053553..f464425 100644</span><br><span>--- a/src/utils/smpp_mirror.c</span><br><span>+++ b/src/utils/smpp_mirror.c</span><br><span>@@ -17,8 +17,9 @@</span><br><span> #include <osmocom/core/select.h></span><br><span> #include <osmocom/core/socket.h></span><br><span> #include <osmocom/core/write_queue.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/core/logging.h></span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/debug.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/msc/msc_common.h></span><br><span> </span><br><span> /* FIXME: merge with smpp_smsc.c */</span><br><span> #define SMPP_SYS_ID_LEN     16</span><br><span>diff --git a/tests/msc_vlr/msc_vlr_tests.c b/tests/msc_vlr/msc_vlr_tests.c</span><br><span>index 2443e31..861e56f 100644</span><br><span>--- a/tests/msc_vlr/msc_vlr_tests.c</span><br><span>+++ b/tests/msc_vlr/msc_vlr_tests.c</span><br><span>@@ -32,7 +32,6 @@</span><br><span> #include <osmocom/gsm/gsup.h></span><br><span> #include <osmocom/gsupclient/gsup_client.h></span><br><span> #include <osmocom/msc/gsm_04_11.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/debug.h></span><br><span> #include <osmocom/msc/gsm_04_08.h></span><br><span> #include <osmocom/msc/transaction.h></span><br><span> #include <osmocom/msc/a_iface_bssap.h></span><br><span>diff --git a/tests/msc_vlr/msc_vlr_tests.h b/tests/msc_vlr/msc_vlr_tests.h</span><br><span>index f308a03..f7ff940 100644</span><br><span>--- a/tests/msc_vlr/msc_vlr_tests.h</span><br><span>+++ b/tests/msc_vlr/msc_vlr_tests.h</span><br><span>@@ -27,7 +27,6 @@</span><br><span> #include <stdio.h></span><br><span> </span><br><span> #include <osmocom/msc/gsm_data.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/osmo_msc.h></span><br><span> #include <osmocom/msc/vlr.h></span><br><span> #include <osmocom/msc/mncc.h></span><br><span> </span><br><span>diff --git a/tests/smpp/smpp_test.c b/tests/smpp/smpp_test.c</span><br><span>index 1abb63b..1d1edca 100644</span><br><span>--- a/tests/smpp/smpp_test.c</span><br><span>+++ b/tests/smpp/smpp_test.c</span><br><span>@@ -20,10 +20,11 @@</span><br><span> #include <stdlib.h></span><br><span> #include <stdio.h></span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/debug.h></span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> #include <osmocom/core/application.h></span><br><span> #include <osmocom/core/backtrace.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/core/logging.h></span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/msc/msc_common.h></span><br><span> </span><br><span> #include "smpp_smsc.h"</span><br><span> </span><br><span>diff --git a/tests/sms_queue/sms_queue_test.c b/tests/sms_queue/sms_queue_test.c</span><br><span>index 6ce0b88..e9443e0 100644</span><br><span>--- a/tests/sms_queue/sms_queue_test.c</span><br><span>+++ b/tests/sms_queue/sms_queue_test.c</span><br><span>@@ -23,7 +23,6 @@</span><br><span> </span><br><span> #include <osmocom/core/application.h></span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/debug.h></span><br><span> #include <osmocom/msc/vlr.h></span><br><span> </span><br><span> static void *talloc_ctx = NULL;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/12033">change 12033</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12033"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I9e3a587342f8d398fb27354a2f2475f8797cdb28 </div>
<div style="display:none"> Gerrit-Change-Number: 12033 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>