<p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p><a href="https://gerrit.osmocom.org/12045">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/12045/2/jobs/master-builds.yml">File jobs/master-builds.yml:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/12045/2/jobs/master-builds.yml@206">Patch Set #2, Line 206:</a> <code style="font-family:monospace,monospace">          cmd: GTP="$GTP" ./contrib/jenkins.sh --publish</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Shouldn't publish be called conditionally based on with_manuals? see GTP="$GTP" as example. Not sure how to apply it as a boolean to env var though, you may need to move them to strings.</p><p style="white-space: pre-wrap; word-wrap: break-word;">a2_name: MANUALS<br>a2: !!python/tuple ["--enable-manuals", "--disable-manuals"]</p><p style="white-space: pre-wrap; word-wrap: break-word;">GTP="$GTP" MANUALS="$MANUALS" ./contrib/jenkins.sh --publish</p><p style="white-space: pre-wrap; word-wrap: break-word;"><br>And then use $MANUALS inside jenkins.sh.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/12045">change 12045</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12045"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ci </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ie0643b17a6be6e86e281b50d78dd7a6858cf99ee </div>
<div style="display:none"> Gerrit-Change-Number: 12045 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 30 Nov 2018 13:15:41 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>