<p style="white-space: pre-wrap; word-wrap: break-word;">Please, re-submit the patch (remember to keep the same Change-Id!) with the changes requested applied so we can merge it.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Thanks for contributing!</p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p><a href="https://gerrit.osmocom.org/12051">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/12051/1//COMMIT_MSG">Commit Message:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/12051/1//COMMIT_MSG@7">Patch Set #1, Line 7:</a> <code style="font-family:monospace,monospace">UHDDevice.cpp uhd_device::open() uhd::usrp::multi_usrp::make() added actual exception from uhd::key_error to extend debugging</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">First line of commit is way to long.</p><p style="white-space: pre-wrap; word-wrap: break-word;">What about:<br>UHDDevice: log exception information on device open failure</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/12051/1/Transceiver52M/device/uhd/UHDDevice.cpp">File Transceiver52M/device/uhd/UHDDevice.cpp:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/12051/1/Transceiver52M/device/uhd/UHDDevice.cpp@640">Patch Set #1, Line 640:</a> <code style="font-family:monospace,monospace">               LOGC(DDEV, ALERT) << "UHD make execption output:\n" << e.what();</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">typo: exception</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/12051">change 12051</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12051"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-trx </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ic33f4068d40cac3221960634185b697e10288dd1 </div>
<div style="display:none"> Gerrit-Change-Number: 12051 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: d0gtail <dogtail@web.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 30 Nov 2018 22:03:46 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>