<p>Neels Hofmeyr <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/12033">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Pau Espin Pedrol: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">combine several small .h in msc_common.h<br><br>For hysterical raisins, there are some header files that contain few<br>declarations, and where the name doesn't reflect the content. Combine them to<br>new msc_common.h:<br><br>- common.h<br>- common_cs.h<br>- osmo_msc.h<br><br>Change-Id: I9e3a587342f8d398fb27354a2f2475f8797cdb28<br>---<br>M include/osmocom/msc/Makefile.am<br>D include/osmocom/msc/common.h<br>D include/osmocom/msc/common_cs.h<br>M include/osmocom/msc/gsm_data.h<br>M include/osmocom/msc/gsm_data_shared.h<br>A include/osmocom/msc/msc_common.h<br>D include/osmocom/msc/osmo_msc.h<br>M src/libmsc/a_iface.c<br>M src/libmsc/a_iface_bssap.c<br>M src/libmsc/a_reset.c<br>M src/libmsc/gsm_04_08.c<br>M src/libmsc/gsm_04_08_cc.c<br>M src/libmsc/gsm_04_11.c<br>M src/libmsc/gsm_09_11.c<br>M src/libmsc/gsm_subscriber.c<br>M src/libmsc/iucs.c<br>M src/libmsc/iucs_ranap.c<br>M src/libmsc/msc_vty.c<br>M src/libmsc/osmo_msc.c<br>M src/libmsc/silent_call.c<br>M src/libmsc/transaction.c<br>M src/osmo-msc/msc_main.c<br>M tests/msc_vlr/msc_vlr_tests.h<br>23 files changed, 26 insertions(+), 53 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/msc/Makefile.am b/include/osmocom/msc/Makefile.am</span><br><span>index 9fa58c7..d98bc9c 100644</span><br><span>--- a/include/osmocom/msc/Makefile.am</span><br><span>+++ b/include/osmocom/msc/Makefile.am</span><br><span>@@ -1,8 +1,6 @@</span><br><span> noinst_HEADERS = \</span><br><span> a_iface.h \</span><br><span> a_iface_bssap.h \</span><br><span style="color: hsl(0, 100%, 40%);">- common.h \</span><br><span style="color: hsl(0, 100%, 40%);">- common_cs.h \</span><br><span> db.h \</span><br><span> debug.h \</span><br><span> gsm_04_08.h \</span><br><span>@@ -18,10 +16,10 @@</span><br><span> iu_dummy.h \</span><br><span> mncc.h \</span><br><span> mncc_int.h \</span><br><span style="color: hsl(120, 100%, 40%);">+ msc_common.h \</span><br><span> msc_ifaces.h \</span><br><span> msc_mgcp.h \</span><br><span> a_reset.h \</span><br><span style="color: hsl(0, 100%, 40%);">- osmo_msc.h \</span><br><span> ran_conn.h \</span><br><span> rrlp.h \</span><br><span> signal.h \</span><br><span>diff --git a/include/osmocom/msc/common.h b/include/osmocom/msc/common.h</span><br><span>deleted file mode 100644</span><br><span>index d91b3d3..0000000</span><br><span>--- a/include/osmocom/msc/common.h</span><br><span>+++ /dev/null</span><br><span>@@ -1,6 +0,0 @@</span><br><span style="color: hsl(0, 100%, 40%);">-#pragma once</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-enum nsap_addr_enc {</span><br><span style="color: hsl(0, 100%, 40%);">- NSAP_ADDR_ENC_X213,</span><br><span style="color: hsl(0, 100%, 40%);">- NSAP_ADDR_ENC_V4RAW,</span><br><span style="color: hsl(0, 100%, 40%);">-};</span><br><span>diff --git a/include/osmocom/msc/common_cs.h b/include/osmocom/msc/common_cs.h</span><br><span>deleted file mode 100644</span><br><span>index 097d3b1..0000000</span><br><span>--- a/include/osmocom/msc/common_cs.h</span><br><span>+++ /dev/null</span><br><span>@@ -1,10 +0,0 @@</span><br><span style="color: hsl(0, 100%, 40%);">-#pragma once</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-#include <stdint.h></span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-struct msgb;</span><br><span style="color: hsl(0, 100%, 40%);">-struct gsm_network;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-typedef int (*mncc_recv_cb_t)(struct gsm_network *, struct msgb *);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-struct gsm_network *gsm_network_init(void *ctx, mncc_recv_cb_t mncc_recv);</span><br><span>diff --git a/include/osmocom/msc/gsm_data.h b/include/osmocom/msc/gsm_data.h</span><br><span>index 35ec752..3ffa100 100644</span><br><span>--- a/include/osmocom/msc/gsm_data.h</span><br><span>+++ b/include/osmocom/msc/gsm_data.h</span><br><span>@@ -13,10 +13,10 @@</span><br><span> #include <osmocom/gsm/gsm48.h></span><br><span> #include <osmocom/crypt/auth.h></span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/common.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/common_cs.h></span><br><span> #include <osmocom/mgcp_client/mgcp_client.h></span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/msc/msc_common.h></span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> #include "gsm_data_shared.h"</span><br><span> </span><br><span> /* TS 48.008 DLCI containing DCCH/ACCH + SAPI */</span><br><span>diff --git a/include/osmocom/msc/gsm_data_shared.h b/include/osmocom/msc/gsm_data_shared.h</span><br><span>index f71e92b..732607b 100644</span><br><span>--- a/include/osmocom/msc/gsm_data_shared.h</span><br><span>+++ b/include/osmocom/msc/gsm_data_shared.h</span><br><span>@@ -12,8 +12,6 @@</span><br><span> #include <osmocom/gsm/tlv.h></span><br><span> #include <osmocom/gsm/protocol/gsm_04_08.h></span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/common_cs.h></span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> struct osmo_bsc_data;</span><br><span> </span><br><span> struct osmo_bsc_sccp_con;</span><br><span>diff --git a/include/osmocom/msc/msc_common.h b/include/osmocom/msc/msc_common.h</span><br><span>new file mode 100644</span><br><span>index 0000000..ffe8902</span><br><span>--- /dev/null</span><br><span>+++ b/include/osmocom/msc/msc_common.h</span><br><span>@@ -0,0 +1,22 @@</span><br><span style="color: hsl(120, 100%, 40%);">+#pragma once</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+struct msgb;</span><br><span style="color: hsl(120, 100%, 40%);">+struct gsm_network;</span><br><span style="color: hsl(120, 100%, 40%);">+struct vlr_subscr;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#define MSC_HLR_REMOTE_IP_DEFAULT "127.0.0.1"</span><br><span style="color: hsl(120, 100%, 40%);">+#define MSC_HLR_REMOTE_PORT_DEFAULT OSMO_GSUP_PORT</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+enum nsap_addr_enc {</span><br><span style="color: hsl(120, 100%, 40%);">+ NSAP_ADDR_ENC_X213,</span><br><span style="color: hsl(120, 100%, 40%);">+ NSAP_ADDR_ENC_V4RAW,</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+typedef int (*mncc_recv_cb_t)(struct gsm_network *, struct msgb *);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+struct gsm_network *gsm_network_init(void *ctx, mncc_recv_cb_t mncc_recv);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+int msc_vlr_alloc(struct gsm_network *net);</span><br><span style="color: hsl(120, 100%, 40%);">+int msc_vlr_start(struct gsm_network *net);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+void msc_stop_paging(struct vlr_subscr *vsub);</span><br><span>diff --git a/include/osmocom/msc/osmo_msc.h b/include/osmocom/msc/osmo_msc.h</span><br><span>deleted file mode 100644</span><br><span>index 1512017..0000000</span><br><span>--- a/include/osmocom/msc/osmo_msc.h</span><br><span>+++ /dev/null</span><br><span>@@ -1,14 +0,0 @@</span><br><span style="color: hsl(0, 100%, 40%);">-#pragma once</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-/* Routines for the MSC handling */</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-struct gsm_network;</span><br><span style="color: hsl(0, 100%, 40%);">-struct vlr_subscr;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-#define MSC_HLR_REMOTE_IP_DEFAULT "127.0.0.1"</span><br><span style="color: hsl(0, 100%, 40%);">-#define MSC_HLR_REMOTE_PORT_DEFAULT OSMO_GSUP_PORT</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-int msc_vlr_alloc(struct gsm_network *net);</span><br><span style="color: hsl(0, 100%, 40%);">-int msc_vlr_start(struct gsm_network *net);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-void msc_stop_paging(struct vlr_subscr *vsub);</span><br><span>diff --git a/src/libmsc/a_iface.c b/src/libmsc/a_iface.c</span><br><span>index 82519d6..66644ee 100644</span><br><span>--- a/src/libmsc/a_iface.c</span><br><span>+++ b/src/libmsc/a_iface.c</span><br><span>@@ -39,7 +39,6 @@</span><br><span> #include <osmocom/core/byteswap.h></span><br><span> #include <osmocom/sccp/sccp_types.h></span><br><span> #include <osmocom/msc/a_reset.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/osmo_msc.h></span><br><span> #include <osmocom/msc/vlr.h></span><br><span> </span><br><span> #include <errno.h></span><br><span>diff --git a/src/libmsc/a_iface_bssap.c b/src/libmsc/a_iface_bssap.c</span><br><span>index 4d03d23..a10bd42 100644</span><br><span>--- a/src/libmsc/a_iface_bssap.c</span><br><span>+++ b/src/libmsc/a_iface_bssap.c</span><br><span>@@ -31,7 +31,6 @@</span><br><span> #include <osmocom/msc/gsm_data.h></span><br><span> #include <osmocom/msc/a_iface_bssap.h></span><br><span> #include <osmocom/msc/a_iface.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/osmo_msc.h></span><br><span> #include <osmocom/core/byteswap.h></span><br><span> #include <osmocom/msc/a_reset.h></span><br><span> #include <osmocom/msc/transaction.h></span><br><span>diff --git a/src/libmsc/a_reset.c b/src/libmsc/a_reset.c</span><br><span>index 1e35a10..d6d4a1c 100644</span><br><span>--- a/src/libmsc/a_reset.c</span><br><span>+++ b/src/libmsc/a_reset.c</span><br><span>@@ -27,6 +27,7 @@</span><br><span> #include <string.h></span><br><span> #include <osmocom/msc/debug.h></span><br><span> #include <osmocom/msc/a_reset.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/msc/msc_common.h></span><br><span> </span><br><span> #define RESET_RESEND_INTERVAL 2 /* sec */</span><br><span> #define RESET_RESEND_TIMER_NO 16 /* See also 3GPP TS 48.008 Chapter 3.1.4.1.3.2 */</span><br><span>diff --git a/src/libmsc/gsm_04_08.c b/src/libmsc/gsm_04_08.c</span><br><span>index 97a632b..38376d0 100644</span><br><span>--- a/src/libmsc/gsm_04_08.c</span><br><span>+++ b/src/libmsc/gsm_04_08.c</span><br><span>@@ -46,7 +46,6 @@</span><br><span> #include <osmocom/msc/signal.h></span><br><span> #include <osmocom/msc/transaction.h></span><br><span> #include <osmocom/msc/silent_call.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/osmo_msc.h></span><br><span> #include <osmocom/msc/mncc_int.h></span><br><span> #include <osmocom/abis/e1_input.h></span><br><span> #include <osmocom/core/bitvec.h></span><br><span>diff --git a/src/libmsc/gsm_04_08_cc.c b/src/libmsc/gsm_04_08_cc.c</span><br><span>index 8ac87c1..a172b47 100644</span><br><span>--- a/src/libmsc/gsm_04_08_cc.c</span><br><span>+++ b/src/libmsc/gsm_04_08_cc.c</span><br><span>@@ -44,7 +44,6 @@</span><br><span> #include <osmocom/msc/signal.h></span><br><span> #include <osmocom/msc/transaction.h></span><br><span> #include <osmocom/msc/silent_call.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/osmo_msc.h></span><br><span> #include <osmocom/msc/mncc_int.h></span><br><span> #include <osmocom/abis/e1_input.h></span><br><span> #include <osmocom/core/bitvec.h></span><br><span>diff --git a/src/libmsc/gsm_04_11.c b/src/libmsc/gsm_04_11.c</span><br><span>index d012443..62f3bba 100644</span><br><span>--- a/src/libmsc/gsm_04_11.c</span><br><span>+++ b/src/libmsc/gsm_04_11.c</span><br><span>@@ -52,7 +52,6 @@</span><br><span> #include <osmocom/msc/db.h></span><br><span> #include <osmocom/msc/transaction.h></span><br><span> #include <osmocom/msc/msc_ifaces.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/osmo_msc.h></span><br><span> #include <osmocom/msc/vlr.h></span><br><span> </span><br><span> #ifdef BUILD_SMPP</span><br><span>diff --git a/src/libmsc/gsm_09_11.c b/src/libmsc/gsm_09_11.c</span><br><span>index c0a0bdd..43bf48c 100644</span><br><span>--- a/src/libmsc/gsm_09_11.c</span><br><span>+++ b/src/libmsc/gsm_09_11.c</span><br><span>@@ -42,7 +42,6 @@</span><br><span> #include <osmocom/msc/gsm_04_80.h></span><br><span> #include <osmocom/msc/gsm_subscriber.h></span><br><span> #include <osmocom/msc/debug.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/osmo_msc.h></span><br><span> #include <osmocom/msc/vlr.h></span><br><span> #include <osmocom/msc/gsm_04_08.h></span><br><span> #include <osmocom/msc/transaction.h></span><br><span>diff --git a/src/libmsc/gsm_subscriber.c b/src/libmsc/gsm_subscriber.c</span><br><span>index a5bf745..c3b8a95 100644</span><br><span>--- a/src/libmsc/gsm_subscriber.c</span><br><span>+++ b/src/libmsc/gsm_subscriber.c</span><br><span>@@ -46,7 +46,6 @@</span><br><span> #include <osmocom/msc/signal.h></span><br><span> #include <osmocom/msc/db.h></span><br><span> #include <osmocom/msc/vlr.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/osmo_msc.h></span><br><span> #include <osmocom/msc/msc_ifaces.h></span><br><span> #include <osmocom/msc/a_iface.h></span><br><span> </span><br><span>diff --git a/src/libmsc/iucs.c b/src/libmsc/iucs.c</span><br><span>index 1e4ab19..a96b4c2 100644</span><br><span>--- a/src/libmsc/iucs.c</span><br><span>+++ b/src/libmsc/iucs.c</span><br><span>@@ -31,7 +31,6 @@</span><br><span> #include <osmocom/msc/gsm_data.h></span><br><span> #include <osmocom/msc/gsm_subscriber.h></span><br><span> #include <osmocom/msc/transaction.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/osmo_msc.h></span><br><span> #include <osmocom/msc/vlr.h></span><br><span> #include <osmocom/core/byteswap.h></span><br><span> </span><br><span>diff --git a/src/libmsc/iucs_ranap.c b/src/libmsc/iucs_ranap.c</span><br><span>index a657857..f1221c0 100644</span><br><span>--- a/src/libmsc/iucs_ranap.c</span><br><span>+++ b/src/libmsc/iucs_ranap.c</span><br><span>@@ -37,7 +37,6 @@</span><br><span> #include <osmocom/msc/iucs.h></span><br><span> #include <osmocom/msc/vlr.h></span><br><span> #include <osmocom/msc/iucs_ranap.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/osmo_msc.h></span><br><span> #include <osmocom/msc/msc_mgcp.h></span><br><span> </span><br><span> #include <asn1c/asn1helpers.h></span><br><span>diff --git a/src/libmsc/msc_vty.c b/src/libmsc/msc_vty.c</span><br><span>index 589eca0..b632117 100644</span><br><span>--- a/src/libmsc/msc_vty.c</span><br><span>+++ b/src/libmsc/msc_vty.c</span><br><span>@@ -43,7 +43,6 @@</span><br><span> #endif</span><br><span> </span><br><span> #include <osmocom/msc/vty.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/osmo_msc.h></span><br><span> #include <osmocom/msc/gsm_data.h></span><br><span> #include <osmocom/msc/gsm_subscriber.h></span><br><span> #include <osmocom/msc/vlr.h></span><br><span>diff --git a/src/libmsc/osmo_msc.c b/src/libmsc/osmo_msc.c</span><br><span>index 45dfd73..52277b7 100644</span><br><span>--- a/src/libmsc/osmo_msc.c</span><br><span>+++ b/src/libmsc/osmo_msc.c</span><br><span>@@ -21,12 +21,10 @@</span><br><span> *</span><br><span> */</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/osmo_msc.h></span><br><span> #include <osmocom/msc/debug.h></span><br><span> #include <osmocom/msc/transaction.h></span><br><span> #include <osmocom/msc/db.h></span><br><span> #include <osmocom/msc/vlr.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/osmo_msc.h></span><br><span> #include <osmocom/msc/a_iface.h></span><br><span> #include <osmocom/msc/gsm_04_08.h></span><br><span> #include <osmocom/msc/gsm_04_11.h></span><br><span>diff --git a/src/libmsc/silent_call.c b/src/libmsc/silent_call.c</span><br><span>index c6c31a0..b4fc154 100644</span><br><span>--- a/src/libmsc/silent_call.c</span><br><span>+++ b/src/libmsc/silent_call.c</span><br><span>@@ -29,7 +29,6 @@</span><br><span> #include <osmocom/msc/debug.h></span><br><span> #include <osmocom/msc/gsm_data.h></span><br><span> #include <osmocom/msc/gsm_subscriber.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/osmo_msc.h></span><br><span> #include <osmocom/msc/vlr.h></span><br><span> </span><br><span> /* paging of the requested subscriber has completed */</span><br><span>diff --git a/src/libmsc/transaction.c b/src/libmsc/transaction.c</span><br><span>index cf12066..47124a0 100644</span><br><span>--- a/src/libmsc/transaction.c</span><br><span>+++ b/src/libmsc/transaction.c</span><br><span>@@ -25,7 +25,6 @@</span><br><span> #include <osmocom/core/talloc.h></span><br><span> #include <osmocom/msc/gsm_04_08.h></span><br><span> #include <osmocom/msc/mncc.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/osmo_msc.h></span><br><span> #include <osmocom/msc/vlr.h></span><br><span> </span><br><span> void *tall_trans_ctx;</span><br><span>diff --git a/src/osmo-msc/msc_main.c b/src/osmo-msc/msc_main.c</span><br><span>index a139046..afab417 100644</span><br><span>--- a/src/osmo-msc/msc_main.c</span><br><span>+++ b/src/osmo-msc/msc_main.c</span><br><span>@@ -46,7 +46,6 @@</span><br><span> #include <osmocom/abis/e1_input.h></span><br><span> #include <osmocom/core/talloc.h></span><br><span> #include <osmocom/msc/signal.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/osmo_msc.h></span><br><span> #include <osmocom/msc/sms_queue.h></span><br><span> #include <osmocom/vty/telnet_interface.h></span><br><span> #include <osmocom/vty/ports.h></span><br><span>diff --git a/tests/msc_vlr/msc_vlr_tests.h b/tests/msc_vlr/msc_vlr_tests.h</span><br><span>index f308a03..f7ff940 100644</span><br><span>--- a/tests/msc_vlr/msc_vlr_tests.h</span><br><span>+++ b/tests/msc_vlr/msc_vlr_tests.h</span><br><span>@@ -27,7 +27,6 @@</span><br><span> #include <stdio.h></span><br><span> </span><br><span> #include <osmocom/msc/gsm_data.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/msc/osmo_msc.h></span><br><span> #include <osmocom/msc/vlr.h></span><br><span> #include <osmocom/msc/mncc.h></span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/12033">change 12033</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12033"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I9e3a587342f8d398fb27354a2f2475f8797cdb28 </div>
<div style="display:none"> Gerrit-Change-Number: 12033 </div>
<div style="display:none"> Gerrit-PatchSet: 7 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: Vadim Yanitskiy <axilirator@gmail.com> </div>