<p>Vadim Yanitskiy <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/11990">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">library/GSUP_Types.ttcn: fix IE order in PROC_SS_ERROR templates<br><br>In general, the order of IEs in a GSUP message doesn't matter.<br>Despite libosmocore's GSUP API encodes IEs in a fixed order,<br>it is capable to decode them in any arbitary order.<br><br>Meanwhile, in the current TTCN-3 definitions (i.e. templates)<br>the order makes a difference, because the 'GSUP_IEs' type is<br>a record, that according to the TTCN-3 documentation represents<br>an *ordered* sequence of elements.<br><br>Let's reorder the IEs of both t{r|s}_GSUP_PROC_SS_ERR templates<br>in a way that is used by the libosmocore's GSUP encoder.<br><br>This correction doesn't affect successful test case executions,<br>because we don't test possible problematic situations yet. But<br>if something went wrong on the HLR side (i.e. SUT), the matching<br>statements wouldn't match the PROC_SS_ERR message correctly<br>and continue to wait until the guard timer is expired.<br><br>Change-Id: I5eb2314f6a9ab0e9fc5e836390414cec6e1a12db<br>---<br>M library/GSUP_Types.ttcn<br>1 file changed, 4 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/library/GSUP_Types.ttcn b/library/GSUP_Types.ttcn</span><br><span>index cadc6d8..6329ebd 100644</span><br><span>--- a/library/GSUP_Types.ttcn</span><br><span>+++ b/library/GSUP_Types.ttcn</span><br><span>@@ -698,9 +698,9 @@</span><br><span>        OSMO_GSUP_MSGT_PROC_SS_ERROR,</span><br><span>        {</span><br><span>            valueof(ts_GSUP_IE_IMSI(imsi)),</span><br><span style="color: hsl(120, 100%, 40%);">+               valueof(ts_GSUP_IE_Cause(cause)),</span><br><span>            valueof(ts_GSUP_IE_SessionId(sid)),</span><br><span style="color: hsl(0, 100%, 40%);">-             valueof(ts_GSUP_IE_SessionState(state)),</span><br><span style="color: hsl(0, 100%, 40%);">-                valueof(ts_GSUP_IE_Cause(cause))</span><br><span style="color: hsl(120, 100%, 40%);">+              valueof(ts_GSUP_IE_SessionState(state))</span><br><span>      }</span><br><span> );</span><br><span> template GSUP_PDU tr_GSUP_PROC_SS_ERR(</span><br><span>@@ -712,9 +712,9 @@</span><br><span>      OSMO_GSUP_MSGT_PROC_SS_ERROR,</span><br><span>        {</span><br><span>            tr_GSUP_IE_IMSI(imsi),</span><br><span style="color: hsl(120, 100%, 40%);">+                tr_GSUP_IE_Cause(cause),</span><br><span>             tr_GSUP_IE_SessionId(sid),</span><br><span style="color: hsl(0, 100%, 40%);">-              tr_GSUP_IE_SessionState(state),</span><br><span style="color: hsl(0, 100%, 40%);">-         tr_GSUP_IE_Cause(cause)</span><br><span style="color: hsl(120, 100%, 40%);">+               tr_GSUP_IE_SessionState(state)</span><br><span>       }</span><br><span> );</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11990">change 11990</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11990"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I5eb2314f6a9ab0e9fc5e836390414cec6e1a12db </div>
<div style="display:none"> Gerrit-Change-Number: 11990 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>