<p>Neels Hofmeyr <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/11942">View Change</a></p><div style="white-space:pre-wrap"></div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">follow-up: logging tweak for Immediate Assignment<br><br>follow-up to I9ad094d272254d7aee9b0a676201d4ed8cd727ca because it was merged<br>before fixeria's code review could be incorporated.<br><br>Change-Id: I474cf1a58d1f00ec5b0ae52bd095a60aad763975<br>---<br>M src/osmo-bsc/lchan_fsm.c<br>1 file changed, 4 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c</span><br><span>index 5e99239..742836c 100644</span><br><span>--- a/src/osmo-bsc/lchan_fsm.c</span><br><span>+++ b/src/osmo-bsc/lchan_fsm.c</span><br><span>@@ -97,17 +97,15 @@</span><br><span>       switch (activ_for) {</span><br><span> </span><br><span>     case FOR_MS_CHANNEL_REQUEST:</span><br><span style="color: hsl(0, 100%, 40%);">-            if (lchan->activate.immediate_assignment_sent) {</span><br><span style="color: hsl(0, 100%, 40%);">-                     LOG_LCHAN(lchan, LOGL_ERROR,</span><br><span style="color: hsl(0, 100%, 40%);">-                              "lchan activation failed, after Immediate Assignment message was sent (%s)\n",</span><br><span style="color: hsl(0, 100%, 40%);">-                                lchan->last_error ? : "unknown error");</span><br><span style="color: hsl(0, 100%, 40%);">-                  /* Likely the MS never showed up. Just tear down the lchan. */</span><br><span style="color: hsl(0, 100%, 40%);">-          } else {</span><br><span style="color: hsl(120, 100%, 40%);">+              if (!lchan->activate.immediate_assignment_sent) {</span><br><span>                         /* Failure before Immediate Assignment message, send a reject. */</span><br><span>                    LOG_LCHAN(lchan, LOGL_NOTICE, "Tx Immediate Assignment Reject (%s)\n",</span><br><span>                               lchan->last_error ? : "unknown error");</span><br><span>                       rsl_tx_imm_ass_rej(lchan->ts->trx->bts, lchan->rqd_ref);</span><br><span>                 }</span><br><span style="color: hsl(120, 100%, 40%);">+             /* Otherwise, likely the MS never showed up after the Assignment, and the failure cause</span><br><span style="color: hsl(120, 100%, 40%);">+                * (Timeout?) was already logged elsewhere. Just continue to tear down the lchan after</span><br><span style="color: hsl(120, 100%, 40%);">+                 * lchan_on_activation_failure(), no additional action or logging needed. */</span><br><span>                 break;</span><br><span> </span><br><span>   case FOR_ASSIGNMENT:</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11942">change 11942</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11942"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I474cf1a58d1f00ec5b0ae52bd095a60aad763975 </div>
<div style="display:none"> Gerrit-Change-Number: 11942 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>