<p>dexter has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/12041">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">fix<br><br>Change-Id: I8fd675a2e0e83a3382aae8cdbf174d42d4958d08<br>---<br>M include/osmocom/gsm/gsm0808.h<br>M src/gsm/gsm0808.c<br>2 files changed, 14 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/41/12041/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/gsm/gsm0808.h b/include/osmocom/gsm/gsm0808.h</span><br><span>index 005ed0c..f22019b 100644</span><br><span>--- a/include/osmocom/gsm/gsm0808.h</span><br><span>+++ b/include/osmocom/gsm/gsm0808.h</span><br><span>@@ -171,7 +171,7 @@</span><br><span> </span><br><span> struct gsm0808_handover_performed {</span><br><span> uint16_t cause;</span><br><span style="color: hsl(0, 100%, 40%);">- struct gsm0808_cell_id cell;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct gsm0808_cell_id cell_id;</span><br><span> </span><br><span> bool chosen_channel_present;</span><br><span> uint8_t chosen_channel;</span><br><span>@@ -184,6 +184,12 @@</span><br><span> </span><br><span> bool speech_codec_chosen_present;</span><br><span> struct gsm0808_speech_codec speech_codec_chosen;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ bool lcls_bss_status_present;</span><br><span style="color: hsl(120, 100%, 40%);">+ enum gsm0808_lcls_status lcls_bss_status;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* more items are defined in the spec and may be added later */</span><br><span style="color: hsl(120, 100%, 40%);">+ bool more_items; /*< always set this to false */</span><br><span> };</span><br><span> struct msgb *gsm0808_create_handover_performed(const struct gsm0808_handover_performed *params);</span><br><span> </span><br><span>diff --git a/src/gsm/gsm0808.c b/src/gsm/gsm0808.c</span><br><span>index 96d4d3a..04d786e 100644</span><br><span>--- a/src/gsm/gsm0808.c</span><br><span>+++ b/src/gsm/gsm0808.c</span><br><span>@@ -910,10 +910,10 @@</span><br><span> msgb_v_put(msg, BSS_MAP_MSG_HANDOVER_PERFORMED);</span><br><span> </span><br><span> /* Cause, 3.2.2.5 */</span><br><span style="color: hsl(0, 100%, 40%);">- msgb_tlv_put(msg, GSM0808_IE_CAUSE, params->cause & 0x80 ? 2 : 1, (const uint8_t *)¶ms->cause);</span><br><span style="color: hsl(120, 100%, 40%);">+ msgb_tlv_put(msg, GSM0808_IE_CAUSE, gsm0808_cause_ext(params->cause) ? 2 : 1, (const uint8_t *)¶ms->cause);</span><br><span> </span><br><span> /* Cell Identifier, 3.2.2.17 */</span><br><span style="color: hsl(0, 100%, 40%);">- gsm0808_enc_cell_id(msg, ¶ms->cell);</span><br><span style="color: hsl(120, 100%, 40%);">+ gsm0808_enc_cell_id(msg, ¶ms->cell_id);</span><br><span> </span><br><span> /* Chosen Channel 3.2.2.33 */</span><br><span> if (params->chosen_channel_present)</span><br><span>@@ -923,7 +923,7 @@</span><br><span> if (params->chosen_encr_alg_present)</span><br><span> msgb_tv_put(msg, GSM0808_IE_CHOSEN_ENCR_ALG, params->chosen_encr_alg);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* Sspeech Version (chosen) 3.2.2.51 */</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Speech Version (chosen) 3.2.2.51 */</span><br><span> if (params->speech_version_chosen_present)</span><br><span> msgb_tv_put(msg, GSM0808_IE_SPEECH_VERSION, params->speech_version_chosen);</span><br><span> </span><br><span>@@ -931,6 +931,10 @@</span><br><span> if (params->speech_codec_chosen_present)</span><br><span> gsm0808_enc_speech_codec(msg, ¶ms->speech_codec_chosen);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ /* LCLS-BSS-Status 3.2.2.119 */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (params->lcls_bss_status_present)</span><br><span style="color: hsl(120, 100%, 40%);">+ msgb_tv_put(msg, GSM0808_IE_LCLS_BSS_STATUS, params->lcls_bss_status);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* prepend header with final length */</span><br><span> msg->l3h = msgb_tv_push(msg, BSSAP_MSG_BSS_MANAGEMENT, msgb_length(msg));</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/12041">change 12041</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12041"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I8fd675a2e0e83a3382aae8cdbf174d42d4958d08 </div>
<div style="display:none"> Gerrit-Change-Number: 12041 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>