<p>Vadim Yanitskiy <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/12043">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">libmsc/gsm_04_11.c: fix: always use SAPI 3 for MT SMS<br><br>In I4a07ece80d8dd40b23da6bb1ffc9d3d745b54092 I've introduced a<br>regression. According to GSM TS 04.11, section 2.3, SAPI 3 shall<br>be used for both MO/MT SMS transmissions. Due to a mistake,<br>caused by misunderstanding of the meaning of trans->dlci, SAPI 3<br>was not assigned to SM transactions if there is already an active<br>RAN connection with subscriber. Let's fix this.<br><br>Let's also drop this misleading comment:<br><br>  /* FIXME: specify SACCH in case we already have active TCH */<br><br>because it's a task of the BSC/BTS to decide which lchan to use.<br><br>Change-Id: I08d0801a89d377441e95fb8e3dd27c8d587f89e9<br>Related: OS#3716<br>---<br>M src/libmsc/gsm_04_11.c<br>1 file changed, 3 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libmsc/gsm_04_11.c b/src/libmsc/gsm_04_11.c</span><br><span>index 88dc433..b602344 100644</span><br><span>--- a/src/libmsc/gsm_04_11.c</span><br><span>+++ b/src/libmsc/gsm_04_11.c</span><br><span>@@ -149,8 +149,6 @@</span><br><span>     case GSM_PAGING_SUCCEEDED:</span><br><span>           /* Associate transaction with established connection */</span><br><span>              trans->conn = msc_subscr_conn_get(conn, MSC_CONN_USE_TRANS_SMS);</span><br><span style="color: hsl(0, 100%, 40%);">-             /* FIXME: specify SACCH in case we already have active TCH */</span><br><span style="color: hsl(0, 100%, 40%);">-           trans->dlci = 0x03;</span><br><span>               /* Confirm successful connection establishment */</span><br><span>            gsm411_smc_recv(&trans->sms.smc_inst,</span><br><span>                         GSM411_MMSMS_EST_CNF, NULL, 0);</span><br><span>@@ -1017,6 +1015,9 @@</span><br><span>              trans->sms.sm_rp_mr = conn->next_rp_ref++;</span><br><span>     }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ /* Use SAPI 3 (see GSM 04.11, section 2.3) */</span><br><span style="color: hsl(120, 100%, 40%);">+ trans->dlci = UM_SAPI_SMS;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>      return trans;</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/12043">change 12043</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12043"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I08d0801a89d377441e95fb8e3dd27c8d587f89e9 </div>
<div style="display:none"> Gerrit-Change-Number: 12043 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>