<p>Neels Hofmeyr has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/12025">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">drop unused SUBSCR_CONN_E_INVALID<br><br>The idea to catch uninitialized vars was completely moot. We pass events by<br>constants anyway.<br><br>Change-Id: I6f3c964ee04fec9a96f385199fb3141ac8d672d4<br>---<br>M include/osmocom/msc/osmo_msc.h<br>M src/libmsc/subscr_conn.c<br>2 files changed, 0 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/25/12025/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/msc/osmo_msc.h b/include/osmocom/msc/osmo_msc.h</span><br><span>index a757a99..ad81da5 100644</span><br><span>--- a/include/osmocom/msc/osmo_msc.h</span><br><span>+++ b/include/osmocom/msc/osmo_msc.h</span><br><span>@@ -12,8 +12,6 @@</span><br><span> #define MSC_HLR_REMOTE_PORT_DEFAULT OSMO_GSUP_PORT</span><br><span> </span><br><span> enum subscr_conn_fsm_event {</span><br><span style="color: hsl(0, 100%, 40%);">- /* Mark 0 as invalid to catch uninitialized vars */</span><br><span style="color: hsl(0, 100%, 40%);">-     SUBSCR_CONN_E_INVALID = 0,</span><br><span>   /* Accepted the initial Complete Layer 3 (starting to evaluate Authentication and Ciphering) */</span><br><span>      SUBSCR_CONN_E_COMPLETE_LAYER_3,</span><br><span>      /* Received Classmark Update, typically neede for Ciphering Mode Command */</span><br><span>diff --git a/src/libmsc/subscr_conn.c b/src/libmsc/subscr_conn.c</span><br><span>index e6fa7e1..78af274 100644</span><br><span>--- a/src/libmsc/subscr_conn.c</span><br><span>+++ b/src/libmsc/subscr_conn.c</span><br><span>@@ -43,7 +43,6 @@</span><br><span> #define SUBSCR_CONN_TIMEOUT 5 /* seconds */</span><br><span> </span><br><span> static const struct value_string subscr_conn_fsm_event_names[] = {</span><br><span style="color: hsl(0, 100%, 40%);">-   OSMO_VALUE_STRING(SUBSCR_CONN_E_INVALID),</span><br><span>    OSMO_VALUE_STRING(SUBSCR_CONN_E_COMPLETE_LAYER_3),</span><br><span>   OSMO_VALUE_STRING(SUBSCR_CONN_E_CLASSMARK_UPDATE),</span><br><span>   OSMO_VALUE_STRING(SUBSCR_CONN_E_ACCEPTED),</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/12025">change 12025</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/12025"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I6f3c964ee04fec9a96f385199fb3141ac8d672d4 </div>
<div style="display:none"> Gerrit-Change-Number: 12025 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>