<p>Pau Espin Pedrol <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/11978">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bsc: ts_as_pchan_for_each_lchan: reorder and improve documentation<br><br>It is moved prior to its user in the header file.<br><br>Change-Id: I59f52401ba37b351ba3848e8e9ffb3b24c259496<br>---<br>M include/osmocom/bsc/gsm_data.h<br>1 file changed, 12 insertions(+), 9 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h</span><br><span>index 15158cd..4a8b7be 100644</span><br><span>--- a/include/osmocom/bsc/gsm_data.h</span><br><span>+++ b/include/osmocom/bsc/gsm_data.h</span><br><span>@@ -455,6 +455,18 @@</span><br><span>             bsc_subscr_name(lchan && lchan->conn ? lchan->conn->bsub : NULL), \</span><br><span>         ## args)</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* Iterate lchans that have an FSM allocated based based on explicit pchan kind</span><br><span style="color: hsl(120, 100%, 40%);">+ * (GSM_PCHAN_* constant).</span><br><span style="color: hsl(120, 100%, 40%);">+ * Remark: PDCH related lchans are not handled in BSC but in PCU, so trying to</span><br><span style="color: hsl(120, 100%, 40%);">+ *        iterate through GSM_PCHAN_PDCH is considered a void loop.</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+#define ts_as_pchan_for_each_lchan(lchan, ts, as_pchan) \</span><br><span style="color: hsl(120, 100%, 40%);">+   for (lchan = (ts)->lchan; \</span><br><span style="color: hsl(120, 100%, 40%);">+             ((lchan - (ts)->lchan) < ARRAY_SIZE((ts)->lchan)) \</span><br><span style="color: hsl(120, 100%, 40%);">+          && lchan->fi \</span><br><span style="color: hsl(120, 100%, 40%);">+             && lchan->nr < pchan_subslots(as_pchan); \</span><br><span style="color: hsl(120, 100%, 40%);">+      lchan++)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* usage:</span><br><span>  * struct gsm_lchan *lchan;</span><br><span>  * struct gsm_bts_trx_ts *ts = get_some_timeslot();</span><br><span>@@ -464,15 +476,6 @@</span><br><span>  * Iterate only those lchans that have an FSM allocated. */</span><br><span> #define ts_for_each_lchan(lchan, ts) ts_as_pchan_for_each_lchan(lchan, ts, (ts)->pchan_is)</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* Same as ts_for_each_lchan() but with an explicit pchan kind (GSM_PCHAN_* constant).</span><br><span style="color: hsl(0, 100%, 40%);">- * Iterate only those lchans that have an FSM allocated. */</span><br><span style="color: hsl(0, 100%, 40%);">-#define ts_as_pchan_for_each_lchan(lchan, ts, as_pchan) \</span><br><span style="color: hsl(0, 100%, 40%);">- for (lchan = (ts)->lchan; \</span><br><span style="color: hsl(0, 100%, 40%);">-       ((lchan - (ts)->lchan) < ARRAY_SIZE((ts)->lchan)) \</span><br><span style="color: hsl(0, 100%, 40%);">-            && lchan->fi \</span><br><span style="color: hsl(0, 100%, 40%);">-       && lchan->nr < pchan_subslots(as_pchan); \</span><br><span style="color: hsl(0, 100%, 40%);">-        lchan++)</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> enum lchan_activate_mode {</span><br><span>  FOR_NONE,</span><br><span>    FOR_MS_CHANNEL_REQUEST,</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11978">change 11978</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11978"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I59f52401ba37b351ba3848e8e9ffb3b24c259496 </div>
<div style="display:none"> Gerrit-Change-Number: 11978 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>