<p>Vadim Yanitskiy has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/11984">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">library/GSUP_Types.ttcn: fix missing session state IE in PROC_SS_ERR<br><br>Change-Id: I44070396ce7119eab4608d9f9fb090bb223dfaa2<br>---<br>M hlr/HLR_Tests.ttcn<br>M library/GSUP_Types.ttcn<br>2 files changed, 8 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/84/11984/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/hlr/HLR_Tests.ttcn b/hlr/HLR_Tests.ttcn</span><br><span>index f7902be..e32fa68 100644</span><br><span>--- a/hlr/HLR_Tests.ttcn</span><br><span>+++ b/hlr/HLR_Tests.ttcn</span><br><span>@@ -476,16 +476,16 @@</span><br><span>      GSUP.send(valueof(ts_GSUP_PROC_SS_REQ(imsi, sid, state, ss)));</span><br><span>       T.start;</span><br><span>     alt {</span><br><span style="color: hsl(0, 100%, 40%);">-   [exp_fail] GSUP.receive(tr_GSUP_PROC_SS_ERR(imsi, sid, exp_err_cause)) -> value ret {</span><br><span style="color: hsl(120, 100%, 40%);">+      [exp_fail] GSUP.receive(tr_GSUP_PROC_SS_ERR(imsi, sid, ?, exp_err_cause)) -> value ret {</span><br><span>          setverdict(pass);</span><br><span>            }</span><br><span style="color: hsl(0, 100%, 40%);">-       [exp_fail] GSUP.receive(tr_GSUP_PROC_SS_ERR(imsi, sid, ?)) -> value ret {</span><br><span style="color: hsl(120, 100%, 40%);">+  [exp_fail] GSUP.receive(tr_GSUP_PROC_SS_ERR(imsi, sid, ?, ?)) -> value ret {</span><br><span>              setverdict(fail, "Unexpected PROC_SS ERROR Cause");</span><br><span>                }</span><br><span>    [exp_fail] GSUP.receive(tr_GSUP_PROC_SS_RES(imsi, sid, ?, ?)) -> value ret {</span><br><span>              setverdict(fail, "Unexpected PROC_SS.res for unknown IMSI");</span><br><span>               }</span><br><span style="color: hsl(0, 100%, 40%);">-       [not exp_fail] GSUP.receive(tr_GSUP_PROC_SS_ERR(imsi, sid, ?)) -> value ret {</span><br><span style="color: hsl(120, 100%, 40%);">+      [not exp_fail] GSUP.receive(tr_GSUP_PROC_SS_ERR(imsi, sid, ?, ?)) -> value ret {</span><br><span>          setverdict(fail, "Unexpected PROC_SS ERROR");</span><br><span>              }</span><br><span>    [not exp_fail] GSUP.receive(tr_GSUP_PROC_SS_RES(imsi, sid, ?, ?)) -> value ret {</span><br><span>@@ -511,7 +511,7 @@</span><br><span>    }</span><br><span>    T.start;</span><br><span>     alt {</span><br><span style="color: hsl(0, 100%, 40%);">-   [] GSUP.receive(tr_GSUP_PROC_SS_ERR(imsi, sid, ?)) -> value ret {</span><br><span style="color: hsl(120, 100%, 40%);">+  [] GSUP.receive(tr_GSUP_PROC_SS_ERR(imsi, sid, ?, ?)) -> value ret {</span><br><span>              setverdict(fail, "Unexpected PROC_SS ERROR Cause");</span><br><span>                }</span><br><span>    [not exp_ss] GSUP.receive(tr_GSUP_PROC_SS_RES(imsi, sid, state, omit)) -> value ret {</span><br><span>diff --git a/library/GSUP_Types.ttcn b/library/GSUP_Types.ttcn</span><br><span>index 7680815..cadc6d8 100644</span><br><span>--- a/library/GSUP_Types.ttcn</span><br><span>+++ b/library/GSUP_Types.ttcn</span><br><span>@@ -692,24 +692,28 @@</span><br><span> template (value) GSUP_PDU ts_GSUP_PROC_SS_ERR(</span><br><span>  hexstring imsi,</span><br><span>      OCT4 sid,</span><br><span style="color: hsl(120, 100%, 40%);">+     GSUP_SessionState state,</span><br><span>     integer cause</span><br><span> ) := ts_GSUP(</span><br><span>       OSMO_GSUP_MSGT_PROC_SS_ERROR,</span><br><span>        {</span><br><span>            valueof(ts_GSUP_IE_IMSI(imsi)),</span><br><span>              valueof(ts_GSUP_IE_SessionId(sid)),</span><br><span style="color: hsl(120, 100%, 40%);">+           valueof(ts_GSUP_IE_SessionState(state)),</span><br><span>             valueof(ts_GSUP_IE_Cause(cause))</span><br><span>     }</span><br><span> );</span><br><span> template GSUP_PDU tr_GSUP_PROC_SS_ERR(</span><br><span>    template hexstring imsi,</span><br><span>     template OCT4 sid := ?,</span><br><span style="color: hsl(120, 100%, 40%);">+       template GSUP_SessionState state := ?,</span><br><span>       template integer cause := ?</span><br><span> ) := tr_GSUP(</span><br><span>         OSMO_GSUP_MSGT_PROC_SS_ERROR,</span><br><span>        {</span><br><span>            tr_GSUP_IE_IMSI(imsi),</span><br><span>               tr_GSUP_IE_SessionId(sid),</span><br><span style="color: hsl(120, 100%, 40%);">+            tr_GSUP_IE_SessionState(state),</span><br><span>              tr_GSUP_IE_Cause(cause)</span><br><span>      }</span><br><span> );</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11984">change 11984</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11984"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I44070396ce7119eab4608d9f9fb090bb223dfaa2 </div>
<div style="display:none"> Gerrit-Change-Number: 11984 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>