<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/11914">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Pau Espin Pedrol: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">libmsc/gsm_04_11.c: don't pass msgb to gsm411_rx_rp_{ack|error}<br><br>Passing a message buffer containing the whole encoded message, and<br>a pointer to the RP header (struct gsm411_rp_hdr) is redundant.<br><br>Change-Id: I0eb5c7c485ab7d109966431bd875fa74e00936d7<br>---<br>M src/libmsc/gsm_04_11.c<br>1 file changed, 4 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libmsc/gsm_04_11.c b/src/libmsc/gsm_04_11.c</span><br><span>index 52edcd6..4d43b57 100644</span><br><span>--- a/src/libmsc/gsm_04_11.c</span><br><span>+++ b/src/libmsc/gsm_04_11.c</span><br><span>@@ -700,7 +700,7 @@</span><br><span> }</span><br><span> </span><br><span> /* Receive a 04.11 RP-ACK message (response to RP-DATA from us) */</span><br><span style="color: hsl(0, 100%, 40%);">-static int gsm411_rx_rp_ack(struct msgb *msg, struct gsm_trans *trans,</span><br><span style="color: hsl(120, 100%, 40%);">+static int gsm411_rx_rp_ack(struct gsm_trans *trans,</span><br><span>                        struct gsm411_rp_hdr *rph)</span><br><span> {</span><br><span>  struct gsm_sms *sms = trans->sms.sms;</span><br><span>@@ -729,7 +729,7 @@</span><br><span>       return 0;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static int gsm411_rx_rp_error(struct msgb *msg, struct gsm_trans *trans,</span><br><span style="color: hsl(120, 100%, 40%);">+static int gsm411_rx_rp_error(struct gsm_trans *trans,</span><br><span>                         struct gsm411_rp_hdr *rph)</span><br><span> {</span><br><span>        struct gsm_network *net = trans->conn->network;</span><br><span>@@ -824,11 +824,11 @@</span><br><span>        switch (msg_type) {</span><br><span>  case GSM411_MT_RP_ACK_MO:</span><br><span>            DEBUGP(DLSMS, "RX SMS RP-ACK (MO)\n");</span><br><span style="color: hsl(0, 100%, 40%);">-                rc = gsm411_rx_rp_ack(msg, trans, rp_data);</span><br><span style="color: hsl(120, 100%, 40%);">+           rc = gsm411_rx_rp_ack(trans, rp_data);</span><br><span>               break;</span><br><span>       case GSM411_MT_RP_ERROR_MO:</span><br><span>          DEBUGP(DLSMS, "RX SMS RP-ERROR (MO)\n");</span><br><span style="color: hsl(0, 100%, 40%);">-              rc = gsm411_rx_rp_error(msg, trans, rp_data);</span><br><span style="color: hsl(120, 100%, 40%);">+         rc = gsm411_rx_rp_error(trans, rp_data);</span><br><span>             break;</span><br><span>       default:</span><br><span>             LOGP(DLSMS, LOGL_NOTICE, "Invalid RP type 0x%02x\n", msg_type);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11914">change 11914</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11914"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I0eb5c7c485ab7d109966431bd875fa74e00936d7 </div>
<div style="display:none"> Gerrit-Change-Number: 11914 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>