<p>Max has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/11928">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ctrl: introduce constant for TRAP id<br><br>Use it for TRAP message parsing and generation.<br><br>Change-Id: I0381eb60d10e7278b966464add79772a9f7c8118<br>---<br>M osmopy/osmo_ipa.py<br>1 file changed, 3 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/python/osmo-python-tests refs/changes/28/11928/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/osmopy/osmo_ipa.py b/osmopy/osmo_ipa.py</span><br><span>index 246101d..41865c1 100755</span><br><span>--- a/osmopy/osmo_ipa.py</span><br><span>+++ b/osmopy/osmo_ipa.py</span><br><span>@@ -43,6 +43,7 @@</span><br><span>     CTRL_REP = 'REPLY'</span><br><span>     CTRL_ERR = 'ERR'</span><br><span>     CTRL_TRAP = 'TRAP'</span><br><span style="color: hsl(120, 100%, 40%);">+    CTRL_TRAP_ID = 0</span><br><span> </span><br><span>     def _l(self, d, p):</span><br><span>         """</span><br><span>@@ -250,7 +251,7 @@</span><br><span>         if s == self.CTRL_GET + '_' + self.CTRL_REP:</span><br><span>             return i, v, None</span><br><span>         (s, i, var, val) = data.split(' ', 3)</span><br><span style="color: hsl(0, 100%, 40%);">-        if s == self.CTRL_TRAP and i != '0':</span><br><span style="color: hsl(120, 100%, 40%);">+        if s == self.CTRL_TRAP and int(i) != self.CTRL_TRAP_ID:</span><br><span>             return i, None, None</span><br><span>         return i, var, val</span><br><span> </span><br><span>@@ -267,7 +268,7 @@</span><br><span>         """</span><br><span>         Make TRAP message with given (vak, val) pair</span><br><span>         """</span><br><span style="color: hsl(0, 100%, 40%);">-        return self.add_header("%s 0 %s %s" % (self.CTRL_TRAP, var, val))</span><br><span style="color: hsl(120, 100%, 40%);">+        return self.add_header("%s %d %s %s" % (self.CTRL_TRAP, self.CTRL_TRAP_ID, var, val))</span><br><span> </span><br><span>     def cmd(self, var, val=None):</span><br><span>         """</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11928">change 11928</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11928"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: python/osmo-python-tests </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I0381eb60d10e7278b966464add79772a9f7c8118 </div>
<div style="display:none"> Gerrit-Change-Number: 11928 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Max <msuraev@sysmocom.de> </div>