<p><a href="https://gerrit.osmocom.org/11889">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/11889/1/src/gprs/gb_proxy.c">File src/gprs/gb_proxy.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/11889/1/src/gprs/gb_proxy.c@365">Patch Set #1, Line 365:</a> <code style="font-family:monospace,monospace">                                msgb_bvci(msg), link_info->sgsn_nsei);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Do we need to use msg here or could we use msg_bvci(stored_msg)?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/11889/1/src/gprs/gb_proxy.c@371">Patch Set #1, Line 371:</a> <code style="font-family:monospace,monospace">                            msgb_nsei(msg),</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Same here, should we use link_info->sgsn_nsei just to be clear?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/11889">change 11889</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11889"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I7226fc5bcfbf58c349431d0a39cdb904fefd9e9c </div>
<div style="display:none"> Gerrit-Change-Number: 11889 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 26 Nov 2018 10:38:58 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>