<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/11604">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Neels Hofmeyr: Looks good to me, approved
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bsc: Introduce test TC_paging_resp_unsol<br><br>With this test we want to verify that channels are released if BSC fails<br>to complete an L3 request, for instance because no pending Paging<br>CMD is found for a received Paging Response.<br><br>Related: OS#3680<br>Change-Id: Iabe8a51aa13d2fcfec4500cf7aab47d60cc138ce<br>---<br>M bsc/BSC_Tests.ttcn<br>M bsc/expected-results.xml<br>2 files changed, 27 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn</span><br><span>index 9b445f5..a155fef 100644</span><br><span>--- a/bsc/BSC_Tests.ttcn</span><br><span>+++ b/bsc/BSC_Tests.ttcn</span><br><span>@@ -1466,6 +1466,30 @@</span><br><span> f_shutdown_helper();</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* Verify how we handle unsolicited Paging Response, for instance because we</span><br><span style="color: hsl(120, 100%, 40%);">+ * receive a Paging Response after T3113 expired (and subscriber information was</span><br><span style="color: hsl(120, 100%, 40%);">+ * dropped). See OS#3680.</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_paging_resp_unsol() runs on test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init(1);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ var BSSAP_N_CONNECT_ind rx_c_ind;</span><br><span style="color: hsl(120, 100%, 40%);">+ var DchanTuple dt;</span><br><span style="color: hsl(120, 100%, 40%);">+ var PDU_ML3_MS_NW l3 := valueof(ts_PAG_RESP(valueof(ts_MI_IMSI_LV('001010008880018'H))));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Send CHAN RQD and wait for allocation; acknowledge it */</span><br><span style="color: hsl(120, 100%, 40%);">+ dt.rsl_chan_nr := f_chreq_act_ack();</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Send unsolicited Paging response (no matching Paging CMD stored in BSC) */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_ipa_tx(0, ts_RSL_EST_IND(dt.rsl_chan_nr, valueof(ts_RslLinkID_DCCH(0)), enc_PDU_ML3_MS_NW(l3)));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* expect BSC to disable the channel */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_expect_chan_rel(0, dt.rsl_chan_nr);</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(pass);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* Test RSL link drop causes counter increment */</span><br><span> testcase TC_rsl_drop_counter() runs on test_CT {</span><br><span> var integer rsl_fail;</span><br><span>@@ -3407,6 +3431,7 @@</span><br><span> execute( TC_paging_imsi_a_reset() );</span><br><span> execute( TC_paging_imsi_load() );</span><br><span> execute( TC_paging_counter() );</span><br><span style="color: hsl(120, 100%, 40%);">+ execute( TC_paging_resp_unsol() );</span><br><span> </span><br><span> execute( TC_rsl_drop_counter() );</span><br><span> execute( TC_rsl_unknown_unit_id() );</span><br><span>diff --git a/bsc/expected-results.xml b/bsc/expected-results.xml</span><br><span>index ff50990..d558e72 100644</span><br><span>--- a/bsc/expected-results.xml</span><br><span>+++ b/bsc/expected-results.xml</span><br><span>@@ -1,5 +1,5 @@</span><br><span> <?xml version="1.0"?></span><br><span style="color: hsl(0, 100%, 40%);">-<testsuite name='BSC_Tests' tests='94' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'></span><br><span style="color: hsl(120, 100%, 40%);">+<testsuite name='BSC_Tests' tests='95' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'></span><br><span> <testcase classname='BSC_Tests' name='TC_ctrl_msc_connection_status' time='MASKED'/></span><br><span> <testcase classname='BSC_Tests' name='TC_ctrl_msc0_connection_status' time='MASKED'/></span><br><span> <testcase classname='BSC_Tests' name='TC_ctrl' time='MASKED'/></span><br><span>@@ -59,6 +59,7 @@</span><br><span> <testcase classname='BSC_Tests' name='TC_paging_imsi_a_reset' time='MASKED'/></span><br><span> <testcase classname='BSC_Tests' name='TC_paging_imsi_load' time='MASKED'/></span><br><span> <testcase classname='BSC_Tests' name='TC_paging_counter' time='MASKED'/></span><br><span style="color: hsl(120, 100%, 40%);">+ <testcase classname='BSC_Tests' name='TC_paging_resp_unsol' time='MASKED'/></span><br><span> <testcase classname='BSC_Tests' name='TC_rsl_drop_counter' time='MASKED'/></span><br><span> <testcase classname='BSC_Tests' name='TC_rsl_unknown_unit_id' time='MASKED'/></span><br><span> <testcase classname='BSC_Tests' name='TC_oml_unknown_unit_id' time='MASKED'/></span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11604">change 11604</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11604"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Iabe8a51aa13d2fcfec4500cf7aab47d60cc138ce </div>
<div style="display:none"> Gerrit-Change-Number: 11604 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>