<p>Pau Espin Pedrol has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/11890">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gbproxy: Remove unneeded parse_ctx param<br><br>The only use inside the function is only to log information which should<br>actually be provided by tmp_parse_ctx of each stored msg.<br><br>Change-Id: Ic186b92fa9bd0a2b853a0cf525c6f6feb9493897<br>---<br>M src/gprs/gb_proxy.c<br>1 file changed, 4 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/90/11890/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gprs/gb_proxy.c b/src/gprs/gb_proxy.c</span><br><span>index 85c3c47..faf4a8b 100644</span><br><span>--- a/src/gprs/gb_proxy.c</span><br><span>+++ b/src/gprs/gb_proxy.c</span><br><span>@@ -324,8 +324,7 @@</span><br><span> static int gbproxy_flush_stored_messages(struct gbproxy_peer *peer,</span><br><span>                                     struct msgb *msg,</span><br><span>                                    time_t now,</span><br><span style="color: hsl(0, 100%, 40%);">-                                     struct gbproxy_link_info* link_info,</span><br><span style="color: hsl(0, 100%, 40%);">-                                    struct gprs_gb_parse_context *parse_ctx)</span><br><span style="color: hsl(120, 100%, 40%);">+                                      struct gbproxy_link_info* link_info)</span><br><span> {</span><br><span>  int rc;</span><br><span>      struct msgb *stored_msg;</span><br><span>@@ -369,8 +368,8 @@</span><br><span>                            "NSEI=%d(BSS) failed to send stored message "</span><br><span>                              "(%s)\n",</span><br><span>                          msgb_nsei(msg),</span><br><span style="color: hsl(0, 100%, 40%);">-                         parse_ctx->llc_msg_name ?</span><br><span style="color: hsl(0, 100%, 40%);">-                            parse_ctx->llc_msg_name : "BSSGP");</span><br><span style="color: hsl(120, 100%, 40%);">+                      tmp_parse_ctx.llc_msg_name ?</span><br><span style="color: hsl(120, 100%, 40%);">+                          tmp_parse_ctx.llc_msg_name : "BSSGP");</span><br><span>                msgb_free(stored_msg);</span><br><span>       }</span><br><span> </span><br><span>@@ -479,8 +478,7 @@</span><br><span>          /* The IMSI is now available. If flushing the messages fails,</span><br><span>                 * then link_info has been deleted and we should return</span><br><span>               * immediately. */</span><br><span style="color: hsl(0, 100%, 40%);">-              if (gbproxy_flush_stored_messages(peer, msg, now, link_info,</span><br><span style="color: hsl(0, 100%, 40%);">-                                          parse_ctx) < 0)</span><br><span style="color: hsl(120, 100%, 40%);">+              if (gbproxy_flush_stored_messages(peer, msg, now, link_info) < 0)</span><br><span>                         return 0;</span><br><span> </span><br><span>                gbproxy_reset_imsi_acquisition(link_info);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11890">change 11890</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11890"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ic186b92fa9bd0a2b853a0cf525c6f6feb9493897 </div>
<div style="display:none"> Gerrit-Change-Number: 11890 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Pau Espin Pedrol <pespin@sysmocom.de> </div>