<p>Vadim Yanitskiy has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/11850">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mobile/app_mobile.c: use LOGP() instead of printf()/fprintf()<br><br>Change-Id: I6af76afbaa34dde5ddfc31a65700030862442dba<br>---<br>M src/host/layer23/src/mobile/app_mobile.c<br>1 file changed, 8 insertions(+), 9 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/50/11850/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/host/layer23/src/mobile/app_mobile.c b/src/host/layer23/src/mobile/app_mobile.c</span><br><span>index af627c6..464cd55 100644</span><br><span>--- a/src/host/layer23/src/mobile/app_mobile.c</span><br><span>+++ b/src/host/layer23/src/mobile/app_mobile.c</span><br><span>@@ -452,20 +452,19 @@</span><br><span>         if (config_file != NULL) {</span><br><span>           rc = vty_read_config_file(config_file, &dummy_conn);</span><br><span>             if (rc < 0) {</span><br><span style="color: hsl(0, 100%, 40%);">-                        fprintf(stderr, "Failed to parse the config file:"</span><br><span style="color: hsl(0, 100%, 40%);">-                                    " '%s'\n", config_file);</span><br><span style="color: hsl(0, 100%, 40%);">-                      fprintf(stderr, "Please check or create config file"</span><br><span style="color: hsl(0, 100%, 40%);">-                                  " using: 'touch %s'\n", config_file);</span><br><span style="color: hsl(0, 100%, 40%);">-                 fprintf(stderr, "or use one from "</span><br><span style="color: hsl(0, 100%, 40%);">-                                    "'doc/examples/mobile/'\n");</span><br><span style="color: hsl(120, 100%, 40%);">+                        LOGP(DMOB, LOGL_FATAL, "Failed to parse the configuration "</span><br><span style="color: hsl(120, 100%, 40%);">+                         "file '%s'\n", config_file);</span><br><span style="color: hsl(120, 100%, 40%);">+                        LOGP(DMOB, LOGL_FATAL, "Please make sure the file "</span><br><span style="color: hsl(120, 100%, 40%);">+                         "'%s' exists, or use an example from "</span><br><span style="color: hsl(120, 100%, 40%);">+                              "'doc/examples/mobile/'\n", config_file);</span><br><span>                  return rc;</span><br><span>           }</span><br><span style="color: hsl(0, 100%, 40%);">-               printf("Using configuration from %s\n", config_file);</span><br><span style="color: hsl(120, 100%, 40%);">+               LOGP(DMOB, LOGL_INFO, "Using configuration from '%s'\n", config_file);</span><br><span>     }</span><br><span>    vty_reading = 0;</span><br><span>     rc = telnet_init_dynif(l23_ctx, NULL, vty_ip, vty_port);</span><br><span>     if (rc < 0) {</span><br><span style="color: hsl(0, 100%, 40%);">-                fprintf(stderr, "Cannot init VTY on %s port %u: %s\n",</span><br><span style="color: hsl(120, 100%, 40%);">+              LOGP(DMOB, LOGL_FATAL, "Cannot init VTY on %s port %u: %s\n",</span><br><span>                      vty_ip, vty_port, strerror(errno));</span><br><span>          return rc;</span><br><span>   }</span><br><span>@@ -477,7 +476,7 @@</span><br><span>      if (llist_empty(&ms_list)) {</span><br><span>             struct osmocom_ms *ms;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-              printf("No Mobile Station defined, creating: MS '1'\n");</span><br><span style="color: hsl(120, 100%, 40%);">+            LOGP(DMOB, LOGL_NOTICE, "No Mobile Station defined, creating: MS '1'\n");</span><br><span>          ms = mobile_new("1");</span><br><span>              if (!ms)</span><br><span>                     return -1;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11850">change 11850</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11850"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmocom-bb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I6af76afbaa34dde5ddfc31a65700030862442dba </div>
<div style="display:none"> Gerrit-Change-Number: 11850 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>