<p>Stefan Sperling has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/11854">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">fix use of partly initialized struct in tcp test<br><br>Properly initialize sockaddr 'name' used by tcp test, and remove<br>a redundant re-declaration of this variable in a nested scope.<br><br>Change-Id: Id6e488308a72be96cca6aa661f088d2c3c67a6a3<br>Related: CID#188848<br>---<br>M test_apps/tcp.c<br>1 file changed, 2 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libsmpp34 refs/changes/54/11854/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/test_apps/tcp.c b/test_apps/tcp.c</span><br><span>index 4e24fa5..4cf681d 100644</span><br><span>--- a/test_apps/tcp.c</span><br><span>+++ b/test_apps/tcp.c</span><br><span>@@ -69,7 +69,7 @@</span><br><span> </span><br><span>     /* bind to a local addr */</span><br><span>     if (strlen(local_src) != 0) {</span><br><span style="color: hsl(0, 100%, 40%);">-        struct sockaddr_in name;</span><br><span style="color: hsl(120, 100%, 40%);">+        memset(&name, 0, sizeof(name));</span><br><span>         name.sin_family = AF_INET;</span><br><span>         name.sin_port = htons(local_port);</span><br><span>         name.sin_addr.s_addr = inet_addr(local_src);</span><br><span>@@ -91,6 +91,7 @@</span><br><span>     };</span><br><span> </span><br><span>     memcpy(&addr.s_addr, _host.h_addr_list[0], sizeof(struct in_addr));</span><br><span style="color: hsl(120, 100%, 40%);">+    memset(&name, 0, sizeof(name));</span><br><span>     name.sin_family = AF_INET;</span><br><span>     name.sin_port = htons( port );</span><br><span>     name.sin_addr = addr;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11854">change 11854</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11854"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libsmpp34 </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Id6e488308a72be96cca6aa661f088d2c3c67a6a3 </div>
<div style="display:none"> Gerrit-Change-Number: 11854 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Stefan Sperling <ssperling@sysmocom.de> </div>