<p>Pau Espin Pedrol <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/11684">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Neels Hofmeyr: Looks good to me, approved
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">abis_nm: Introduce new signal S_NM_GET_ATTR_REP<br><br>This signal can be used for tools willing to request and parse Attribute Response<br>and do something with the information. ipaccess-config tool will use<br>this signal in later patch Change-Id Ida416a969a3309868d6f4e50f34b34f224c32dd6.<br><br>Related: OS#3624<br>Change-Id: I9a121bbfe1b96904d4e16845abc90bb6ef20d2c9<br>---<br>M include/osmocom/bsc/signal.h<br>M src/osmo-bsc/abis_nm.c<br>2 files changed, 8 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/bsc/signal.h b/include/osmocom/bsc/signal.h</span><br><span>index 1b351aa..62a3d2c 100644</span><br><span>--- a/include/osmocom/bsc/signal.h</span><br><span>+++ b/include/osmocom/bsc/signal.h</span><br><span>@@ -72,6 +72,7 @@</span><br><span> S_NM_STATECHG_ADM, /* Administrative State changed */</span><br><span> S_NM_OM2K_CONF_RES, /* OM2K Configuration Result */</span><br><span> S_NM_OPSTART_ACK, /* Received OPSTART ACK, arg is struct msgb *oml_msg */</span><br><span style="color: hsl(120, 100%, 40%);">+ S_NM_GET_ATTR_REP, /* Received Get Attributes Response, arg is struct msgb *oml_msg */</span><br><span> };</span><br><span> </span><br><span> /* SS_LCHAN signals */</span><br><span>diff --git a/src/osmo-bsc/abis_nm.c b/src/osmo-bsc/abis_nm.c</span><br><span>index c1a26ac..f1306fc 100644</span><br><span>--- a/src/osmo-bsc/abis_nm.c</span><br><span>+++ b/src/osmo-bsc/abis_nm.c</span><br><span>@@ -616,6 +616,7 @@</span><br><span> struct e1inp_sign_link *sign_link = mb->dst;</span><br><span> struct gsm_bts *bts = trx ? trx->bts : sign_link->trx->bts;</span><br><span> struct tlv_parsed tp;</span><br><span style="color: hsl(120, 100%, 40%);">+ int rc;</span><br><span> </span><br><span> DEBUGPFOH(DNM, foh, "Get Attributes Response for BTS%u\n", bts->nr);</span><br><span> </span><br><span>@@ -623,9 +624,13 @@</span><br><span> </span><br><span> /* nanoBTS doesn't send Get Attribute Response Info, uses its own format */</span><br><span> if (bts->type != GSM_BTS_TYPE_NANOBTS)</span><br><span style="color: hsl(0, 100%, 40%);">- return parse_attr_resp_info(bts, trx, foh, &tp);</span><br><span style="color: hsl(120, 100%, 40%);">+ rc = parse_attr_resp_info(bts, trx, foh, &tp);</span><br><span> else</span><br><span style="color: hsl(0, 100%, 40%);">- return parse_attr_resp_info_attr(bts, trx, foh, &tp);</span><br><span style="color: hsl(120, 100%, 40%);">+ rc = parse_attr_resp_info_attr(bts, trx, foh, &tp);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_signal_dispatch(SS_NM, S_NM_GET_ATTR_REP, mb);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ return rc;</span><br><span> }</span><br><span> </span><br><span> /* 3GPP TS 52.021 ยง6.2.5 */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11684">change 11684</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11684"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I9a121bbfe1b96904d4e16845abc90bb6ef20d2c9 </div>
<div style="display:none"> Gerrit-Change-Number: 11684 </div>
<div style="display:none"> Gerrit-PatchSet: 6 </div>
<div style="display:none"> Gerrit-Owner: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>