<p>Vadim Yanitskiy <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/11848">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
Max: Looks good to me, but someone else must approve
Pau Espin Pedrol: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Revert "mobile: fix vty bind ip override"<br><br>This reverts commit c8de8cb1e126a18c0269571fba38310589dd9273<br>(Change-Id I32517567847fd5c54b1742f18bf409ff81e316fa by Max),<br>because several problems were introduced, in particular:<br><br> a) Help message of mobile application is broken:<br><br> "The VTY IP to telnet to. (default (null))",<br> "The VTY port number to telnet to. (default 127.0.0.1)".<br><br> b) Default VTY bind addres != parsed from the config file.<br><br> c) The (vty_ip == NULL) is resolved only when an external<br> MNCC handler is used, otherwise NULL is passed to<br> l23_app_init().<br><br>Change-Id: Ic63a4eb828ff32d3744886b4f5f6f5019c798620<br>---<br>M src/host/layer23/src/mobile/main.c<br>1 file changed, 3 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/host/layer23/src/mobile/main.c b/src/host/layer23/src/mobile/main.c</span><br><span>index 297a534..115ac41 100644</span><br><span>--- a/src/host/layer23/src/mobile/main.c</span><br><span>+++ b/src/host/layer23/src/mobile/main.c</span><br><span>@@ -31,7 +31,6 @@</span><br><span> #include <osmocom/core/gsmtap.h></span><br><span> #include <osmocom/core/signal.h></span><br><span> #include <osmocom/core/application.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/vty/vty.h></span><br><span> </span><br><span> #include <arpa/inet.h></span><br><span> </span><br><span>@@ -52,7 +51,7 @@</span><br><span> static char *gsmtap_ip = 0;</span><br><span> static const char *custom_cfg_file = NULL;</span><br><span> struct gsmtap_inst *gsmtap_inst = NULL;</span><br><span style="color: hsl(0, 100%, 40%);">-static char *vty_ip = NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+static char *vty_ip = "127.0.0.1";</span><br><span> unsigned short vty_port = 4247;</span><br><span> char *config_dir = NULL;</span><br><span> int use_mncc_sock = 0;</span><br><span>@@ -91,7 +90,7 @@</span><br><span> printf(" -u --vty-ip The VTY IP to telnet to. "</span><br><span> "(default %s)\n", vty_ip);</span><br><span> printf(" -v --vty-port The VTY port number to telnet to. "</span><br><span style="color: hsl(0, 100%, 40%);">- "(default %s)\n", vty_get_bind_addr());</span><br><span style="color: hsl(120, 100%, 40%);">+ "(default %u)\n", vty_port);</span><br><span> printf(" -d --debug Change debug flags. default: %s\n",</span><br><span> debug_default);</span><br><span> printf(" -D --daemonize Run as daemon\n");</span><br><span>@@ -249,7 +248,7 @@</span><br><span> config_dir = dirname(config_dir);</span><br><span> </span><br><span> if (use_mncc_sock)</span><br><span style="color: hsl(0, 100%, 40%);">- rc = l23_app_init(mncc_recv_socket, config_file, vty_ip ? vty_ip : vty_get_bind_addr(), vty_port);</span><br><span style="color: hsl(120, 100%, 40%);">+ rc = l23_app_init(mncc_recv_socket, config_file, vty_ip, vty_port);</span><br><span> else</span><br><span> rc = l23_app_init(NULL, config_file, vty_ip, vty_port);</span><br><span> if (rc)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11848">change 11848</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11848"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmocom-bb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Ic63a4eb828ff32d3744886b4f5f6f5019c798620 </div>
<div style="display:none"> Gerrit-Change-Number: 11848 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Max <msuraev@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>