<p>Pau Espin Pedrol has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/11864">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bts: Fix TRX0 param initialization<br><br>TRX0 is allocated in a different place than other TRX.<br><br>Commit that introduced the bug added an initialization step<br>(bts_trx_init) applied in VTY cmd "trx <0-254>", where TRX are allocated<br>since same commit, but doesn't initialize TRX0 for reasons explained in<br>first paragraph.<br><br>As a result, some parameters were not applied to TRX0, like<br>power ramping increment step, which prevented MS from finding the network in<br>osmo-gsm-tester tests.<br><br>Fixes: eebb6a4216f136132400831ca35ed70e7502e92a ("bts: Allocate TRX for BTS dynamically, deprecate -t")<br>Change-Id: I5afd66548634ff53e2af24dc7055d408ca8ca4e3<br>---<br>M src/common/bts.c<br>M src/common/gsm_data_shared.c<br>M src/common/vty.c<br>3 files changed, 7 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/64/11864/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/bts.c b/src/common/bts.c</span><br><span>index 2b17ec6..abbaeb4 100644</span><br><span>--- a/src/common/bts.c</span><br><span>+++ b/src/common/bts.c</span><br><span>@@ -177,6 +177,8 @@</span><br><span>                return rc;</span><br><span>   }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ /* TRX0 was allocated early during gsm_bts_alloc, not later through VTY */</span><br><span style="color: hsl(120, 100%, 40%);">+    bts_trx_init(bts->c0);</span><br><span>    bts_gsmnet.num_bts++;</span><br><span> </span><br><span>    if (!initialized) {</span><br><span>diff --git a/src/common/gsm_data_shared.c b/src/common/gsm_data_shared.c</span><br><span>index 21e5781..beb3107 100644</span><br><span>--- a/src/common/gsm_data_shared.c</span><br><span>+++ b/src/common/gsm_data_shared.c</span><br><span>@@ -333,7 +333,7 @@</span><br><span>       memcpy(&bts->gprs.cell.rlc_cfg, &rlc_cfg_default,</span><br><span>                 sizeof(bts->gprs.cell.rlc_cfg));</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* create our primary TRX */</span><br><span style="color: hsl(120, 100%, 40%);">+  /* create our primary TRX. It will be initialized during bts_init() */</span><br><span>       bts->c0 = gsm_bts_trx_alloc(bts);</span><br><span>         if (!bts->c0) {</span><br><span>           talloc_free(bts);</span><br><span>diff --git a/src/common/vty.c b/src/common/vty.c</span><br><span>index f305413..7c2900f 100644</span><br><span>--- a/src/common/vty.c</span><br><span>+++ b/src/common/vty.c</span><br><span>@@ -233,7 +233,10 @@</span><br><span>                        bts->num_trx, VTY_NEWLINE);</span><br><span>               return CMD_WARNING;</span><br><span>  } else if (trx_nr == bts->num_trx) {</span><br><span style="color: hsl(0, 100%, 40%);">-         /* allocate a new one */</span><br><span style="color: hsl(120, 100%, 40%);">+              /* Allocate a new TRX</span><br><span style="color: hsl(120, 100%, 40%);">+          * Remark: TRX0 was already created during gsm_bts_alloc() and</span><br><span style="color: hsl(120, 100%, 40%);">+                 *         initialized in bts_init(), not here.</span><br><span style="color: hsl(120, 100%, 40%);">+                */</span><br><span>          trx = gsm_bts_trx_alloc(bts);</span><br><span>                if (trx)</span><br><span>                     bts_trx_init(trx);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11864">change 11864</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11864"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I5afd66548634ff53e2af24dc7055d408ca8ca4e3 </div>
<div style="display:none"> Gerrit-Change-Number: 11864 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Pau Espin Pedrol <pespin@sysmocom.de> </div>