<p>Stefan Sperling <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/11839">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Pau Espin Pedrol: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">document unblock-ack vs. signalling in gprs_ns_process_msg()<br><br>Since commit 797558ea1768e464f9559c5f7a4f3f4285c5de25 we send the<br>NS_UNBLOCK_ACK message before dispatching the NS_UNBLOCK signal,<br>instead of afterwards.<br><br>Add comments which explain the intended order of events.<br><br>Suggested-by: Pau<br>Related: OS#2388<br><br>Change-Id: I4b93853c952a97302f8afc14f462f22c3e487564<br>---<br>M src/gb/gprs_ns.c<br>1 file changed, 6 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb/gprs_ns.c b/src/gb/gprs_ns.c</span><br><span>index 0780f2b..1281c9f 100644</span><br><span>--- a/src/gb/gprs_ns.c</span><br><span>+++ b/src/gb/gprs_ns.c</span><br><span>@@ -1413,9 +1413,15 @@</span><br><span>              /* Section 7.2: unblocking procedure */</span><br><span>              LOGP(DNS, LOGL_INFO, "NSEI=%u Rx NS UNBLOCK\n", (*nsvc)->nsei);</span><br><span>                 ns_mark_unblocked(*nsvc);</span><br><span style="color: hsl(120, 100%, 40%);">+             /* This UNBLOCK_ACK message will cause our peer to move us into NS_UNBLOCKED state. */</span><br><span>               rc = gprs_ns_tx_simple(*nsvc, NS_PDUT_UNBLOCK_ACK);</span><br><span>          if (rc < 0)</span><br><span>                       break;</span><br><span style="color: hsl(120, 100%, 40%);">+                /*</span><br><span style="color: hsl(120, 100%, 40%);">+             * UNBLOCK_ACK has been transmitted.</span><br><span style="color: hsl(120, 100%, 40%);">+           * Signal handlers may send additional messages following UNBLOCK_ACK under</span><br><span style="color: hsl(120, 100%, 40%);">+            * the assumption that NS is now in UNBLOCKED state at our peer's end.</span><br><span style="color: hsl(120, 100%, 40%);">+             */</span><br><span>          ns_osmo_signal_dispatch(*nsvc, S_NS_UNBLOCK, 0);</span><br><span>             break;</span><br><span>       case NS_PDUT_UNBLOCK_ACK:</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11839">change 11839</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11839"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I4b93853c952a97302f8afc14f462f22c3e487564 </div>
<div style="display:none"> Gerrit-Change-Number: 11839 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Stefan Sperling <ssperling@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Stefan Sperling <ssperling@sysmocom.de> </div>