<p>Max <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/11457">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Pau Espin Pedrol: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mobile: fix vty bind ip override<br><br>Previously the vty bind config parameter was always ignored. Fix this by using proper<br>default value from the config unless it's explicitly set via command-line parameter.<br><br>Change-Id: I32517567847fd5c54b1742f18bf409ff81e316fa<br>---<br>M src/host/layer23/src/mobile/main.c<br>1 file changed, 4 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/host/layer23/src/mobile/main.c b/src/host/layer23/src/mobile/main.c</span><br><span>index 115ac41..297a534 100644</span><br><span>--- a/src/host/layer23/src/mobile/main.c</span><br><span>+++ b/src/host/layer23/src/mobile/main.c</span><br><span>@@ -31,6 +31,7 @@</span><br><span> #include <osmocom/core/gsmtap.h></span><br><span> #include <osmocom/core/signal.h></span><br><span> #include <osmocom/core/application.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/vty/vty.h></span><br><span> </span><br><span> #include <arpa/inet.h></span><br><span> </span><br><span>@@ -51,7 +52,7 @@</span><br><span> static char *gsmtap_ip = 0;</span><br><span> static const char *custom_cfg_file = NULL;</span><br><span> struct gsmtap_inst *gsmtap_inst = NULL;</span><br><span style="color: hsl(0, 100%, 40%);">-static char *vty_ip = "127.0.0.1";</span><br><span style="color: hsl(120, 100%, 40%);">+static char *vty_ip = NULL;</span><br><span> unsigned short vty_port = 4247;</span><br><span> char *config_dir = NULL;</span><br><span> int use_mncc_sock = 0;</span><br><span>@@ -90,7 +91,7 @@</span><br><span>   printf("  -u --vty-ip           The VTY IP to telnet to. "</span><br><span>                 "(default %s)\n", vty_ip);</span><br><span>         printf("  -v --vty-port            The VTY port number to telnet to. "</span><br><span style="color: hsl(0, 100%, 40%);">-                "(default %u)\n", vty_port);</span><br><span style="color: hsl(120, 100%, 40%);">+                "(default %s)\n", vty_get_bind_addr());</span><br><span>    printf("  -d --debug               Change debug flags. default: %s\n",</span><br><span>             debug_default);</span><br><span>      printf("  -D --daemonize   Run as daemon\n");</span><br><span>@@ -248,7 +249,7 @@</span><br><span>        config_dir = dirname(config_dir);</span><br><span> </span><br><span>        if (use_mncc_sock)</span><br><span style="color: hsl(0, 100%, 40%);">-              rc = l23_app_init(mncc_recv_socket, config_file, vty_ip, vty_port);</span><br><span style="color: hsl(120, 100%, 40%);">+           rc = l23_app_init(mncc_recv_socket, config_file, vty_ip ? vty_ip : vty_get_bind_addr(), vty_port);</span><br><span>   else</span><br><span>                 rc = l23_app_init(NULL, config_file, vty_ip, vty_port);</span><br><span>      if (rc)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/11457">change 11457</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/11457"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmocom-bb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I32517567847fd5c54b1742f18bf409ff81e316fa </div>
<div style="display:none"> Gerrit-Change-Number: 11457 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Max <msuraev@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Max <msuraev@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>